nixos/tests/kubo: use subtests instead of comments

Specify the intent of parts of the tests by using `with subtest("...")` instead of a comment for more clarity.
This commit is contained in:
Luflosi 2023-04-14 02:46:22 +02:00
parent bf97703f0e
commit 409df93c01
No known key found for this signature in database
GPG Key ID: 4E41E29EDCC345D0

View File

@ -25,42 +25,42 @@
testScript = '' testScript = ''
start_all() start_all()
# IPv4 socket activation with subtest("IPv4 socket activation"):
machine.succeed("ipfs --api /ip4/127.0.0.1/tcp/2324 id") machine.succeed("ipfs --api /ip4/127.0.0.1/tcp/2324 id")
ipfs_hash = machine.succeed( ipfs_hash = machine.succeed(
"echo fnord | ipfs --api /ip4/127.0.0.1/tcp/2324 add --quieter" "echo fnord | ipfs --api /ip4/127.0.0.1/tcp/2324 add --quieter"
) )
machine.succeed(f"ipfs cat /ipfs/{ipfs_hash.strip()} | grep fnord") machine.succeed(f"ipfs cat /ipfs/{ipfs_hash.strip()} | grep fnord")
machine.stop_job("ipfs") machine.stop_job("ipfs")
# Unix domain socket activation with subtest("Unix domain socket activation"):
ipfs_hash = machine.succeed( ipfs_hash = machine.succeed(
"echo fnord2 | ipfs --api /unix/run/ipfs.sock add --quieter" "echo fnord2 | ipfs --api /unix/run/ipfs.sock add --quieter"
) )
machine.succeed( machine.succeed(
f"ipfs --api /unix/run/ipfs.sock cat /ipfs/{ipfs_hash.strip()} | grep fnord2" f"ipfs --api /unix/run/ipfs.sock cat /ipfs/{ipfs_hash.strip()} | grep fnord2"
) )
# Test if setting dataDir works properly with the hardened systemd unit with subtest("Setting dataDir works properly with the hardened systemd unit"):
machine.succeed("test -e /mnt/ipfs/config") machine.succeed("test -e /mnt/ipfs/config")
machine.succeed("test ! -e /var/lib/ipfs/") machine.succeed("test ! -e /var/lib/ipfs/")
# Test FUSE mountpoint with subtest("FUSE mountpoint"):
# The FUSE mount functionality is broken as of v0.13.0 and v0.17.0. # The FUSE mount functionality is broken as of v0.13.0 and v0.17.0.
# See https://github.com/ipfs/kubo/issues/9044. # See https://github.com/ipfs/kubo/issues/9044.
# Workaround: using CID Version 1 avoids that. # Workaround: using CID Version 1 avoids that.
ipfs_hash = fuse.succeed( ipfs_hash = fuse.succeed(
"echo fnord3 | ipfs --api /ip4/127.0.0.1/tcp/2324 add --quieter --cid-version=1" "echo fnord3 | ipfs --api /ip4/127.0.0.1/tcp/2324 add --quieter --cid-version=1"
).strip() ).strip()
fuse.succeed(f"cat /ipfs/{ipfs_hash} | grep fnord3") fuse.succeed(f"cat /ipfs/{ipfs_hash} | grep fnord3")
# Force Kubo to crash and wait for it to restart with subtest("Unmounting of /ipns and /ipfs"):
# Tests the unmounting of /ipns and /ipfs # Force Kubo to crash and wait for it to restart
fuse.systemctl("kill --signal=SIGKILL ipfs.service") fuse.systemctl("kill --signal=SIGKILL ipfs.service")
fuse.wait_for_unit("ipfs.service", timeout = 30) fuse.wait_for_unit("ipfs.service", timeout = 30)
fuse.succeed(f"cat /ipfs/{ipfs_hash} | grep fnord3") fuse.succeed(f"cat /ipfs/{ipfs_hash} | grep fnord3")
''; '';
} }