From 1fc12ef70277a80b4cdcd8411f44943443ef97c4 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 19 Dec 2018 13:29:47 +0100 Subject: [PATCH 1/2] nomachine-client: 6.3.6_1 -> 6.4.6_1 --- pkgs/tools/admin/nomachine-client/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/tools/admin/nomachine-client/default.nix b/pkgs/tools/admin/nomachine-client/default.nix index be616c1bf9e0..bc718aeb48c9 100644 --- a/pkgs/tools/admin/nomachine-client/default.nix +++ b/pkgs/tools/admin/nomachine-client/default.nix @@ -1,6 +1,6 @@ { stdenv, lib, file, fetchurl, makeWrapper, autoPatchelfHook, jsoncpp }: let - versionMajor = "6.3"; + versionMajor = "6.4"; versionMinor = "6_1"; in stdenv.mkDerivation rec { @@ -11,12 +11,12 @@ in if stdenv.hostPlatform.system == "x86_64-linux" then fetchurl { url = "https://download.nomachine.com/download/${versionMajor}/Linux/nomachine_${version}_x86_64.tar.gz"; - sha256 = "1035j2z2rqmdfb8cfm1pakd05c575640604b8lkljmilpky9mw5d"; + sha256 = "141pv277kl5ij1pmc0iadc0hnslxri2qaqvsjkmmvls4432jh0yi"; } else if stdenv.hostPlatform.system == "i686-linux" then fetchurl { url = "https://download.nomachine.com/download/${versionMajor}/Linux/nomachine_${version}_i686.tar.gz"; - sha256 = "07j9f6mlq9m01ch8ik5dybi283vrp5dlv156jr5n7n2chzk34kf3"; + sha256 = "0a2vi4ygw34yw8rcjhw17mqx5qbjnym4jkap8paik8lisb5mhnyj"; } else throw "NoMachine client is not supported on ${stdenv.hostPlatform.system}"; From aaf353e7ad5f1519a884a8066f60bd49c66cb2f7 Mon Sep 17 00:00:00 2001 From: talyz Date: Wed, 19 Dec 2018 14:14:09 +0100 Subject: [PATCH 2/2] nomachine-client: Fix audio support libnxcau.so needs libpulse.so.0 for audio to work, but doesn't have a DT_NEEDED entry for it, so it's not automatically detected. This adds the missing entry and libpulseaudio to buildInputs, enabling autoPatchelfHook to fix the RPATH. --- pkgs/tools/admin/nomachine-client/default.nix | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/tools/admin/nomachine-client/default.nix b/pkgs/tools/admin/nomachine-client/default.nix index bc718aeb48c9..32d0e584f31a 100644 --- a/pkgs/tools/admin/nomachine-client/default.nix +++ b/pkgs/tools/admin/nomachine-client/default.nix @@ -1,4 +1,5 @@ -{ stdenv, lib, file, fetchurl, makeWrapper, autoPatchelfHook, jsoncpp }: +{ stdenv, lib, file, fetchurl, makeWrapper, + autoPatchelfHook, jsoncpp, libpulseaudio }: let versionMajor = "6.4"; versionMinor = "6_1"; @@ -31,7 +32,7 @@ in ''; nativeBuildInputs = [ file makeWrapper autoPatchelfHook ]; - buildInputs = [ jsoncpp ]; + buildInputs = [ jsoncpp libpulseaudio ]; installPhase = '' rm bin/nxplayer bin/nxclient @@ -63,6 +64,10 @@ in postFixup = '' makeWrapper $out/bin/nxplayer.bin $out/bin/nxplayer --set NX_SYSTEM $out/NX makeWrapper $out/bin/nxclient.bin $out/bin/nxclient --set NX_SYSTEM $out/NX + + # libnxcau.so needs libpulse.so.0 for audio to work, but doesn't + # have a DT_NEEDED entry for it. + patchelf --add-needed libpulse.so.0 $out/NX/lib/libnxcau.so ''; dontBuild = true;