From 472a5192fd67c40bded56a594eeaaa86ee9bde4b Mon Sep 17 00:00:00 2001 From: Austin Seipp Date: Thu, 7 Jan 2016 04:51:58 -0600 Subject: [PATCH] Revert "nixos: tarsnap - separate archive cachedirs" This reverts commit 5f0253ace683bae4c7989f4db167676dd0a507e7. I didn't intend to push this - I meant to push it to *my fork's* remote... --- nixos/modules/services/backup/tarsnap.nix | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/nixos/modules/services/backup/tarsnap.nix b/nixos/modules/services/backup/tarsnap.nix index f0b250689494..57121e238553 100644 --- a/nixos/modules/services/backup/tarsnap.nix +++ b/nixos/modules/services/backup/tarsnap.nix @@ -5,8 +5,8 @@ with lib; let cfg = config.services.tarsnap; - configFile = name: cfg: '' - cachedir ${config.services.tarsnap.cachedir}/${name} + configFile = cfg: '' + cachedir ${config.services.tarsnap.cachedir} keyfile ${config.services.tarsnap.keyfile} ${optionalString cfg.nodump "nodump"} ${optionalString cfg.printStats "print-stats"} @@ -57,12 +57,6 @@ in will refuse to run until you manually rebuild the cache with tarsnap --fsck. - Note that each individual archive (specified below) has its own cache - directory specified under cachedir; this is because - tarsnap locks the cache during backups, meaning multiple services - archives cannot be backed up concurrently or overlap with a shared - cache. - Set to null to disable caching. ''; }; @@ -257,7 +251,6 @@ in mkdir -p -m 0700 ${cfg.cachedir} chown root:root ${cfg.cachedir} chmod 0700 ${cfg.cachedir} - mkdir -p -m 0700 ${cfg.cachedir}/$1 DIRS=`cat /etc/tarsnap/$1.dirs` exec tarsnap --configfile /etc/tarsnap/$1.conf -c -f $1-$(date +"%Y%m%d%H%M%S") $DIRS ''; @@ -276,7 +269,7 @@ in environment.etc = (mapAttrs' (name: cfg: nameValuePair "tarsnap/${name}.conf" - { text = configFile name cfg; + { text = configFile cfg; }) cfg.archives) // (mapAttrs' (name: cfg: nameValuePair "tarsnap/${name}.dirs" { text = concatStringsSep " " cfg.directories;