ilyakooo0/nixpkgs
1
0
Fork 0
mirror of https://github.com/ilyakooo0/nixpkgs.git synced 2024-12-26 04:43:09 +03:00
Code Issues Projects Releases Wiki Activity

Make more visible which fetch approach is best

Browse Source 
Prepend "bad/better/best" to each paragraph, to make more visible which approach is best
This commit is contained in:
Lorenzo Manacorda 2017-01-30 11:28:52 +01:00 committed by GitHub
parent 92a3ecf4a3
commit 4e0bb261d0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/coding-conventions.xml
View File

@ -623,7 +623,7 @@ evaluate correctly.</para>
from bad to good: from bad to good:
<itemizedlist> <itemizedlist>
<listitem> <listitem>
<para>Uses <literal>git://</literal> which won't be proxied. <para>Bad: Uses <literal>git://</literal> which won't be proxied.
<programlisting> <programlisting>
src = fetchgit { src = fetchgit {
url = "git://github.com/NixOS/nix.git"; url = "git://github.com/NixOS/nix.git";
@ -634,7 +634,7 @@ src = fetchgit {
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para>This is ok, but an archive fetch will still be faster. <para>Better: This is ok, but an archive fetch will still be faster.
<programlisting> <programlisting>
src = fetchgit { src = fetchgit {
url = "https://github.com/NixOS/nix.git"; url = "https://github.com/NixOS/nix.git";
@ -645,7 +645,7 @@ src = fetchgit {
</para> </para>
</listitem> </listitem>
<listitem> <listitem>
<para>Fetches a snapshot archive and you get the rev you want. <para>Best: Fetches a snapshot archive and you get the rev you want.
<programlisting> <programlisting>
src = fetchFromGitHub { src = fetchFromGitHub {
owner = "NixOS"; owner = "NixOS";