From 5365ecb40b0e6f9cfc94ee58904373a09e856220 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felix=20Schr=C3=B6ter?= Date: Sat, 23 Sep 2023 20:32:08 +0200 Subject: [PATCH] rome: remove rome is no longer maintained. A fork called biome is available in nixpkgs. --- .../manual/release-notes/rl-2311.section.md | 2 + pkgs/development/tools/rome/default.nix | 58 ------------------- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 2 - 4 files changed, 3 insertions(+), 60 deletions(-) delete mode 100644 pkgs/development/tools/rome/default.nix diff --git a/nixos/doc/manual/release-notes/rl-2311.section.md b/nixos/doc/manual/release-notes/rl-2311.section.md index 57f40bad368e..7b3a17e546f2 100644 --- a/nixos/doc/manual/release-notes/rl-2311.section.md +++ b/nixos/doc/manual/release-notes/rl-2311.section.md @@ -222,6 +222,8 @@ - `networking.networkmanager.firewallBackend` was removed as NixOS is now using iptables-nftables-compat even when using iptables, therefore Networkmanager now uses the nftables backend unconditionally. +- `rome` was removed because it is no longer maintained and is succeeded by `biome`. + ## Other Notable Changes {#sec-release-23.11-notable-changes} - The Cinnamon module now enables XDG desktop integration by default. If you are experiencing collisions related to xdg-desktop-portal-gtk you can safely remove `xdg.portal.extraPortals = [ pkgs.xdg-desktop-portal-gtk ];` from your NixOS configuration. diff --git a/pkgs/development/tools/rome/default.nix b/pkgs/development/tools/rome/default.nix deleted file mode 100644 index 5d5e82942e79..000000000000 --- a/pkgs/development/tools/rome/default.nix +++ /dev/null @@ -1,58 +0,0 @@ -{ lib -, rustPlatform -, fetchFromGitHub -, pkg-config -, stdenv -, darwin -, nix-update-script -}: - -rustPlatform.buildRustPackage rec { - pname = "rome"; - version = "12.1.3"; - - src = fetchFromGitHub { - owner = "rome"; - repo = "tools"; - rev = "cli/v${version}"; - hash = "sha256-BlHpdfbyx6nU44vasEw0gRZ0ickyD2eUXPfeFZHSCbI="; - }; - - cargoHash = "sha256-jHdoRymKPjBonT4TvAiTNzGBuTcNoPsvdFKEf33dpVc="; - - cargoBuildFlags = [ "--package" "rome_cli" ]; - - env = { - RUSTFLAGS = "-C strip=symbols"; - ROME_VERSION = version; - }; - - buildInputs = - lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ]; - - nativeBuildInputs = [ pkg-config ]; - - # need to manually unset the ROME_VERSION before checkPhase otherwise some tests fail - preCheck = '' - unset ROME_VERSION; - ''; - - # these test fail - checkFlags = [ - "--skip parser::tests::uncompleted_markers_panic" - "--skip commands::check::fs_error_infinite_symlink_exapansion" - "--skip commands::check::fs_error_dereferenced_symlink" - ]; - - passthru.updateScript = nix-update-script { - extraArgs = [ "--version-regex" "cli%2Fv(.*)" ]; - }; - - meta = with lib; { - description = "A formatter, linter, bundler, and more for JavaScript, TypeScript, JSON, HTML, Markdown, and CSS"; - homepage = "https://rome.tools"; - changelog = "https://github.com/rome/tools/blob/${src.rev}/CHANGELOG.md"; - license = licenses.mit; - maintainers = with maintainers; [ dit7ya felschr ]; - }; -} diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index dc5728ab35d3..ecebbf9591ab 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -1580,6 +1580,7 @@ mapAliases ({ robomongo = throw "'robomongo' has been renamed to/replaced by 'robo3t'"; # Converted to throw 2022-02-22 rockbox_utility = rockbox-utility; # Added 2022-03-17 rocm-runtime-ext = throw "rocm-runtime-ext has been removed, since its functionality was added to rocm-runtime"; #added 2020-08-21 + rome = throw "rome is no longer maintained, consider using biome instead"; # Added 2023-09-12 rpiboot-unstable = rpiboot; # Added 2021-07-30 rr-unstable = rr; # Added 2022-09-17 rssglx = throw "'rssglx' has been renamed to/replaced by 'rss-glx'"; # Converted to throw 2022-02-22 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 55a35a80e463..56ca775d40e9 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -20160,8 +20160,6 @@ with pkgs; rolespec = callPackage ../development/tools/misc/rolespec { }; - rome = callPackage ../development/tools/rome { }; - rr = callPackage ../development/tools/analysis/rr { }; rsass = callPackage ../development/tools/misc/rsass { };