From dfd695979f592273519318b81e265c2ca0685122 Mon Sep 17 00:00:00 2001
From: Jan Moeller <jan.moeller0@gmail.com>
Date: Thu, 30 May 2024 21:47:45 +0200
Subject: [PATCH 1/2] updatecli: improve package quality

- remove superfluous use of `pname`
- add `testers.testVersion`
---
 pkgs/by-name/up/updatecli/package.nix | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/pkgs/by-name/up/updatecli/package.nix b/pkgs/by-name/up/updatecli/package.nix
index c3999383ba9e..dd60bdf8a166 100644
--- a/pkgs/by-name/up/updatecli/package.nix
+++ b/pkgs/by-name/up/updatecli/package.nix
@@ -4,6 +4,8 @@
 , fetchFromGitHub
 , nix-update-script
 , installShellFiles
+, testers
+, updatecli
 }:
 
 buildGoModule rec {
@@ -12,7 +14,7 @@ buildGoModule rec {
 
   src = fetchFromGitHub {
     owner = "updatecli";
-    repo = pname;
+    repo = "updatecli";
     rev = "v${version}";
     hash = "sha256-sBkTdr4/DqNrCxtaM1tVTx+rQ1dvJ1KwlFvAJHIZCuw=";
   };
@@ -32,7 +34,13 @@ buildGoModule rec {
     "-X github.com/updatecli/updatecli/pkg/core/version.Version=${version}"
   ];
 
-  passthru.updateScript = nix-update-script { };
+  passthru = {
+    updateScript = nix-update-script { };
+    tests.version = testers.testVersion {
+      package = updatecli;
+      command = "updatecli version";
+    };
+  };
 
   nativeBuildInputs = [ installShellFiles ];
 
@@ -52,7 +60,7 @@ buildGoModule rec {
       Updatecli is a command-line tool used to define and apply update strategies.
     '';
     homepage = "https://www.updatecli.io";
-    changelog = "https://github.com/updatecli/updatecli/releases/tag/v${version}";
+    changelog = "https://github.com/updatecli/updatecli/releases/tag/${src.rev}";
     license = licenses.asl20;
     mainProgram = "updatecli";
     maintainers = with maintainers; [ croissong ];

From cdf10e27a99743bfcfd745683ee6c41e5775d485 Mon Sep 17 00:00:00 2001
From: Jan Moeller <jan.moeller0@gmail.com>
Date: Fri, 31 May 2024 00:19:48 +0200
Subject: [PATCH 2/2] updatecli: format with nixfmt-rfc-style

---
 pkgs/by-name/up/updatecli/package.nix | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/pkgs/by-name/up/updatecli/package.nix b/pkgs/by-name/up/updatecli/package.nix
index dd60bdf8a166..f37d847db2ca 100644
--- a/pkgs/by-name/up/updatecli/package.nix
+++ b/pkgs/by-name/up/updatecli/package.nix
@@ -1,11 +1,12 @@
-{ lib
-, go
-, buildGoModule
-, fetchFromGitHub
-, nix-update-script
-, installShellFiles
-, testers
-, updatecli
+{
+  lib,
+  go,
+  buildGoModule,
+  fetchFromGitHub,
+  nix-update-script,
+  installShellFiles,
+  testers,
+  updatecli,
 }:
 
 buildGoModule rec {