From 673b18fdd72636408dc732fa01675e4c48d260d6 Mon Sep 17 00:00:00 2001
From: "William A. Kennington III" <william@wkennington.com>
Date: Fri, 6 Feb 2015 12:21:57 -0800
Subject: [PATCH] protobuf: Support both 2.5 and 2.6 and make 2.6 the default

---
 pkgs/development/libraries/protobuf/2.5.nix   |  9 +++++++++
 pkgs/development/libraries/protobuf/2.6.nix   | 11 ++++++++++
 .../protobuf/{default.nix => generic.nix}     | 20 ++++++++++++-------
 pkgs/top-level/all-packages.nix               |  4 +++-
 4 files changed, 36 insertions(+), 8 deletions(-)
 create mode 100644 pkgs/development/libraries/protobuf/2.5.nix
 create mode 100644 pkgs/development/libraries/protobuf/2.6.nix
 rename pkgs/development/libraries/protobuf/{default.nix => generic.nix} (65%)

diff --git a/pkgs/development/libraries/protobuf/2.5.nix b/pkgs/development/libraries/protobuf/2.5.nix
new file mode 100644
index 000000000000..4cc6a68c9f20
--- /dev/null
+++ b/pkgs/development/libraries/protobuf/2.5.nix
@@ -0,0 +1,9 @@
+{ callPackage, fetchurl, ... } @ args:
+
+callPackage ./generic.nix (args // rec {
+  version = "2.5.0";
+  src = fetchurl {
+    url = "http://protobuf.googlecode.com/files/${version}.tar.bz2";
+    sha256 = "0xxn9gxhvsgzz2sgmihzf6pf75clr05mqj6218camwrwajpcbgqk";
+  };
+})
diff --git a/pkgs/development/libraries/protobuf/2.6.nix b/pkgs/development/libraries/protobuf/2.6.nix
new file mode 100644
index 000000000000..72960b0dd6af
--- /dev/null
+++ b/pkgs/development/libraries/protobuf/2.6.nix
@@ -0,0 +1,11 @@
+{ callPackage, fetchFromGitHub, ... } @ args:
+
+callPackage ./generic.nix (args // rec {
+  version = "2.6.1";
+  src = fetchFromGitHub {
+    owner = "google";
+    repo = "protobuf";
+    rev = "v${version}";
+    sha256 = "03df8zvx2sry3jz2x4pi3l32qyfqa7w8kj8jdbz30nzy0h7aa070";
+  };
+})
diff --git a/pkgs/development/libraries/protobuf/default.nix b/pkgs/development/libraries/protobuf/generic.nix
similarity index 65%
rename from pkgs/development/libraries/protobuf/default.nix
rename to pkgs/development/libraries/protobuf/generic.nix
index bba8481780a5..003ea7035172 100644
--- a/pkgs/development/libraries/protobuf/default.nix
+++ b/pkgs/development/libraries/protobuf/generic.nix
@@ -1,14 +1,20 @@
-{ fetchurl, stdenv, zlib }:
+{ stdenv, version, src
+, autoreconfHook, zlib, gtest
+, ...
+}:
 
 stdenv.mkDerivation rec {
-  name = "protobuf-2.5.0";
+  name = "protobuf-${version}";
 
-  src = fetchurl {
-    url = "http://protobuf.googlecode.com/files/${name}.tar.bz2";
-    sha256 = "0xxn9gxhvsgzz2sgmihzf6pf75clr05mqj6218camwrwajpcbgqk";
-  };
+  inherit src;
 
-  buildInputs = [ zlib ];
+  postPatch = ''
+    rm -rf gtest
+    cp -r ${gtest.source} gtest
+    chmod -R a+w gtest
+  '';
+
+  buildInputs = [ autoreconfHook zlib ];
 
   doCheck = true;
 
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index f4b0d392c7e0..2fde2b6ff90a 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -6963,7 +6963,9 @@ let
 
   postgis = callPackage ../development/libraries/postgis { };
 
-  protobuf = callPackage ../development/libraries/protobuf { };
+  protobuf = protobuf2_6;
+  protobuf2_6 = callPackage ../development/libraries/protobuf/2.6.nix { };
+  protobuf2_5 = callPackage ../development/libraries/protobuf/2.5.nix { };
 
   protobufc = callPackage ../development/libraries/protobufc { };