From 8f292e361367bddbdab3f6c89359041519f126e8 Mon Sep 17 00:00:00 2001 From: Thiago Kenji Okada Date: Sun, 9 Oct 2022 14:44:40 +0100 Subject: [PATCH] retroarch: mark as broken in macOS This doesn't change to much since the wrapper is also broken. --- pkgs/applications/emulators/retroarch/default.nix | 11 +++++------ pkgs/applications/emulators/retroarch/wrapper.nix | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/pkgs/applications/emulators/retroarch/default.nix b/pkgs/applications/emulators/retroarch/default.nix index 2e929debc34b..1754ad5eccb6 100644 --- a/pkgs/applications/emulators/retroarch/default.nix +++ b/pkgs/applications/emulators/retroarch/default.nix @@ -129,12 +129,7 @@ stdenv.mkDerivation rec { # Workaround for the following error affecting newer versions of Clang: # ./config.def.h:xxx:x: error: 'TARGET_OS_TV' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_] - NIX_CFLAGS_COMPILE = lib.optionals stdenv.cc.isClang [ "-Wno-undef-prefix" ] - # Workaround build failure on -fno-common toolchains: - # duplicate symbol '_apple_platform' in:ui_cocoa.o cocoa_common.o - # TODO: drop when upstream gets a fix for it: - # https://github.com/libretro/RetroArch/issues/14025 - ++ lib.optionals stdenv.isDarwin [ "-fcommon" ]; + NIX_CFLAGS_COMPILE = lib.optionals stdenv.cc.isClang [ "-Wno-undef-prefix" ]; passthru.tests = nixosTests.retroarch; @@ -145,5 +140,9 @@ stdenv.mkDerivation rec { platforms = platforms.unix; changelog = "https://github.com/libretro/RetroArch/blob/v${version}/CHANGES.md"; maintainers = with maintainers; teams.libretro.members ++ [ matthewbauer kolbycrouch ]; + # FIXME: error while building in macOS: + # "Undefined symbols for architecture " + # See also retroarch/wrapper.nix that is also broken in macOS + broken = stdenv.isDarwin; }; } diff --git a/pkgs/applications/emulators/retroarch/wrapper.nix b/pkgs/applications/emulators/retroarch/wrapper.nix index 6adcb8ffd8b4..535cd40db6c3 100644 --- a/pkgs/applications/emulators/retroarch/wrapper.nix +++ b/pkgs/applications/emulators/retroarch/wrapper.nix @@ -34,7 +34,7 @@ stdenv.mkDerivation { The following cores are included: ${lib.concatStringsSep "\n" (map (x: " - ${x.name}") cores)} ''; - # FIXME: exits with error on macOS: + # FIXME: exit with error on macOS: # No Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file, exiting broken = stdenv.isDarwin; };