From 127050d851126bebbbd253ed2bebcd6f267754ac Mon Sep 17 00:00:00 2001
From: Joachim Fasting <joachifm@fastmail.fm>
Date: Sun, 3 May 2015 00:22:23 +0200
Subject: [PATCH] cppcheck: 1.68 -> 1.69

Also update meta and install man page.
---
 .../tools/analysis/cppcheck/default.nix       | 30 +++++++++++--------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/pkgs/development/tools/analysis/cppcheck/default.nix b/pkgs/development/tools/analysis/cppcheck/default.nix
index d94d44836820..53397786dc49 100644
--- a/pkgs/development/tools/analysis/cppcheck/default.nix
+++ b/pkgs/development/tools/analysis/cppcheck/default.nix
@@ -1,29 +1,35 @@
-{ stdenv, fetchurl }:
-
-# TODO: add support for "make man"
+{ stdenv, fetchurl, libxslt, docbook_xsl, docbook_xml_dtd_45 }:
 
 let
   name = "cppcheck";
-  version = "1.68";
+  version = "1.69";
 in
 stdenv.mkDerivation {
   name = "${name}-${version}";
 
   src = fetchurl {
     url = "mirror://sourceforge/${name}/${name}-${version}.tar.bz2";
-    sha256 = "1ca9fdhrrxfyzd6kn67gxbfszp70191cf3ndasrh5jh55ghybmmd";
+    sha256 = "0bjkqy4c6ph6nzparcnbxrdn52i3hiind4jc99v2kvsq281wimab";
   };
 
-  configurePhase = ''
-    makeFlags="PREFIX=$out CFGDIR=$out/cfg"
+  buildInputs = [ libxslt docbook_xsl docbook_xml_dtd_45 ];
+
+  makeFlags = ''PREFIX=$(out) CFGDIR=$(out)/cfg'';
+
+  postInstall = ''
+    make DB2MAN=${docbook_xsl}/xml/xsl/docbook/manpages/docbook.xsl man
+    mkdir -p $out/share/man/man1
+    cp cppcheck.1 $out/share/man/man1/cppcheck.1
   '';
 
-  postInstall = "cp -r cfg $out/cfg";
-
   meta = {
-    description = "Check C/C++ code for memory leaks, mismatching allocation-deallocation, buffer overrun and more";
-    homepage = "http://sourceforge.net/apps/mediawiki/cppcheck/";
-    license = "GPL";
+    description = "A static analysis tool for C/C++ code";
+    longDescription = ''
+      Check C/C++ code for memory leaks, mismatching
+      allocation-deallocation, buffer overruns and more.
+    '';
+    homepage = http://cppcheck.sourceforge.net/;
+    license = stdenv.lib.licenses.gpl3Plus;
     platforms = stdenv.lib.platforms.unix;
     maintainers = [ stdenv.lib.maintainers.simons ];
   };