Merge pull request #56783 from dotlambda/udiskie-fix

udiskie: fix build

pkgs/applications/misc/udiskie/default.nix

@@ -1,14 +1,11 @@
 { stdenv, fetchFromGitHub, asciidoc-full, gettext
 , gobject-introspection, gtk3, hicolor-icon-theme, libappindicator-gtk3, libnotify, librsvg
 , udisks2, wrapGAppsHook
-, buildPythonApplication
+, python3Packages
-, docopt
-, pygobject3
-, pyyaml
 }:
 
-buildPythonApplication rec {
+python3Packages.buildPythonApplication rec {
-  name = "udiskie-${version}";
+  pname = "udiskie";
   version = "1.7.7";
 
   src = fetchFromGitHub {
@@ -18,16 +15,27 @@ buildPythonApplication rec {
     sha256 = "1j17z26vy44il2s9zgchvhq280vq8ag64ddi35f35b444wz2azlb";
   };
 
-  buildInputs = [
+  nativeBuildInputs = [
+    gettext
     asciidoc-full        # For building man page.
-    hicolor-icon-theme
+    gobject-introspection
     wrapGAppsHook
-    librsvg              # required for loading svg icons (udiskie uses svg icons)
   ];
 
-  propagatedBuildInputs = [
+  buildInputs = [
-    gettext gobject-introspection gtk3 libnotify docopt
+    hicolor-icon-theme
-    pygobject3 pyyaml udisks2 libappindicator-gtk3
+    librsvg              # required for loading svg icons (udiskie uses svg icons)
+    gobject-introspection
+    libnotify
+    gtk3
+    udisks2
+    libappindicator-gtk3
+  ];
+
+  propagatedBuildInputs = with python3Packages; [
+    docopt
+    pygobject3
+    pyyaml
   ];
 
   postBuild = "make -C doc";
@@ -37,8 +45,14 @@ buildPythonApplication rec {
     cp -v doc/udiskie.8 $out/share/man/man8/
   '';
 
-  # tests require dbusmock
+  checkInputs = with python3Packages; [
-  doCheck = false;
+    nose
+    keyutils
+  ];
+
+  checkPhase = ''
+    nosetests
+  '';
 
   meta = with stdenv.lib; {
     description = "Removable disk automounter for udisks";

pkgs/top-level/all-packages.nix

@@ -19242,7 +19242,7 @@ in
 
   udevil = callPackage ../applications/misc/udevil {};
 
-  udiskie = python3Packages.callPackage ../applications/misc/udiskie { };
+  udiskie = callPackage ../applications/misc/udiskie { };
 
   sakura = callPackage ../applications/misc/sakura { };