ilyakooo0/nixpkgs
1
0
Fork 0
mirror of https://github.com/ilyakooo0/nixpkgs.git synced 2024-09-11 07:15:54 +03:00
Code Issues Projects Releases Wiki Activity

nixos/samba-wsdd: add openFirewall option

Browse Source
This commit is contained in:
Varun Madiath 2023-07-13 14:06:44 -04:00
parent 2de8efefb6
commit d237a7318c
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
nixos/modules/services/network-filesystems/samba-wsdd.nix
View File

@ -11,13 +11,6 @@ in {
enable = mkEnableOption (lib.mdDoc '' enable = mkEnableOption (lib.mdDoc ''
Web Services Dynamic Discovery host daemon. This enables (Samba) hosts, like your local NAS device, Web Services Dynamic Discovery host daemon. This enables (Samba) hosts, like your local NAS device,
to be found by Web Service Discovery Clients like Windows. to be found by Web Service Discovery Clients like Windows.
::: {.note}
If you use the firewall consider adding the following:
networking.firewall.allowedTCPPorts = [ 5357 ];
networking.firewall.allowedUDPPorts = [ 3702 ];
:::
''); '');
interface = mkOption { interface = mkOption {
type = types.nullOr types.str; type = types.nullOr types.str;
@ -31,6 +24,13 @@ in {
example = 2; example = 2;
description = lib.mdDoc "Hop limit for multicast packets (default = 1)."; description = lib.mdDoc "Hop limit for multicast packets (default = 1).";
}; };
openFirewall = mkOption {
description = lib.mdDoc ''
Whether to open the required firewall ports in the firewall.
'';
default = false;
type = lib.types.bool;
};
workgroup = mkOption { workgroup = mkOption {
type = types.nullOr types.str; type = types.nullOr types.str;
default = null; default = null;
@ -120,5 +120,10 @@ in {
SystemCallFilter = "~@cpu-emulation @debug @mount @obsolete @privileged @resources"; SystemCallFilter = "~@cpu-emulation @debug @mount @obsolete @privileged @resources";
}; };
}; };
networking.firewall = mkIf cfg.openFirewall {
allowedTCPPorts = [ 5357 ];
allowedUDPPorts = [ 3702 ];
};
}; };
} }

6
nixos/tests/samba-wsdd.nix
View File

@ -8,25 +8,23 @@ import ./make-test-python.nix ({ pkgs, ... }:
client_wsdd = { pkgs, ... }: { client_wsdd = { pkgs, ... }: {
services.samba-wsdd = { services.samba-wsdd = {
enable = true; enable = true;
openFirewall = true;
interface = "eth1"; interface = "eth1";
workgroup = "WORKGROUP"; workgroup = "WORKGROUP";
hostname = "CLIENT-WSDD"; hostname = "CLIENT-WSDD";
discovery = true; discovery = true;
extraOptions = [ "--no-host" ]; extraOptions = [ "--no-host" ];
}; };
networking.firewall.allowedTCPPorts = [ 5357 ];
networking.firewall.allowedUDPPorts = [ 3702 ];
}; };
server_wsdd = { ... }: { server_wsdd = { ... }: {
services.samba-wsdd = { services.samba-wsdd = {
enable = true; enable = true;
openFirewall = true;
interface = "eth1"; interface = "eth1";
workgroup = "WORKGROUP"; workgroup = "WORKGROUP";
hostname = "SERVER-WSDD"; hostname = "SERVER-WSDD";
}; };
networking.firewall.allowedTCPPorts = [ 5357 ];
networking.firewall.allowedUDPPorts = [ 3702 ];
}; };
}; };