From d54bdf5504cfe43937e4cfc1f3e03ad621f74b87 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Thu, 5 Sep 2019 00:13:24 +0200 Subject: [PATCH] lib/makeOverridable: Propagate function arguments to override functions This allows querying the arguments you can .override: nix-repl> lib.functionArgs pkgs.hello.override { fetchurl = false; stdenv = false; } --- lib/customisation.nix | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/customisation.nix b/lib/customisation.nix index 21bab1ab4bcd..09d7fbf74b0f 100644 --- a/lib/customisation.nix +++ b/lib/customisation.nix @@ -67,12 +67,14 @@ rec { makeOverridable = f: origArgs: let ff = f origArgs; + # Creates a functor with the same arguments as f + copyArgs = g: lib.setFunctionArgs g (lib.functionArgs f); overrideWith = newArgs: origArgs // (if lib.isFunction newArgs then newArgs origArgs else newArgs); # Re-call the function but with different arguments - overrideArgs = newArgs: makeOverridable f (overrideWith newArgs); + overrideArgs = copyArgs (newArgs: makeOverridable f (overrideWith newArgs)); # Change the result of the function call by applying g to it - overrideResult = g: makeOverridable (args: g (f args)) origArgs; + overrideResult = g: makeOverridable (copyArgs (args: g (f args))) origArgs; in if builtins.isAttrs ff then (ff // { override = overrideArgs;