Commit 49d0a5afd mistakenly inverted when to apply the patch.
Maybe it's not needed anymore, as pkgsMusl.e2fsprogs succeeded for me
even without it, but it looks harmless and better not have it inversed.
This way we also don't cause a mass rebuild :-)
Without the change upstream gcc-10 fails to build as:
ld: src/common/mgmt/pint-worker-external.po:(.data.rel.local+0x0): multiple definition of
`PINT_worker_external_impl'; src/common/mgmt/pint-mgmt.po:(.bss+0x20): first defined here
btrfs-progs currently builds the Python bindings for libbtrfsutil but doesn't
actually install them. With this patch, the bindings are installed and exposed
as python3Packages.btrfsutil.
Without the change build fails on upstream gcc-10 as:
ld: /build/ccadKet8.o:/build/source/cloudfsapi.h:73: multiple definition of
`public_container'; /build/ccoYHN4x.o:/build/source/cloudfsapi.h:73: first defined here
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:
ld: extract.o:/build/jfsutils-1.1.15/fscklog/extract.c:67: multiple definition of
`xchklog_buffer'; display.o:/build/jfsutils-1.1.15/fscklog/display.c:57: first defined here
Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:
ld: lib/auth_rpc.o:/build/source/lib/../9pfs.h:35: multiple definition of
`logfile'; 9pfs.o:/build/source/9pfs.h:35: first defined here
Without the change -fno-common toolchains like upstream gcc-10
fail to build as:
ld: afpcmd-cmdline_main.o:/build/source/cmdline/cmdline_afp.h:4: multiple definition of
`full_url'; afpcmd-cmdline_afp.o:/build/source/cmdline/cmdline_afp.c:27: first defined here
Without the update build fails on -fno-common toolchains as:
$ nix build --impure --expr 'with import ./. {}; netatalk.override { stdenv = clang13Stdenv; }' -L
...
ld: afpd-volume.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94:
multiple definition of `invalid_dircache_entries'; afpd-afp_dsi.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94: first defined here
ld: afpd-acls.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94:
multiple definition of `invalid_dircache_entries'; afpd-afp_dsi.o:/build/netatalk-3.1.12/etc/afpd/./directory.h:94: first defined here
Changes: https://netatalk.sourceforge.io/3.1/ReleaseNotes3.1.13.html
