ilyakooo0/nixpkgs
1
0
Fork 0
mirror of https://github.com/ilyakooo0/nixpkgs.git synced 2024-09-27 15:49:39 +03:00
Code Issues Projects Releases Wiki Activity
Nix Packages collection
191,221 Commits 96 Branches 102 Tags 4.3 GiB
Nix 95.5%
Shell 2%
Python 1.3%
Perl 0.2%
C 0.2%
Other 0.3%
d7c7fc4603
Go to file
aszlig d7c7fc4603 nixos/tests/systemd: Fix x-initrd-mount flakiness (#67798) 
It turns out that checking for the last mount time of an ext4 file
system isn't a very reliable way to check whether the file system was
properly unmounted.

When creating that test in the first place (88530e02b6),
I was reluctant to inspect the file system when the VM is down and was
searching for a way to check for a clean unmount *after* the file system
was mounted again to make sure we don't need to create a 512 MB raw
image on the host.

Fortunately however, when converting from qcow2, qemu-img actually
writes a sparse file, so for most file systems (that is, file systems
supporting sparse files) this shouldn't waste a lot of disk space.

So when investigating the flakiness, I found that whenever the test is
failing, the unmount of /test-x-initrd-mount was done *before* the final
step during which systemd remounts+unmounts all the remaining file
systems.

I haven't investigated why this is the case, but the test is a
regression test for https://github.com/NixOS/nixpkgs/issues/35268, which
actually didn't unmount the file system *at* *all*, so really all we
need to take care here is whether the unmount has happened and not
*how*.

To make sure that checking the filesystem state is enough for this, I
temporarily replaced the $machine->shutdown call with $machine->crash
and verified that the file system state is "not clean".

Signed-off-by: aszlig <aszlig@nix.build>
Fixes: https://github.com/NixOS/nixpkgs/issues/67555
2019-08-31 00:30:50 -04:00
.github CODEOWNERS: Add myself as owner for emacs 2019-08-30 17:23:13 +01:00
doc emacsPackages: Drop old emacsPackages (non-NG) sets 2019-08-30 16:43:16 +01:00
lib Merge pull request #66407 from Infinisil/fix-option-rename 2019-08-27 22:06:23 +02:00
maintainers Merge pull request #67683 from rnhmjoj/rnhmjoj 2019-08-30 10:26:16 +02:00
nixos nixos/tests/systemd: Fix x-initrd-mount flakiness (#67798) 2019-08-31 00:30:50 -04:00
pkgs python.pkgs.handout: init at 1.0.0 (#66263) 2019-08-31 00:19:16 -04:00
.editorconfig Revert ".version: remove final newline" 2018-04-28 14:23:13 +02:00
.gitattributes gitattributes: disable merge=union in all-packages 2018-03-27 11:03:03 -05:00
.gitignore Replace androidenv by new implementation 2018-12-18 21:16:06 +01:00
.version 19.09 is Loris. 2019-02-25 23:21:14 +01:00
COPYING COPYING: include 2019 2019-03-18 19:55:33 -07:00
default.nix Fix local path to release notes in error message 2018-10-08 05:43:15 -05:00
README.md README: add open collective badge 2019-07-17 14:27:28 +02:00

README.md

logo

Code Triagers Badge Open Collective supporters

Nixpkgs is a collection of packages for the Nix package manager. It is periodically built and tested by the Hydra build daemon as so-called channels. To get channel information via git, add nixpkgs-channels as a remote:

% git remote add channels https://github.com/NixOS/nixpkgs-channels.git

For stability and maximum binary package support, it is recommended to maintain custom changes on top of one of the channels, e.g. nixos-19.03 for the latest release and nixos-unstable for the latest successful build of master:

% git remote update channels
% git rebase channels/nixos-19.03

For pull requests, please rebase onto nixpkgs master.

NixOS Linux distribution source code is located inside nixos/ folder.

Communication:

Note: MIT license does not apply to the packages built by Nixpkgs, merely to the package descriptions (Nix expressions, build scripts, and so on). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.