contact: perfected the +is-allowed arm and fixed issue with share type

pkg/arvo/app/contact-store.hoon

@@ -219,8 +219,12 @@
     ``noun+!>(allowed-groups)
 
   ::
-      [%x %is-allowed @ @ @ ~]
-    =/  =resource  [(slav %p i.t.t.path) i.t.t.t.path]
+      [%x %is-allowed @ @ @ @ ~]
+    =/  is-personal  =(i.t.t.t.t.t.path 'true')
+    =/  =resource
+      ?:  is-personal
+        [our.bowl %'']
+      [(slav %p i.t.t.path) i.t.t.t.path]
     =/  =ship  (slav %p i.t.t.t.t.path)
     ``json+!>(`json`b+(is-allowed:con resource ship))
   ==

pkg/arvo/app/group-view.hoon

@@ -175,6 +175,10 @@
         %share-co
       ?>  ?=(%poke-ack -.sign)
       (ack +.sign)
+    ::
+        %push-co
+      ?>  ?=(%poke-ack -.sign)
+      (ack +.sign)
     ::
         %md
       ?+  -.sign  !!
@@ -200,6 +204,7 @@
       %-  zing
       :~  [(poke-our:(jn-pass-io /pull-md) %metadata-pull-hook cag)]~
           [(poke-our:(jn-pass-io /pull-co) %contact-pull-hook cag)]~
+        ::
           ?.  scry-is-public:con  ~
           :_  ~
           %+  poke:(jn-pass-io /share-co)

pkg/arvo/lib/contact.hoon

@@ -76,14 +76,24 @@
       ::  this is used for direct messages and leap searches
       ::
       ?&  =(rid [our.bowl %''])
-          ?|  scry-is-public
+          ?|  ::  if our profile is public, allow
+              ::
+              scry-is-public
+              ::  if the requester is an allowed-ship, allow
+              ::
               (scry-for ? /allowed-ship/(scot %p ship))
+              ::  if the requester of our profile is the host of one of
+              ::  our allowed-groups, allow
+              ::
+              %+  lien  ~(tap in allowed-groups)
+              |=  res=resource
+              =(entity.res ship)
       ==  ==
-      ::  if they are requesting our profile within a group, make sure we
-      ::  are the host of that group and that they are a member of the group
+      ::  if they are requesting our contact data within a group,
+      ::  we make sure that we are sharing that group,
+      ::  and that they are a member of the group
       ::
-      ?&  (~(has in allowed-groups) rid)
-          (~(has in scry-sharing) rid)
+      ?&  (~(has in scry-sharing) rid)
           (~(has in (members:grp rid)) ship)
-  ==  ==
+  ==  == 
 --

pkg/arvo/mar/contact/share.hoon

@@ -9,7 +9,7 @@
 ::
 ++  grab
   |%
-  ++  noun  share
+  ++  noun  _share
   ++  json  share:share-dejs
   --
 --