ilyakooo0/urbit
1
0
Fork 0
mirror of https://github.com/ilyakooo0/urbit.git synced 2024-12-20 13:22:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5092 from urbit/lf/no-wipe-input

Browse Source 
CommentInput: stop recreating input
This commit is contained in:
matildepark 2021-07-09 14:28:16 -04:00 committed by GitHub
commit 1bf852fe91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/interface/src/views/components/CommentInput.tsx
View File

@ -11,7 +11,7 @@ import {
useField, useField,
useFormikContext useFormikContext
} from 'formik'; } from 'formik';
import React, { useEffect } from 'react'; import React, { useEffect, useMemo } from 'react';
import * as Yup from 'yup'; import * as Yup from 'yup';
import { ShipImage } from './ShipImage'; import { ShipImage } from './ShipImage';
@ -68,9 +68,13 @@ function FormikHelper(props: { initialValues: any }) {
return null; return null;
} }
const emptyStr = '';
export default function CommentInput(props: CommentInputProps) { export default function CommentInput(props: CommentInputProps) {
const initialValues: FormSchema = { comment: props.initial || '' }; const initialValues: FormSchema = useMemo(
() => ({ comment: props.initial || emptyStr }),
[props.initial]);
const label = props.label || 'Comment'; const label = props.label || 'Comment';
return ( return (