ilyakooo0/urbit
1
0
Fork 0
mirror of https://github.com/ilyakooo0/urbit.git synced 2024-12-14 17:41:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

Dropdown: fix event propagation

Browse Source 
Fixes urbit/landscape#427
This commit is contained in:
Liam Fitzgerald 2021-02-16 13:03:51 +10:00
parent 79f461f5c9
commit 3548c984a9
No known key found for this signature in database
GPG Key ID: D390E12C61D1CFFB
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/interface/src/views/components/Dropdown.tsx
View File

@ -66,13 +66,19 @@ export function Dropdown(props: DropdownProps) {
[setOpen, updatePos] [setOpen, updatePos]
); );
useEffect(() => { const close = useCallback(() => {
setOpen(false); setOpen(false);
},[]);
useEffect(() => {
close();
}, [pathname]); }, [pathname]);
useOutsideClick(dropdownRef, () => { useOutsideClick(dropdownRef, close);
setOpen(false);
}); const onOptionsClick = useCallback((e: any) => {
e.stopPropagation();
}, []);
return ( return (
<Box flexShrink={props?.flexShrink ? props.flexShrink : 1} position={open ? "relative" : "static"} minWidth='0' width={props?.width ? props.width : 'auto'}> <Box flexShrink={props?.flexShrink ? props.flexShrink : 1} position={open ? "relative" : "static"} minWidth='0' width={props?.width ? props.width : 'auto'}>
@ -85,6 +91,7 @@ export function Dropdown(props: DropdownProps) {
width={props?.dropWidth || "max-content"} width={props?.dropWidth || "max-content"}
{...coords} {...coords}
ref={dropdownRef} ref={dropdownRef}
onClick={onOptionsClick}
> >
{options} {options}
</DropdownOptions> </DropdownOptions>