ilyakooo0/urbit
1
0
Fork 0
mirror of https://github.com/ilyakooo0/urbit.git synced 2024-12-15 18:12:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

u3: updates u3s_sift_ud() to skip gmp allocation where possible

Browse Source
This commit is contained in:
Joe Bryan 2021-04-21 22:22:04 -07:00
parent 5730958d90
commit 39a3d1f266
1 changed files with 39 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
pkg/urbit/noun/serial.c
View File

@ -864,7 +864,8 @@ u3s_cue_atom(u3_atom a)
u3_weak u3_weak
u3s_sift_ud_bytes(c3_w len_w, c3_y* byt_y) u3s_sift_ud_bytes(c3_w len_w, c3_y* byt_y)
{ {
c3_s val_s; c3_s val_s; // leading digits value
c3_y num_y; // leading digits length
if ( !len_w ) return u3_none; if ( !len_w ) return u3_none;
@ -880,6 +881,7 @@ u3s_sift_ud_bytes(c3_w len_w, c3_y* byt_y)
// //
if ( NOT_DEC(*byt_y) ) return u3_none; if ( NOT_DEC(*byt_y) ) return u3_none;
num_y = 1;
val_s = *byt_y++ - '0'; val_s = *byt_y++ - '0';
if ( 0 == --len_w ) return (u3_noun)val_s; if ( 0 == --len_w ) return (u3_noun)val_s;
@ -888,6 +890,7 @@ u3s_sift_ud_bytes(c3_w len_w, c3_y* byt_y)
if ( '.' == *byt_y ) goto tid_ab; if ( '.' == *byt_y ) goto tid_ab;
if ( NOT_DEC(*byt_y) ) return u3_none; if ( NOT_DEC(*byt_y) ) return u3_none;
num_y = 2;
val_s *= 10; val_s *= 10;
val_s += *byt_y++ - '0'; val_s += *byt_y++ - '0';
if ( 0 == --len_w ) return (u3_noun)val_s; if ( 0 == --len_w ) return (u3_noun)val_s;
@ -897,6 +900,7 @@ u3s_sift_ud_bytes(c3_w len_w, c3_y* byt_y)
if ( '.' == *byt_y ) goto tid_ab; if ( '.' == *byt_y ) goto tid_ab;
if ( NOT_DEC(*byt_y) ) return u3_none; if ( NOT_DEC(*byt_y) ) return u3_none;
num_y = 3;
val_s *= 10; val_s *= 10;
val_s += *byt_y++ - '0'; val_s += *byt_y++ - '0';
if ( 0 == --len_w ) return (u3_noun)val_s; if ( 0 == --len_w ) return (u3_noun)val_s;
@ -906,6 +910,40 @@ tid_ab:
// //
if ( len_w % 4 ) return u3_none; if ( len_w % 4 ) return u3_none;
// avoid gmp allocation if possible
//
// - 19 decimal digits fit in 64 bits
// - 18 digits is 24 bytes with separators
//
if ( ((1 == num_y) && (24 >= len_w))
|| (20 >= len_w) )
{
c3_d val_d = val_s;
while ( len_w ) {
if ( ('.' != byt_y[0])
|| NOT_DEC(byt_y[1])
|| NOT_DEC(byt_y[2])
|| NOT_DEC(byt_y[1]) )
{
return u3_none;
}
byt_y++;
val_d *= 10;
val_d += *byt_y++ - '0';
val_d *= 10;
val_d += *byt_y++ - '0';
val_d *= 10;
val_d += *byt_y++ - '0';
len_w -= 4;
}
return u3i_chub(val_d);
}
{ {
// XX estimate size, allocate once // XX estimate size, allocate once
// //