ilyakooo0/urbit
1
0
Fork 0
mirror of https://github.com/ilyakooo0/urbit.git synced 2024-12-12 15:01:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix a serious change address bug w nixt

Browse Source
This commit is contained in:
timlucmiptev 2020-12-11 15:13:00 +02:00 committed by ixv
parent 56d40880e0
commit 4b2920a1fb
2 changed files with 16 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
DEMO.md
View File

@ -11,47 +11,25 @@ Runs the full node API services.
## Start Agents
On `~zod`
```
|commit %home
|start %btc-provider
|start %btc-wallet-hook
|start %btc-wallet-store
:btc-provider|command [%set-credentials api-url='http://localhost:50002']
:btc-wallet-hook|action [%set-provider ~zod]
```
On `~dopzod`
```
|start %btc-wallet-hook
|start %btc-wallet-store
```
## Connect to Provider from Another Ship
On `~dopzod`
```
:btc-wallet-hook|action [%set-provider ~zod]
```
So we whitelist.
On `~zod`
```
:btc-provider|command [%whitelist-clients `(set ship)`(sy ~[~dopzod])]
```
And try again on `~dopzod`
On `~dopzod`
```
|commit %home
|start %btc-wallet-hook
|start %btc-wallet-store
:btc-wallet-hook|action [%set-provider ~zod]
:btc-wallet-hook +dbug [%state 'provider']
```
## Simulate Loss of Connectivity
* Shut down BTC services
* Observe `~zod` sending "not connected" updates
* dbug on `~dopzod` shows `%.n` for connected
```
:btc-wallet-hook +dbug
```
### Add a Wallet While Disconnected
### Add Wallets
`~dopzod`
XPUB is the "absurd sick..." mnemonic
```
@ -59,13 +37,13 @@ XPUB is the "absurd sick..." mnemonic
=fprint [%4 0xbeef.dead]
:btc-wallet-store|action [%add-wallet xpubp fprint ~ [~ 8] [~ 6]]
```
Lots of `scans` backed up, because we're disconnected.
* start services back up
* provider will keep re-checking, and once connected, we'll observe address updates
* re-run `:btc-wallet-store +dbug`; note that the wallet is `scanned`
Key point: provider connectivity doesn't add mental overhead for the client.
`~zod`
```
=xpubzod 'zpub6rFR7y4Q2AijBEqTUquhVz398htDFrtymD9xYYfG1m4wAcvPhXNfE3EfH1r1ADqtfSdVCToUG868RvUUkgDKf31mGDtKsAYz2oz2AGutZYs'
=fprint [%4 0xbeef.dead]
:btc-wallet-store|action [%add-wallet xpubzod fprint ~ [~ 8] [~ 6]]
```
## Check Balance
`~dopzod`
@ -76,13 +54,6 @@ Key point: provider connectivity doesn't add mental overhead for the client.
## Pay a Ship
`~dopzod` will pay `~zod`. Both are acting as clients here (and use `~zod` as the provider).
`~zod` adds a wallet:
```
=xpubzod 'zpub6rFR7y4Q2AijBEqTUquhVz398htDFrtymD9xYYfG1m4wAcvPhXNfE3EfH1r1ADqtfSdVCToUG868RvUUkgDKf31mGDtKsAYz2oz2AGutZYs'
=fprint [%4 0xbeef.dead]
:btc-wallet-store|action [%add-wallet xpubzod fprint ~ [~ 8] [~ 6]]
```
`~dopzod`
```
:btc-wallet-hook|action [%req-pay-address ~zod 4.000 feyb=[~ 10]]

7
lib/btc-wallet-store.hoon
View File

@ -127,15 +127,16 @@
==
:: +update-address
:: - insert a new address
:: - update "nixt" free address if this one was it
:: - watch the new nixt
:: - if it's used, move "nixt" to the next free address
:: - watch address
::
++ update-address
|= [a=address:btc =addi]
:: TODO: check whether addi is used or not before bumping nixt
^- walt
?> =(chyg chyg.addi)
?> =(a (mk-address idx.addi))
=? w (is-nixt addi)
=? w ?&(used.addi (is-nixt addi))
bump-nixt
w(wach (~(put by wach.w) a addi))
::