chat-view: allow %groupify into existing group

Will add the chat to an existing group, optionally adding chat members
who aren't part of the group yet to the group.

pkg/arvo/app/chat-view.hoon

@@ -248,6 +248,8 @@
   ::
       %groupify
     ?>  ?=([%'~' ^] app-path.act)
+    ::  retrieve old data
+    ::
     =/  data=(unit mailbox)
       (scry-for (unit mailbox) %chat-store [%mailbox app-path.act])
     ?~  data
@@ -265,26 +267,52 @@
       =/  encoded-path=@ta
         (scot %t (spat app-path.act))
       /metadata/[encoded-path]/chat/[encoded-path]
-    =/  new-path=^path  (slag 1 `path`app-path.act)
-    =/  members=(set ship)
-      %+  fall
-        (group-scry app-path.act)
-      *(set ship)
-    =/  cards-1=(list card)
-        (poke-chat-view-action %delete app-path.act)
-    =/  cards-2=(list card)
+    ::  figure out new data
+    ::
+    =/  chat-path=^path      (slag 1 `path`app-path.act)
+    ::  group-path: the group to associate with the chat
+    ::  members: members of group, if it's new
+    ::  new-members: new members of group, if it already exists
+    ::
+    =/  [group-path=path members=(set ship) new-members=(set ship)]
+      ?~  existing.act
+        [chat-path who.u.permission ~]
+      :+  group-path.u.existing.act
+        ~
+      ?.  inclusive.u.existing.act  ~
+      %-  ~(dif in who.u.permission)
+      ~|  [%groupifying-with-nonexistent-group group-path.u.existing.act]
+      %-  need
+      (group-scry group-path.u.existing.act)
+    ::  make changes
+    ::
+    ;:  weld
+      ::  delete the old chat
+      ::
+      (poke-chat-view-action %delete app-path.act)
+    ::
+      ::  create the new chat. if needed, creates the new group.
+      ::
       %-  poke-chat-view-action
       :*  %create
           title.metadata
           description.metadata
-          new-path
-          new-path
+          chat-path
+          group-path
           %village
           members
           &
       ==
-    %+  snoc  (weld cards-1 cards-2)
-    (chat-poke %messages new-path envelopes.u.data)
+    ::
+      ::  if needed, add members to the existing group
+      ::
+      ?~  new-members  ~
+      [(group-poke [%add new-members group-path])]~
+    ::
+      ::  import messages into the new chat
+      ::
+      [(chat-poke %messages chat-path envelopes.u.data)]~
+    ==
   ==
   ::
   ++  create-chat

pkg/arvo/lib/chat-json.hoon

@@ -283,7 +283,8 @@
     ==
   ::
   ++  groupify
-    (ot [%app-path pa] ~)
+    =-  (ot [%app-path pa] [%existing -] ~)
+    (mu (ot [%group-path pa] [%inclusive bo] ~))
   ::
   ++  sec
     =,  dejs:format

pkg/arvo/sur/chat-view.hoon

@@ -25,6 +25,10 @@
       ::    and invite the current whitelist to that group.
       ::    existing messages get moved over.
       ::
-      [%groupify app-path=path]
+      ::    if :existing is provided, associates chat with that group instead
+      ::    of creating a new one. :inclusive indicates whether or not to add
+      ::    chat members to the group, if they aren't there already.
+      ::
+      [%groupify app-path=path existing=(unit [group-path=path inclusive=?])]
   ==
 --