ilyakooo0/urbit
1
0
Fork 0
mirror of https://github.com/ilyakooo0/urbit.git synced 2024-08-15 13:40:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

contributing: add notes on describing contributions [ci skip]

Browse Source 
Adds a couple of blurbs on how to describe contributions to the git
practice 'contributing' section.
This commit is contained in:
Jared Tobin 2019-10-06 18:57:47 +04:00
parent 18f55bb5f8
commit 64a20fd700
No known key found for this signature in database
GPG Key ID: 0E4647D58F8A69E4
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
CONTRIBUTING.md
View File

@ -51,6 +51,19 @@ email them to maintainers, or request a maintainer pull from your tree directly
-- but note that some maintainers will be more receptive to these methods than
others.
When contributing changes, via whatever means, make sure you describe them
appropriately. You should attach a reasonably high-level summary of what the
changes are and what they do; reference any useful background material that may
exist, e.g. a GitHub issue, a mailing list discussion, a UP, etc. [Here][jbpr]
is a good example of a pull request with a useful, concise description.
If your changes replace significant extant functionality, be sure to compare
them with the thing you're replacing. You may also want to cc maintainers,
reviewers, or other parties who might have a particular interest in what you're
contributing.
[jbpr]: https://github.com/urbit/urbit/pull/1782
### Hygiene
Commits should generally be relevant, atomic, and have descriptions formatted