Merge pull request #4432 from urbit/la/fix-363

interface: profiles would intermittently show contact information when they should not, fixes this

pkg/interface/src/logic/reducers/contact-update.ts

@@ -59,18 +59,16 @@ const edit = (json: ContactUpdate, state: S) => {
     if (!field) {
       return;
     }
-    const contact = state.contacts?.[ship];
+
     const value = data['edit-field'][field];
-    if(!contact) {
-      return; 
-    }
     
     if(field === 'add-group') {
-      contact.groups.push(value);
+      state.contacts[ship].groups.push(value);
     } else if (field === 'remove-group') {
-      contact.groups = contact.groups.filter(g => g !== value);
+      state.contacts[ship].groups =
+        state.contacts[ship].groups.filter(g => g !== value);
     } else {
-      contact[field] = value;
+      state.contacts[ship][field] = value;
     }
   }
 };

pkg/interface/src/views/apps/chat/ChatResource.tsx

@@ -80,49 +80,52 @@ export function ChatResource(props: ChatResourceProps) {
   }, [station]);
 
   const [showBanner, setShowBanner] = useState(false);
+  const [hasLoadedAllowed, setHasLoadedAllowed] = useState(false);
   const [recipients, setRecipients] = useState([]);
 
   const res = resourceFromPath(groupPath);
 
   useEffect(() => {
     (async () => {
-    if (!res) { return; }
+      if (!res) { return; }
-    if (!group) { return; }
+      if (!group) { return; }
-    if (group.hidden) {
+      if (group.hidden) {
-      const members = _.compact(await Promise.all(
+        const members = _.compact(await Promise.all(
-        Array.from(group.members)
+          Array.from(group.members)
-          .map(s => {
+            .map(s => {
-            const ship = `~${s}`;
+              const ship = `~${s}`;
-            if(s === window.ship) {
+              if(s === window.ship) {
-              return Promise.resolve(null);
+                return Promise.resolve(null);
-            }
+              }
-            return props.api.contacts.fetchIsAllowed(
+              return props.api.contacts.fetchIsAllowed(
-              `~${window.ship}`,
+                `~${window.ship}`,
-              'personal',
+                'personal',
-              ship,
+                ship,
-              true
+                true
-            ).then(isAllowed => {
+              ).then(isAllowed => {
-              return isAllowed ? null : ship;
+                return isAllowed ? null : ship;
-            });
+              });
-          })
+            })
-      ));
+        ));
+
+        if(members.length > 0) {
+          setShowBanner(true);
+          setRecipients(members);
+        } else {
+          setShowBanner(false);
+        }
 
-      if(members.length > 0) {
-        setShowBanner(true);
-        setRecipients(members);
       } else {
-        setShowBanner(false);
+        const groupShared = await props.api.contacts.fetchIsAllowed(
+          `~${window.ship}`,
+          'personal',
+          res.ship,
+          true
+        );
+        setShowBanner(!groupShared);
       }
 
-    } else {
+      setHasLoadedAllowed(true);
-      const groupShared = await props.api.contacts.fetchIsAllowed(
-        `~${window.ship}`,
-        'personal',
-        res.ship,
-        true
-      );
-      setShowBanner(!groupShared);
-    }
     })();
 
   }, [groupPath]);
@@ -151,7 +154,10 @@ export function ChatResource(props: ChatResourceProps) {
         history={props.history}
         graph={graph}
         unreadCount={unreadCount}
-        contacts={!showBanner ? contacts : modifiedContacts}
+        contacts={
+          (!showBanner && hasLoadedAllowed) ?
+          contacts : modifiedContacts
+        }
         association={props.association}
         associations={props.associations}
         groups={props.groups}
@@ -166,9 +172,13 @@ export function ChatResource(props: ChatResourceProps) {
         ref={chatInput}
         api={props.api}
         station={station}
-        ourContact={!showBanner ? ourContact : null}
+        ourContact={
+          (!showBanner && hasLoadedAllowed) ? ourContact : null
+        }
         envelopes={[]}
-        contacts={contacts}
+        contacts={
+          (!showBanner && hasLoadedAllowed) ? contacts : modifiedContacts
+        }
         onUnmount={appendUnsent}
         s3={props.s3}
         placeholder="Message..."