Merge pull request #1054 from urbit/dude-remove-trap

Remove trap from %dude in ford

lib/test/ford.hoon

@@ -105,7 +105,7 @@
       [%leaf "expected %dude, but got {<-.actual>}"]~
     ::
     %+  weld
-      (expect-eq !>((error.expected)) !>((error.actual)))
+      (expect-eq !>(error.expected) !>(error.actual))
     $(expected attempt.expected, actual attempt.actual)
   ::
       %hood

sys/vane/clay.hoon

@@ -1770,7 +1770,7 @@
     |=  [disc=disc:ford a=page]
     ^-  schematic:ford
     ?.  ?=($hoon p.a)  [%vale [our %home] a]
-    ?.  ?=(@t q.a)  [%dude |.(>%weird-hoon<) %ride [%zpzp ~] %$ *cage]
+    ?.  ?=(@t q.a)  [%dude >%weird-hoon< %ride [%zpzp ~] %$ *cage]
     [%$ p.a [%atom %t ~] q.a]
   ::
   ::  Verify the foreign data is of the the mark it claims to be.

sys/vane/eyre.hoon

@@ -1160,7 +1160,7 @@
     |=  [tea=whir live=? request=schematic:ford]
     %+  pass-note  tea
     :*  %f  %build  live
-        [%dude |.([%leaf "eyre: execute {<tea>}"]) request]
+        [%dude [%leaf "eyre: execute {<tea>}"] request]
     ==
   ::
   ++  add-links                                           :: x-urbit:// urls
@@ -2075,7 +2075,6 @@
     ++  has-arm  ~(has in (silt (sloe cor-type)))
     ++  build
       %^  execute-turbo  %core  live=%.y
-      :::+  %dude  [|.(+)]:>%mod-samp<
       ^-  schematic:ford
       :+  %mute
         ^-  schematic:ford

sys/vane/ford.hoon

@@ -3131,7 +3131,7 @@
     ::
     ++  make-dude
       ~%  %make-dude  ..^^$  ~
-      |=  [error=(trap tank) attempt=schematic]
+      |=  [error=tank attempt=schematic]
       ^-  build-receipt
       ::
       =/  attempt-build=^build  [date.build attempt]
@@ -3143,7 +3143,7 @@
       ?.  ?=([%error *] u.attempt-result)
         (return-result u.attempt-result)
       ::
-      (return-error [$:error message.u.attempt-result])
+      (return-error [error message.u.attempt-result])
     ::
     ++  make-hood
       ~%  %make-hood  ..^^$  ~

sys/zuse.hoon

@@ -1214,7 +1214,7 @@
         $:  %dude
             ::  error: a trap producing an error message to wrap the original
             ::
-            error=(trap tank)
+            error=tank
             ::  attempt: the schematic to try, whose error we wrap, if any
             ::
             attempt=schematic

tests/sys/vane/ford.hoon

@@ -1980,7 +1980,7 @@
 ++  test-dude  ^-  tang
   ::
   =/  schematic=schematic:ford-gate
-    :*  %dude  |.(>%test-no-error<)
+    :*  %dude  >%test-no-error<
         [%scry [%c care=%x bel=[[~nul %desk] /bar/foo]]]
     ==
   ::
@@ -2007,7 +2007,7 @@
 ++  test-dude-error  ^-  tang
   ::
   =/  schematic=schematic:ford-gate
-    :*  %dude  |.(>%in-the-error-message<)
+    :*  %dude  >%in-the-error-message<
         [%scry [%c care=%x bel=[[~nul %desk] /bar/foo]]]
     ==
   ::