From b69bb7d7a123e7caaaf704ee9b7b3c203e2d58e0 Mon Sep 17 00:00:00 2001
From: Logan Allen <loganallc@gmail.com>
Date: Fri, 15 Nov 2019 12:27:35 -0800
Subject: [PATCH] chat-store: factored out functions used in both message and
 messages

---
 pkg/arvo/app/chat-store.hoon | 57 ++++++++++++++++++++----------------
 1 file changed, 31 insertions(+), 26 deletions(-)

diff --git a/pkg/arvo/app/chat-store.hoon b/pkg/arvo/app/chat-store.hoon
index 57fd84892..3019cb5ed 100644
--- a/pkg/arvo/app/chat-store.hoon
+++ b/pkg/arvo/app/chat-store.hoon
@@ -188,14 +188,8 @@
   =/  mailbox=(unit mailbox)  (~(get by inbox) path.act)
   ?~  mailbox
     [~ this]
-  =*  letter  letter.envelope.act
-  =?  letter  &(?=(%code -.letter) ?=(~ output.letter))
-    =/  =hoon  (ream expression.letter)
-    letter(output (eval bol hoon))
-  =:  length.config.u.mailbox  +(length.config.u.mailbox)
-      number.envelope.act  +(length.config.u.mailbox)
-      envelopes.u.mailbox  (snoc envelopes.u.mailbox envelope.act)
-  ==
+  =.  letter.envelope.act  (evaluate-letter letter.envelope.act)
+  =.  u.mailbox  (append-envelope u.mailbox envelope.act)
   :-  (send-diff path.act act)
   this(inbox (~(put by inbox) path.act u.mailbox))
 ::
@@ -206,26 +200,20 @@
   =/  mailbox=(unit mailbox)  (~(get by inbox) path.act)
   ?~  mailbox
     [~ this]
-  =/  diff=chat-update
-    :*  %messages
-        path.act
-        +(length.config.u.mailbox)
-        (add length.config.u.mailbox (lent envelopes.act))
-        envelopes.act
-    ==
+  =/  evaluated-envelopes=(list envelope)  ~
   |-  ^-  (quip move _this)
   ?~  envelopes.act
-    [(send-diff path.act diff) this]
-  =*  envelope       i.envelopes.act
-  =*  letter         letter.envelope
-  =?  letter  &(?=(%code -.letter) ?=(~ output.letter))
-    =/  =hoon  (ream expression.letter)
-    letter(output (eval bol hoon))
-  =:  length.config.u.mailbox  +(length.config.u.mailbox)
-      number.envelope  +(length.config.u.mailbox)
-      envelopes.u.mailbox  (snoc envelopes.u.mailbox envelope)
-  ==
-  =.  inbox  (~(put by inbox) path.act u.mailbox)
+    :_  this(inbox (~(put by inbox) path.act u.mailbox))
+    %+  send-diff  path.act
+    :*  %messages
+        path.act
+        (sub length.config.u.mailbox (lent evaluated-envelopes))
+        length.config.u.mailbox 
+        evaluated-envelopes
+    ==
+  =.  letter.i.envelopes.act  (evaluate-letter letter.i.envelopes.act)
+  =.  evaluated-envelopes  (snoc evaluated-envelopes i.envelopes.act)
+  =.  u.mailbox  (append-envelope u.mailbox i.envelopes.act)
   $(envelopes.act t.envelopes.act)
 ::
 ++  handle-read
@@ -239,6 +227,23 @@
   :-  (send-diff path.act act)
   this(inbox (~(put by inbox) path.act u.mailbox))
 ::
+++  evaluate-letter
+  |=  =letter
+  ^-  ^letter
+  =?  letter  &(?=(%code -.letter) ?=(~ output.letter))
+    =/  =hoon  (ream expression.letter)
+    letter(output (eval bol hoon))
+  letter
+::
+++  append-envelope
+  |=  [=mailbox =envelope]
+  ^-  ^mailbox
+  =.  number.envelope  +(length.config.mailbox)
+  =:  length.config.mailbox  +(length.config.mailbox)
+      envelopes.mailbox  (snoc envelopes.mailbox envelope)
+  ==
+  mailbox
+::
 ++  update-subscribers
   |=  [pax=path upd=chat-update]
   ^-  (list move)