Merge branch 'la/mitigate-notification-madness' (#4137)

* origin/la/mitigate-notification-madness:
  graph-store: no need to iterate through whole list if we find a single duplicate
  graph-store: address ted and mark's comments
  graph-store: no-op if we already have *any* of the indexes in an %add-nodes event

Signed-off-by: Matilde Park <matilde.park@gmail.com>

pkg/arvo/app/graph-store.hoon

@@ -297,6 +297,8 @@
       |^
       =/  [=graph:store mark=(unit mark:store)]
         (~(got by graphs) resource)
+      ~|  "cannot add duplicate nodes to {<resource>}"
+      ?<  (check-for-duplicates graph ~(key by nodes))
       =/  =update-log:store  (~(got by update-logs) resource)
       =.  update-log
         (put:orm-log update-log time [%0 time [%add-nodes resource nodes]])
@@ -311,6 +313,31 @@
         (add-node-list resource graph mark (sort-nodes nodes))
       ==
       ::
+      ++  check-for-duplicates
+        |=  [=graph:store nodes=(set index:store)]
+        ^-  ?
+        =/  node-list  ~(tap in nodes)
+        |-
+        ?~  node-list  %.n
+        ?:  (has-node graph i.node-list)  %.y
+        $(node-list t.node-list)
+      ::
+      ++  has-node
+        |=  [=graph:store =index:store]
+        ^-  ?
+        =/  node=(unit node:store)  ~
+        |-
+        ?~  index
+          ?=(^ node)
+        ?~  t.index
+          ?=(^ (get:orm graph i.index))
+        =.  node  (get:orm graph i.index)
+        ?~  node  %.n
+        ?-  -.children.u.node
+            %empty  %.n
+            %graph  $(graph p.children.u.node, index t.index)
+        ==
+      ::
       ++  sort-nodes
         |=  nodes=(map index:store node:store)
         ^-  (list [index:store node:store])