From f77522755dc20bd1392e9bf160f2b0bf3edc9caa Mon Sep 17 00:00:00 2001
From: Liam Fitzgerald <liam@urizen.co>
Date: Fri, 25 Sep 2020 16:21:29 +1000
Subject: [PATCH] metadata-store: rebuild indices

The OTA deployment of urbit-os-v1.0.50 unintentionally wiped the indices
during the state migration. This caused widespread permissions issues,
as agents were unable to tell which group is associated with what channel.
Fortunately, the indices are a simple transform of the associations noun,
which was kept intact. This commit introduces a state migration to rebuild
the indices, in order to restore connectivity on the network.
---
 pkg/arvo/app/metadata-store.hoon | 54 ++++++++++++++++++++++++++++++--
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/pkg/arvo/app/metadata-store.hoon b/pkg/arvo/app/metadata-store.hoon
index 3421a3622..af0ffe2e7 100644
--- a/pkg/arvo/app/metadata-store.hoon
+++ b/pkg/arvo/app/metadata-store.hoon
@@ -55,15 +55,17 @@
 +$  state-1   [%1 base-state-0]
 +$  state-2   [%2 base-state-0]
 +$  state-3   [%3 base-state-1]
++$  state-4   [%4 base-state-1]
 +$  versioned-state
   $%  state-0
       state-1
       state-2
       state-3
+      state-4
   ==
 --
 ::
-=|  state-3
+=|  state-4
 =*  state  -
 %+  verb  |
 %-  agent:dbug
@@ -82,8 +84,21 @@
     =/  old  !<(versioned-state vase)
     =|  cards=(list card)
     |^
-    ?:  ?=(%3 -.old)
+    ?:  ?=(%4 -.old)
       [cards this(state old)]
+    ?:  ?=(%3 -.old)
+      %_    $
+        -.old  %4
+        ::
+          resource-indices.old
+        (rebuild-resource-indices associations.old)
+        ::
+          app-indices.old
+        (rebuild-app-indices associations.old)
+        ::
+          group-indices.old
+        (rebuild-group-indices associations.old)
+      ==
     ?:  ?=(%2 -.old)
       =/  new-state=state-3
         %*  .  *state-3
@@ -119,6 +134,41 @@
       ==
     $(old new-state-1)
     ::
+    ++  rebuild-app-indices
+      =|  app-indices=(jug app-name [group-path app-path])
+      |=  =^associations
+      ^-  (jug app-name [group-path app-path])
+      ?~  associations  app-indices
+      =.  app-indices
+        %+  ~(put ju app-indices)  app-name.p.n.associations
+        [-.p.n.associations app-path.p.n.associations]
+      %-  ~(uni by $(associations l.associations))
+      $(associations r.associations)
+    ::
+    ++  rebuild-group-indices
+      =|  group-indices=(jug group-path md-resource)
+      |=  =^associations
+      ^-  (jug group-path md-resource)
+      ?~  associations  group-indices
+      =.  group-indices
+        %+  ~(put ju group-indices)  
+          -.p.n.associations 
+        +.p.n.associations
+      %-  ~(uni by $(associations l.associations))
+      $(associations r.associations)
+    ::
+    ++  rebuild-resource-indices
+      =|  resource-indices=(jug md-resource group-path)
+      |=  =^associations
+      ^-  (jug md-resource group-path)
+      ?~  associations  resource-indices
+      =.  resource-indices
+        %+  ~(put ju resource-indices)  
+          +.p.n.associations
+        -.p.n.associations
+      %-  ~(uni by $(associations l.associations)) 
+      $(associations r.associations)
+    ::
     ++  poke-md-hook
       |=  act=metadata-hook-action
       ^-  card