Commit Graph

1979 Commits

Author SHA1 Message Date
Fang
ecf9dacbc0
link fe: factor out "page"+i indexing, use plain numbers 2020-02-06 17:31:13 +01:00
Fang
2b4667eb86
link fe: fix page loading behavior
Previously, receiving new items could "locally create" pages,
half-filled with whatever items were pushed down into them. Frontend
would see the existence of the page and assume all was well. However,
the page may have contained more items (on the backend) than just what
we pushed down.

This adds a per-page flag, "local", to indicate such pages. When display
logic sees it's set, it will send a request for the full page,
regardless of currently available data, loading in the canonical full
page as a result.
2020-02-06 17:23:32 +01:00
Fang
438d502c89
link fe: remove unused comment loading logic
This never triggers anymore, comments loading always happens in onMount.
2020-02-06 17:06:05 +01:00
Fang
375755f106
link fe: ensure state is initialized where used 2020-02-06 16:56:04 +01:00
Fang
9b9692e7f1
link fe: fully account for the "number as string" case
The Number() usage is sane, but should be scoped around the variable by
itself. Previously a string of "3" would lead to a Number("31") call,
which is not the intended behavior here.

Also stops passing a {} in if the actual number is unknown.
2020-02-06 16:55:32 +01:00
Fang
e74ec92c4c
link fe: more correct totals updating logic 2020-02-06 16:52:40 +01:00
Fang
50695fe78a
link fe: use correct time attribute 2020-02-06 15:32:14 +01:00
Fang
182d2c3a07
link fe: refactor link-view subscriptions api 2020-02-06 15:25:07 +01:00
Fang
4222ebbfb3
link fe: always render up-to-date comment counts 2020-02-06 15:04:47 +01:00
Fang
ab21f67ba6
link: support loading individual submissions
On the frontend, updates the route path to include the (base64-encoded)
url. Uses that and the load-single functionality to support loading
directly into a submission page, which fetches just the requested
submission.

Also ensures we don't open duplicate comment subscriptions.
2020-02-06 14:50:39 +01:00
Matilde Park
052fbc34de launch: rebuilt all apps, add mobile flexbox 2020-02-05 23:34:17 -05:00
Matilde Park
4281077dcc Merge branch 'os1-rc' into mp/os1/launch 2020-02-05 23:06:28 -05:00
Gavin Atkinson
c93d026a70 get geolocation from weather app, revise clock appearance to match new
launch page
2020-02-05 18:08:22 -08:00
Matilde Park
6b06367cc4 publish: sidebar defensive checks and style fixes 2020-02-05 20:53:17 -05:00
Anthony Arroyo
bce40c2d52
Merge pull request #2234 from urbit/mp/os1/chat-filter-empty-groups
chat: filter empty groups from peer search
2020-02-05 17:42:57 -08:00
A Arroyo
e2c053766a update new chat validation 2020-02-05 17:35:19 -08:00
A Arroyo
dc673e4bb4 Merge branch 'os1-rc' into contacts-group-validate 2020-02-05 17:31:45 -08:00
A Arroyo
671d3ad7e8 Joe gripes 2020-02-05 17:23:40 -08:00
A Arroyo
260ad31468 validate to @tas insted of @tas 2020-02-05 17:12:50 -08:00
Jimmy
e045177031 give some small padding on image to make it vertical spacing more even 2020-02-05 15:47:54 -08:00
Jimmy
d97951b499 add pointer hover state 2020-02-05 15:41:51 -08:00
Jimmy
980b3be8bb markdown spacing 2020-02-05 15:35:20 -08:00
Matilde Park
21f6be96a1 launch, various: new tiles and launch (but clock) 2020-02-05 18:16:56 -05:00
matildepark
9727fab259
Merge pull request #2233 from urbit/m/uplink-os1
link: subscriptions for the frontend
2020-02-05 15:30:53 -05:00
Matilde Park
ae007f7b96 links-fe: rebuild link.js 2020-02-05 15:30:34 -05:00
Fang
3bbff696b5
link frontend: fix loading into submission page 2020-02-05 21:17:47 +01:00
Fang
469f7e04d1
link-view: launch tile on-boot
Also fills out the eyre %connect wire for clarity.
2020-02-05 20:48:48 +01:00
Matilde Park
bb7061b591 chat: filter empty groups from peer search 2020-02-05 13:52:01 -05:00
Fang
37c943d34d
link-view: serve png files 2020-02-05 18:43:28 +01:00
Fang
26116ee990
link-view: handle eyre bind acks 2020-02-05 18:43:27 +01:00
Fang
83ed16fcb7
link: remove /app/link-server-hook
Use link-view instead.
2020-02-05 18:43:27 +01:00
Fang
e26d2537c7
link: remove trailing whitespace 2020-02-05 18:43:27 +01:00
Fang
4e4f005689
link: update frontend ui logic to match api changes
Updates the frontend display & data fetching logic to match the changes
made in e7eef19d7.
2020-02-05 18:43:20 +01:00
Fang
31b6333ef9
link: update frontend api & reducer functions for link-view
Replaces .json requests with channel.js subscriptions. Rewrites reducers
to match, now being more careful about paginated data, and storing
comments in their own structure, at [group][url] indices, rather than
the non-static [page][index] ones used previously.

Note that this requires some changes to the frontend UI code also.
See next commit.
2020-02-05 18:20:50 +01:00
Fang
717e2310be
eyre: remove potentially noisy printf
It's perfectly sane for gall (apps) to send quits to subscriptions
incoming from the web.
2020-02-05 18:20:43 +01:00
Fang
bda077862e
link: prepare marks
Also renames an object attribute to closer match the hoon code.
2020-02-05 17:46:47 +01:00
Fang
e3a4de4d31
link: encode urls in paths using +wood (vs base64)
Base64 encoding isn't actually @ta-safe, since it contains capitals and
=. +wood escapes all such characters explicitly. The result is more
readable and more hoon-native paths, but does mean clients will have to
re-implement +wood locally.
2020-02-05 17:39:08 +01:00
Fang
23db1d3be1
link: implement link-view 2020-02-05 17:35:24 +01:00
Matilde Park
bc4dd57896 publish: sortable sidebar 2020-02-04 21:14:44 -05:00
A Arroyo
8c82f1bbff validate group names 2020-02-04 17:30:22 -08:00
Logan Allen
a7f9e98f85 js: rebuilt chat and contacts 2020-02-04 15:36:49 -08:00
Logan Allen
b51ae958ec chat: fix issues with [ship path] to path change and support contacts 2020-02-04 15:31:06 -08:00
Logan Allen
543420b68e chat: cleanup to change api to accept path instead of ship, path 2020-02-04 15:30:02 -08:00
A Arroyo
ff4db6786d change fe to create full group path 2020-02-04 15:28:44 -08:00
A Arroyo
6fb731b5c1 remove ship-based path building 2020-02-04 15:28:44 -08:00
A Arroyo
c8f72996b4 only create group if doesn't exist 2020-02-04 15:28:44 -08:00
A Arroyo
5c8a53dcaa remove /read and /write dual group usage 2020-02-04 15:28:44 -08:00
Anthony Arroyo
a59e0a9ec7 remove chat prepending from groups 2020-02-04 15:28:44 -08:00
Logan
f4b3dc501f
Merge pull request #2226 from urbit/mp/os1/chat-create-new
chat: add create group toggle to new.js
2020-02-04 15:18:11 -08:00
A Arroyo
737887bb8f removed image upload button 2020-02-04 15:14:17 -08:00
A Arroyo
edab2a5d26 Revert "removed image upload button"
Accidentally pushed to os1-rc, mea culpa

This reverts commit 4e578ae788.
2020-02-04 15:13:14 -08:00
A Arroyo
4e578ae788 removed image upload button 2020-02-04 15:11:23 -08:00
ixv
05480fa2e5
Merge pull request #2227 from urbit/ixv/publish-group-paths
publish group paths
2020-02-04 13:50:25 -08:00
Isaac Visintainer
63bea15f58 fixed wrong name for ship 2020-02-04 12:59:49 -08:00
Fang
4a337fa633
link: update subscription model
Better subscription path API support. Should support us better moving
forward.

Note that this kills the server-hook. It will be replaced with a
link-view shortly.
2020-02-04 21:35:33 +01:00
Fang
4951d6ba45
link: support higher-level paths for broader subscriptions
Also re-orders the comment paths to have URL first, which is easier to
handle and also seems more correct wrt the behavior you might want in
the web extension and similar use cases.
2020-02-04 20:35:10 +01:00
Isaac Visintainer
9b260e081d change publish api to pass though group paths from frontend 2020-02-04 11:14:06 -08:00
Matilde Park
df30a777a8 chat: add create group toggle to new.js 2020-02-04 14:06:54 -05:00
Anthony Arroyo
2733e10311
Merge pull request #2223 from urbit/publish-join-screen
basic join screen
2020-02-04 10:16:23 -08:00
A Arroyo
af1573725f don't allow spurious newline in input 2020-02-04 10:15:22 -08:00
A Arroyo
670563d1a0 include notebooks in sidebar 2020-02-03 17:28:13 -08:00
A Arroyo
5912ba0c0c improve validation 2020-02-03 17:27:53 -08:00
Logan
41d5b28195
Merge pull request #2224 from urbit/mp/os1/links-new-comment-bug
links: fix comments reducer to post new comment locally
2020-02-03 16:58:17 -08:00
Logan
90d6fa4727
Merge pull request #2225 from urbit/ga/clock
Ga/clock
2020-02-03 16:55:53 -08:00
Gavin Atkinson
f648f57605 cleanup 2020-02-03 16:48:54 -08:00
Gavin Atkinson
728ef7fc16 clock 2020-02-03 16:48:54 -08:00
Logan
a90fc46fb1
Merge branch 'os1-rc' into mp/os1/chat-new-component 2020-02-03 16:44:40 -08:00
Matilde Park
fb9c775649 links: amend reducer to add new comments locally 2020-02-03 17:52:39 -05:00
Matilde Park
a158e1c651 chat: refactor invite search component functions 2020-02-03 17:24:42 -05:00
A Arroyo
e3af0bcde9 basic join screen 2020-02-03 13:11:49 -08:00
Isaac Visintainer
fd300aa025 made fetching more robust on notebook page
added infinite scroll and fetching to note page
2020-02-01 12:54:37 -08:00
Isaac Visintainer
919db6a3be pass snippet and about field from backend
wire up routing for notebook page
add infinite scroll and note fetching logic to notebook page
2020-01-31 15:04:24 -08:00
Jimmy
fe44b25f92 about and settings page 2020-01-31 15:04:24 -08:00
Jimmy
5b1999347a subscribers style 2020-01-31 15:04:24 -08:00
Jimmy
a345395951 notebook-item styling on notebook-list 2020-01-31 15:04:24 -08:00
Isaac Visintainer
06cdbb68b9 initial work on posts page 2020-01-31 15:04:10 -08:00
ixv
3a1a23e3d8
Merge pull request #2202 from urbit/post-view
Publish Post View
2020-01-31 14:38:41 -08:00
Logan
b9ebb97ad1
Merge pull request #2216 from urbit/mp/os1/contacts-chrome
contacts: add os1 chrome
2020-01-31 13:23:32 -08:00
Matilde Park
761d71cfee chat: add group and peer search, new.js rework 2020-01-31 01:34:53 -05:00
Matilde Park
be448ec54c contacts: add os1 chrome 2020-01-30 20:13:07 -05:00
Logan Allen
61709260a8 chat-js: added contacts metadata to chat 2020-01-30 13:37:52 -08:00
Jimmy
2be41fc3fe url and note nav logic 2020-01-29 17:35:35 -08:00
Logan
a9434743a0
Merge pull request #2201 from urbit/mp/os1/soto-chrome
soto: os1 updates
2020-01-29 16:50:33 -08:00
Logan
c23146dd14
Merge pull request #2210 from urbit/contact-delete-os1
Contact delete os1
2020-01-29 16:49:22 -08:00
Matilde Park
9a67d24d11 soto: style fix
Refactoring long class string.
2020-01-29 19:48:58 -05:00
Logan Allen
1279019cdd contacts: delete groups/contacts properly and mirror to foreign 2020-01-29 16:48:58 -08:00
Logan
8055ff5472
Merge pull request #2205 from urbit/mp/os1/chat-chrome
chat: os1 chrome and styling updates
2020-01-29 16:46:11 -08:00
Matilde Park
15bc1da3ba chat: style fix -- collapse ternary operators 2020-01-29 19:34:37 -05:00
Jimmy
4521ba0895 adding comment functionality and post date,author,and title 2020-01-29 16:31:31 -08:00
Jimmy
9e7ff7d68d moving comment box into comments.js and user comment into comment-item.js 2020-01-29 16:30:47 -08:00
Jimmy
f2c839986a adding comments 2020-01-29 16:30:47 -08:00
Jimmy
a6d7550f1b fixed overflow in skeleton.js 2020-01-29 16:30:47 -08:00
Jimmy
3f67d4f0a7 add comment box 2020-01-29 16:30:47 -08:00
Jimmy
65b65d75f3 basic style and layout of post view, missing comments 2020-01-29 16:30:47 -08:00
Jimmy
70fcbf9e70 creating scaffold of post view 2020-01-29 16:30:46 -08:00
Fang
a26ec1db12
Merge pull request #2209 from urbit/m/link-bugfix
link: listening & comments
2020-01-30 00:51:22 +01:00
Logan Allen
4c5ecb51bd contact: remove extraneous ~& 2020-01-29 15:09:24 -08:00
Fang
4693af478a
link-store: add :link-store|note
For writing a comment on a url under a path.
2020-01-29 21:12:13 +01:00
Fang
8723dc61ae
link-listen-hook: if subscription rejected, retry
Group definitions are not guaranteed to be instantly in sync between
ships, so our subscription may get rejected if we open it "prematurely".
This adds retry logic with exponential backoff to account for that case.
2020-01-29 20:59:32 +01:00
Fang
63c4764dc9
link-listen-hook: actually sync comments 2020-01-29 20:56:22 +01:00