Philip Monk
c50c34d8be
ames: dedup new messages and fragments
2020-05-01 22:55:14 -07:00
Liam Fitzgerald
774f7f53f0
contacts-js: handle remove of contact correctly
...
the remove functionality in contact-card.js incorrectly assumed that we
are always removing ourselves from the group.
Fixes #2816
2020-05-02 14:08:24 +10:00
Logan Allen
c8e972aa4e
chat-js: updated codeeval.png, margin, and size of icons
2020-05-01 19:08:36 -04:00
Liam Fitzgerald
1faf35928c
chat: fix indenting
2020-05-01 14:11:49 +10:00
ixv
b383037a8f
Merge pull request #2830 from urbit/king-https-fix
...
Get HTTPS working in King Haskell.
2020-04-30 13:08:13 -07:00
ixv
51876044f9
Merge pull request #2820 from urbit/king-crud-type
...
king: don't parse crud events, just treat them as nouns.
2020-04-30 13:07:54 -07:00
Benjamin Summers
f66405615f
king: Split cert from urbit into cert+chain before giving to warp (HTTP Server library).
2020-04-30 12:13:14 -07:00
Benjamin Summers
75f60504ee
king: In http-server/set-config effect, key+cert is Wain, not Cord.
2020-04-30 11:18:23 -07:00
Liam Fitzgerald
c62140e4d6
chat: use ^? on libs correctly
2020-04-30 13:29:06 +10:00
Liam Fitzgerald
1167699ae6
chat-js: refactor unread message fetch
2020-04-30 13:08:38 +10:00
Liam Fitzgerald
bdec28c541
chat-js: load all unreads and autoread on activity
...
if the number of unread messages is larger that the number we are going
to load, then load enough messages to display the unread marker.
Additionally, only automatically read a message if the user has been
active in the last minute. Freeze scroll position on inactivity. Also
unconditionally scroll to the bottom upon sending your own message.
2020-04-30 11:47:15 +10:00
Liam Fitzgerald
d7a5499b9a
chat: expose types with libs
2020-04-30 09:04:29 +10:00
Matilde Park
e7d05988d3
Merge branch 'mp/chat/pending-reordering' ( #2824 )
...
* origin/mp/chat/pending-reordering:
chat: prepend new pending messages, not append
Signed-off-by: Matilde Park <matilde@tlon.io>
2020-04-29 16:28:52 -04:00
Matilde Park
34b234b652
Merge branch 'master' into mp/chat/input-autofocus
2020-04-29 16:27:29 -04:00
Matilde Park
cf6ef7512f
Merge branch 'lf/chat-eval-scroll' ( #2815 )
...
* origin/lf/chat-eval-scroll:
chat-js: only show scrollbars if overflow
Signed-off-by: Matilde Park <matilde@tlon.io>
2020-04-29 16:24:39 -04:00
Matilde Park
048de06f76
Merge branch 'mp/jank-regex' ( #2813 )
...
* origin/mp/jank-regex:
chat: strictly match URLs in outgoing strings
Signed-off-by: Matilde Park <matilde@tlon.io>
2020-04-29 16:24:17 -04:00
Matilde Park
0926454e08
Merge branch 'mp/chat/code-toggle-2' ( #2796 )
...
* origin/mp/chat/code-toggle-2:
chat: toggle code at start of input
Signed-off-by: Matilde Park <matilde@tlon.io>
2020-04-29 16:22:25 -04:00
matildepark
c050ca10c7
Merge pull request #2784 from urbit/la-channel-err
...
channel-js: fixed long-standing issue with subscription errors not being propagated
2020-04-29 12:41:23 -04:00
Liam Fitzgerald
531efa82a9
chat: address review comments
2020-04-29 18:45:07 +10:00
Liam Fitzgerald
17e1dd8362
chat-js: update read on initialisation
2020-04-29 13:37:58 +10:00
Liam Fitzgerald
eb6b50e0ca
chat-js: truncate nicknames in autocomplete
2020-04-29 13:29:09 +10:00
Liam Fitzgerald
e96bd35f81
various-js: pass props.size into flexBasis for sigil
...
Fixes #2817
2020-04-29 12:51:13 +10:00
Liam Fitzgerald
ae0e5025ad
chat-js: fix race condition in new-dm flow
...
Creating a new DM might redirect the user to the chat before it is
actually created. Fixed by waiting for confirmation before redirecting.
Fixes #2792
2020-04-29 10:14:13 +10:00
Matilde Park
6836135b71
chat: prepend new pending messages, not append
2020-04-28 20:13:09 -04:00
Matilde Park
5487e48ca2
chat: autofocus input on desktop
2020-04-28 19:46:10 -04:00
Liam Fitzgerald
5dc241dbe5
drum: partially restore reverted changes
2020-04-29 08:40:38 +10:00
Liam Fitzgerald
e099f3a8c6
Revert "drum: address review comments"
...
This reverts commit c925665cb8
.
2020-04-29 08:25:21 +10:00
Benjamin Summers
ecf4545d84
king: don't parse crud events, just treat them as nouns.
2020-04-28 11:40:43 -07:00
Liam Fitzgerald
77925a4580
chat-js: fix unread indicators on small screens
...
fixes #2804
2020-04-28 17:08:27 +10:00
Liam Fitzgerald
fc1518dc08
chat-js: fix behaviour of unread markers
...
Fixes #2797
2020-04-28 17:08:27 +10:00
Liam Fitzgerald
9b0a4c095e
chat-js: fix scrolling to bottom
...
fixes : #2778
fixes : #2782
2020-04-28 17:08:23 +10:00
Liam Fitzgerald
a7253d4480
chat-js: only show scrollbars if overflow
...
Uses overflow: auto on the code attachments so that scrollbars only
appear if the content overflows the container. Adds borders on sent Hoon
code to improve visual seperation.
2020-04-28 12:56:19 +10:00
Liam Fitzgerald
371c98c035
chat-cli: remove unnecessary %gu scry
...
This is now redundant as chat-store will always boot before chat-cli.
2020-04-28 12:24:21 +10:00
Liam Fitzgerald
216766a84f
link-proxy-hook: remove unnecessary %gu scry
...
This is redundant as the metadata store will always boot before the
link-proxy-hook.
2020-04-28 12:23:28 +10:00
Liam Fitzgerald
c925665cb8
drum: address review comments
2020-04-28 12:20:59 +10:00
Liam Fitzgerald
5f4fc28bc9
chat: improve namespacing of chat-* types
...
Improved the namespacing by dropping the app prefix on types, e.g.
chat-hook-action -> action. Compensated for shadowing by importing the
/sur files behind a face. End result is that a chat-hook-action becomes
an action:hook. Splits chat-json into lib/chat-{hook,store,view}. Uses
^? on changes files in /lib and /sur to discourage deeply nested
importing.
2020-04-28 12:01:13 +10:00
Matilde Park
5b45ad986d
chat: strictly match URLs in outgoing strings
...
Our regex processes true, and sends a message as a URL, if any part of
the string is a URL starting with a URI schema.
We pass this function strings cut up by spaces. If a link was enclosed
in quotes, or in brackets, this would still process as true.
This adds ^ to the regex to only process strings that START with
a schema.
2020-04-27 21:16:10 -04:00
Logan Allen
003c4676b1
hood: added version %4 of hood state
2020-04-27 18:28:31 -04:00
Logan Allen
9b4f070f3e
s3: style cleanup, response to comments
2020-04-27 15:31:04 -04:00
Logan Allen
28c707b300
hood: updated drum to version %3
2020-04-27 15:12:51 -04:00
Logan Allen
d2e2590cce
chat-js: implemented S3 image upload
2020-04-27 15:02:48 -04:00
Logan Allen
7beb575551
groups: fixed error states and visual styling around image upload
2020-04-27 14:47:55 -04:00
Liam Fitzgerald
37cd90a42b
drum: sort cli connections
...
Sorts cli connections so that the user always boots into %dojo
regardless of their @p
Fixes : #2248
2020-04-25 07:21:41 +10:00
Liam Fitzgerald
2e3947e3c0
drum: account for app dependencies on boot
...
Changes drum's boot order to be deterministic regardless of the ship
you're on.
Fixes #2681
2020-04-25 07:20:42 +10:00
Logan Allen
ce1f7c957b
s3-js: got upload working successfully, required CORS * and Headers * and public-read ACL
2020-04-24 12:19:01 -04:00
Logan Allen
ff313fb720
groups-js: initial s3 work
2020-04-24 12:19:01 -04:00
Logan Allen
9c6cb61d61
s3: got tests passing and added the rest of the generators
2020-04-24 12:19:01 -04:00
Logan Allen
285f0bd5e3
s3: integrated with store and reducers
2020-04-24 12:19:01 -04:00
Logan Allen
bec650957c
s3: added configuration settings for setting current bucket and adding / removing buckets from list
2020-04-24 12:19:01 -04:00
Logan Allen
877ae66169
s3.js: switched from putObject to upload for better handling of large files
2020-04-24 12:19:01 -04:00
Logan Allen
38f65474e3
s3: made S3 upload API coherent
2020-04-24 12:19:01 -04:00
Logan Allen
ab3a759ce2
s3-store: poke functionality, updated credentials, added generators
2020-04-24 12:19:01 -04:00
Logan Allen
daf32fd0f9
s3-store: initial commit
2020-04-24 12:19:01 -04:00
Matilde Park
e657a5514c
chat: toggle code at start of input
2020-04-24 09:38:38 -04:00
Jared Tobin
0bcd971c5f
release: urbit-os-v1.0.14.rc1
2020-04-24 12:15:39 +04:00
Matilde Park
83312afb99
groups: add avatar prop to share sheet
2020-04-23 23:05:44 -04:00
Matilde Park
e64da1e79c
publish: show avatars if set
2020-04-23 22:33:00 -04:00
Matilde Park
9ff8f1106a
link: show avatars if set
2020-04-23 22:32:52 -04:00
Matilde Park
51b7635672
groups: show avatars if set
2020-04-23 22:32:29 -04:00
Matilde Park
7ebc09a41a
chat: display avatars if set
2020-04-23 22:32:16 -04:00
Logan Allen
15404e0989
groups-js: added ability to set avatar images
2020-04-23 21:28:04 -04:00
Logan Allen
d29ea5703e
channel-js: fixed long-standing issue with subscription errors not being propagated
2020-04-23 16:51:53 -04:00
Liam Fitzgerald
ec03c29b72
chat-hook: fix variable name
2020-04-23 23:12:30 +10:00
Jared Tobin
413ae72164
Merge branch 'ted/sloe' ( #2764 )
...
* ted/sloe:
pill: update solid
fix +sloe for %hint'ed cores
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-23 15:05:57 +04:00
Fang
a810468dcf
Merge pull request #2777 from urbit/ixv/publish-groupify
...
publish: groupify notebooks
2020-04-23 02:00:24 +02:00
matildepark
5ccfd0537b
Merge pull request #2740 from liam-fitzgerald/lf/chat-group-autoleave
...
chat: leave chats associated with group on group leave
2020-04-22 18:41:10 -04:00
matildepark
8dca42ee19
Merge pull request #2759 from liam-fitzgerald/lf/unread-title
...
various-fe: add unread counts to title
2020-04-22 18:40:46 -04:00
Matilde Park
0beabe2195
Merge branch 'master' into mp/sigil-foregrounding
2020-04-22 18:37:13 -04:00
matildepark
8968190e55
Merge pull request #2714 from liam-fitzgerald/lf/profile-overlay
...
chat: profile overlay and DMs
2020-04-22 18:32:53 -04:00
Isaac Visintainer
f46bc4b397
publish: addressed review, fixed issue with metadata
2020-04-22 15:14:24 -07:00
Logan Allen
c374e17ba5
contact-view: redirect upon url case of avatar
2020-04-22 18:08:59 -04:00
Liam Fitzgerald
f5d8a36df2
Merge branch 'master' into lf/profile-overlay
2020-04-23 07:49:04 +10:00
Logan
c36c5a9bd3
Merge branch 'master' into os1-avatar
2020-04-22 11:42:33 -04:00
Jared Tobin
5b9887ca19
Merge branch 'la-contact-delete-fix' ( #2738 )
...
* origin/la-contact-delete-fix:
t groups + contacts: make removes completely clean up state
contact-js: made channel handle onChannelError
contact-hook: tested it, got /synced path working, and subscriptions loading
contacts: fix group deletion and do some quality of life fixes
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-22 14:04:19 +04:00
Jared Tobin
d79d216ad2
Merge branch 'mp/publish/numbered-list-line-height' ( #2775 )
...
* origin/mp/publish/numbered-list-line-height:
publish: set font size for ordered lists
publish: change line-height on numbered lists
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-22 14:03:13 +04:00
Liam Fitzgerald
c16b711278
chat-js: correct overlay reflow and review comments
2020-04-22 15:03:19 +10:00
Liam Fitzgerald
8277802027
chat-js: lint changed files
2020-04-22 13:46:03 +10:00
Liam Fitzgerald
8e028ad255
Merge branch 'master' into lf/profile-overlay
2020-04-22 13:39:00 +10:00
Logan Allen
f6a2f7f83c
contact: finish %octt implementation
2020-04-21 19:59:03 -04:00
Matilde Park
707bedc2b4
publish: set font size for ordered lists
2020-04-21 19:36:30 -04:00
Isaac Visintainer
a29aa2d01a
publish: add groupify frontend
2020-04-21 14:34:45 -07:00
Isaac Visintainer
5a771157c5
publish: fix edit-book reducer
2020-04-21 14:34:45 -07:00
Isaac Visintainer
49463197f5
publish: add groupify action
2020-04-21 14:34:40 -07:00
Logan Allen
2f7e8fd811
contacts: added "url" avatar support and finished "octet" avatar
...
fetching support
2020-04-21 15:29:47 -04:00
Matilde Park
bcde27a7ff
publish: change line-height on numbered lists
2020-04-21 15:05:48 -04:00
Logan Allen
6d4a694aeb
t groups + contacts: make removes completely clean up state
2020-04-21 15:00:43 -04:00
Matilde Park
fa35038c2b
groups: lint contact-card.js
2020-04-21 14:57:26 -04:00
Matilde Park
68961c484c
groups: restrict sigil color input to 6 hex chars
2020-04-21 14:56:45 -04:00
Matilde Park
0e357373c0
chat: lint chat-input.js
2020-04-21 14:31:32 -04:00
Matilde Park
de077ffb47
chat: set code toggle only at start of input
2020-04-21 14:30:28 -04:00
Liam Fitzgerald
3ded8c9f68
chat-fe: add backlog loading indicator
...
Adds a backlog loading indicator that displays when we have not yet
received the backlog from the host.
2020-04-21 19:38:30 +10:00
Jared Tobin
995b92650e
Merge branch 'lf/unread-day-indicators' ( #2768 )
...
* origin/lf/unread-day-indicators:
chat-fe: fix unreadnotice position on mobile
chat-fe: add unread and day indicators
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:07:25 +04:00
Jared Tobin
bee001de26
Merge branch 'lf/contacts-separate-user' ( #2766 )
...
* origin/lf/contacts-separate-user:
groups-js: seperate user's ship from rest of contacts
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:06:49 +04:00
Jared Tobin
358aa5025f
Merge branch 'liam-fitzgerald/lf/chat-markdown-input' ( #2756 )
...
* liam-fitzgerald/lf/chat-markdown-input:
chat-js: revive # prefix for code messages
chat-js: toggle code editor on icon click
chat-js: disabled block level elements in messages
chat-js: render markdown in messages
chat-js: use CodeMirror for chat input
chat-js: add CodeMirror dependency
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:06:18 +04:00
Jared Tobin
a9d10a5471
Merge branch 'liam-fitzgerald/lf/publish-del-edit' ( #2734 )
...
* liam-fitzgerald/lf/publish-del-edit:
chat-fe: move cancel button below comment edit
publish-js: lift editing state to comment list
publish: fix check on edit-comment delta
publish-js: avoid unnecessary scrollbars on note view
publish-js: allow deletion and editing of comments
publish: use @tas for comment ref in marks
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:05:57 +04:00
Jared Tobin
a5b9631c9e
Merge branch 'king-handle-ames-exception' ( #2698 )
...
* origin/king-handle-ames-exception:
king: handle IOError from recvFrom in ames.
king: increment version for new pill
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-21 13:05:29 +04:00
Liam Fitzgerald
2cec3c4e90
chat-fe: fix unreadnotice position on mobile
2020-04-21 16:58:30 +10:00
Liam Fitzgerald
0fc12b1456
Merge branch 'master' into lf/unread-day-indicators
2020-04-21 15:56:38 +10:00
Liam Fitzgerald
8697c06a7c
chat-fe: fix overlay on FF and address review comments
2020-04-21 15:18:08 +10:00
Liam Fitzgerald
b29e98ec10
Merge branch 'master' into lf/profile-overlay
2020-04-21 15:11:02 +10:00
Liam Fitzgerald
4083af515e
Merge branch 'master' into lf/chat-markdown-input
2020-04-21 13:56:30 +10:00
Liam Fitzgerald
a978ca2b5a
chat: autoleave on watch-ack
2020-04-21 07:50:27 +10:00
Liam Fitzgerald
e21f9d772a
chat: leave chats associated with group on group leave
...
When a group is left, the permissions no longer exist and the mailbox
subscription is kicked. Before attempting to resubscribe, we simply
check if we still have permissions and if not, leave the chat.
2020-04-21 07:47:48 +10:00
Jared Tobin
39c707e596
Merge branch 'ed/chore-update-contributing' ( #2380 )
...
* origin/ed/chore-update-contributing:
contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc
contributing.md: added more pre-req detail to the beginning of the edit
contributing.md: Added a new section outlining how to develop urbit's interface
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 13:17:27 +04:00
Jared Tobin
8306560a89
Merge branch 'liam-fitzgerald/mp/chat/firefox-take-2' ( #2733 )
...
* liam-fitzgerald/mp/chat/firefox-take-2:
chat-fe: more FF scrollback fixes
chat-fe: fix index issue with pending messages
chat-fe: correct FF scroll behaviour
chat: scrollToBottom on mount for FF
chat: only scrolltobottom if first backlog grab
chat: add firefox-specific chat window
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 12:41:51 +04:00
Jared Tobin
a2eaec6d6f
Merge branch 'm/link-perf' ( #2728 )
...
* origin/m/link-perf:
link-listen-hook: partially revert 05e6519
link fe: refactor message display into component
link fe: more informative "empty list" display
link-view: in pagination logic, only +lent once
link: minimal initial view result
link-view: add some hints to aid profiling
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-20 12:40:58 +04:00
Liam Fitzgerald
f10bf3c894
chat-fe: add unread and day indicators
2020-04-19 02:23:32 +10:00
Liam Fitzgerald
95edde5d27
groups-js: seperate user's ship from rest of contacts
2020-04-18 21:17:47 +10:00
Fang
dbc172af29
Merge pull request #2758 from urbit/m/chat-cli-order
...
chat-cli: account for reverse message ordering
2020-04-18 13:16:54 +02:00
Fang
0815c56d1d
Merge pull request #2746 from urbit/m/chat-hook-leave
...
chat-hook: on %remove, try our best to pull subs
2020-04-18 13:13:53 +02:00
Fang
9f42d420b3
chat-hook: remove incorrect comment
...
We do, in fact, use it. Implicitly, when reestablishing the subscription during
kick handling.
2020-04-18 13:13:08 +02:00
Ted Blackman
7b19580503
fix +sloe for %hint'ed cores
2020-04-18 02:11:34 -04:00
Liam Fitzgerald
4d118ce6c4
chat-js: revive # prefix for code messages
2020-04-18 15:10:19 +10:00
Matilde Park
99875b2f45
various: set sigil foreground based on contrast
2020-04-17 19:27:37 -04:00
Liam Fitzgerald
535cace962
chat-js: toggle code editor on icon click
...
Toggles a code editor, to enable sending of 'code' type messages. 'me'
type messages are now sent by beginning a message with /me.
2020-04-17 21:46:17 +10:00
Liam Fitzgerald
11e69b7bd0
chat-js: disabled block level elements in messages
2020-04-17 21:13:58 +10:00
Liam Fitzgerald
63fc6ed513
various-fe: add unread counts to title
2020-04-17 16:51:51 +10:00
Liam Fitzgerald
5fbe955874
chat-fe: more FF scrollback fixes
2020-04-17 15:17:52 +10:00
Liam Fitzgerald
1b90328f39
chat-fe: fix index issue with pending messages
...
To produce message elements we iterate over pendingMessage ++ messages,
but to check whether they're adjacent to a message by the same author,
we index back into messages, which produces incorrect results when
pendingMessages is nonEmpty
2020-04-17 14:20:28 +10:00
Liam Fitzgerald
41be649764
Merge branch 'master' into mp/chat/firefox-take-2
2020-04-17 12:06:34 +10:00
Fang
6f13546e2d
chat-cli: account for reverse message ordering
...
#2618 changed the way chat-store orders messages. We need to account for that
when processing/printing. This is the minimum viable fix.
2020-04-16 16:52:40 +02:00
Jared Tobin
18878727b0
Merge branch 'liam-fitzgerald/lf/links-autoleave' ( #2754 )
...
* liam-fitzgerald/lf/links-autoleave:
link: leave collection on leaving associated group
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:32 +04:00
Jared Tobin
e7984324be
Merge branch 'fix-pending' ( #2751 )
...
* origin/fix-pending:
chat-js: fix chat ordering and pending messages
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:54:12 +04:00
Jared Tobin
6ef155b82b
Merge branch 'fix-chat-autojoin' ( #2749 )
...
* origin/fix-chat-autojoin:
chat-js: fix auto-join and a chatSynced error
chat-js: fix issue with autojoining
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:59 +04:00
Jared Tobin
b655105a38
Merge branch 'liam-fitzgerald/lf/link-ios-crash' ( #2742 )
...
* liam-fitzgerald/lf/link-ios-crash:
link-js: fix pages disappearing on small screens
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-16 16:53:36 +04:00
Liam Fitzgerald
a7a539bb24
link: leave collection on leaving associated group
...
Automatically leaves a collection when the user is removed from a group
2020-04-16 21:45:58 +10:00
Liam Fitzgerald
945fb3fca6
chat-js: render markdown in messages
...
Renders markdown in text messages but not url or code messages.
2020-04-16 20:21:29 +10:00
Liam Fitzgerald
9574765de6
chat-js: use CodeMirror for chat input
...
swaps out the textarea for a CodeMirror in markdown mode. Resolves an
issue related to the input shrinking with the content.
2020-04-16 20:21:29 +10:00
Liam Fitzgerald
a424312d12
chat-js: add CodeMirror dependency
...
Adds CodeMirror dependency and related css
2020-04-16 20:21:27 +10:00
Fang
4c4858f198
chat-hook: clarify backlog wire handling logic
2020-04-16 01:44:36 +02:00
Fang
d1feabd1fb
dbug: print result with priority
...
To give it some color, making it less easy to miss.
2020-04-15 23:50:53 +02:00
Logan Allen
e98605c1bb
chat-js: fix chat ordering and pending messages
2020-04-15 16:48:33 -04:00
Fang
e2034eca19
dbug: avoid printing nothing at all
...
Previously, if filtering subscriptions turned up no results, nothing was
printed. With this change, we explicitly print "no matching subscriptions"
instead.
2020-04-15 22:28:59 +02:00
Logan Allen
c497d5a6a6
chat-js: fix auto-join and a chatSynced error
2020-04-15 15:58:03 -04:00
Logan Allen
f035070387
chat-js: fix issue with autojoining
2020-04-15 15:04:54 -04:00
Fang
0f05ed3149
chat-hook: consistently pull backlog subs
...
We weren't accounting for backlog subscriptions with non-zero message
indexes in their wires. Now, we look through all of our outgoing
subscriptions to identify relevant backlog subscriptions, and leave all
of those.
The more proper fix here is to not include message indexes in the wire
in the first place, since we don't ever reuse that anywhere. But that's
a more invasive change, so we just leave a TODO for it instead.
2020-04-15 19:26:58 +02:00
Jared Tobin
65cad93b1b
Merge branch 'liam-fitzgerald/lf/chat-input-line-height' ( #2743 )
...
* liam-fitzgerald/lf/chat-input-line-height:
chat-js: adjust line height in chat input
Signed-off-by: Jared Tobin <jared@tlon.io>
2020-04-15 20:18:14 +04:00
Fang
084ce356a8
chat-hook: on %remove, try our best to pull subs
...
Previously, we were removing the relevant entry from the `synced` map
before calling `+pull-wire`, which requires an entry to still be there.
This lead to subscriptions not actually being pulled, commonly leading
to "subscribe wire not unique" errors on re-join.
In addition to fixing that, `%remove` actions now try to pull the
subscription regardless of whether they have an entry in the `synced`
map or not. `%leave` is always safe, and we might want to clean up
subscriptions that shouldn't be there anymore in the first place.
2020-04-15 16:29:26 +02:00
Liam Fitzgerald
8b48f3fa0f
chat-js: adjust line height in chat input
...
Set the line height of the input to be the same as a sent message.
Additionally fixes an issue that would cause unnecessary scrollbars to
be shown.
2020-04-15 15:08:42 +10:00
Liam Fitzgerald
536e3121b6
link-js: fix pages disappearing on small screens
...
The rightPanelHide prop was being improperly set on the home, settings
and members screens, causing them to be blank on small screen sizes
Fixes #2727
2020-04-15 14:27:29 +10:00
Liam Fitzgerald
50dca97b07
publish: increase legibility for code in dark mode
...
Makes the rules that set both a background and foreground color come
last in the CSS, increasing their specificity. Changes the highlight to a
lighter grey, to better stand out. Correctly aligns highlights with code
block backgrounds.
Fixes #2684
2020-04-15 13:45:22 +10:00
Liam Fitzgerald
ba18737b5e
chat-fe: move cancel button below comment edit
2020-04-15 10:59:56 +10:00
Liam Fitzgerald
b538cfd3ea
chat-fe: address review comments
2020-04-15 10:48:46 +10:00
Liam Fitzgerald
963d04831d
Merge branch 'master' into lf/publish-del-edit
2020-04-15 10:07:29 +10:00
Liam Fitzgerald
595acd17ff
publish-js: lift editing state to comment list
2020-04-15 09:57:43 +10:00
Liam Fitzgerald
c46642af8d
publish: fix check on edit-comment delta
...
An incorrect check caused comment editing to never be propagated.
2020-04-15 09:57:07 +10:00
ixv
b978d4f824
Merge pull request #2736 from urbit/ixv/fix-comment-grow
...
publish: fix bug in comment mark
2020-04-14 15:53:26 -07:00
Logan Allen
0145981542
contact-js: made channel handle onChannelError
2020-04-14 18:16:44 -04:00
Logan Allen
bfcaf6468e
contact-hook: tested it, got /synced path working, and subscriptions loading
2020-04-14 18:05:32 -04:00
Logan Allen
b6e4566e61
contacts: fix group deletion and do some quality of life fixes
2020-04-14 21:33:01 +00:00
ixv
5bb9776b70
Merge pull request #2730 from liam-fitzgerald/lf/chat-synced-fix
...
chat-fe: resubscribe message iff chatSynced is populated
2020-04-14 11:40:45 -07:00
ixv
e5cf4fb813
Merge pull request #2720 from urbit/la-channel-err
...
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-14 11:40:02 -07:00
Isaac Visintainer
113c86037c
publish: fix bug in comment mark
2020-04-14 11:23:06 -07:00
Fang
7b5f7cde6b
link-listen-hook: partially revert 05e6519
...
We still want to auto-opt-in to new collections for _unmanaged groups_,
because we have no other way to join them.
2020-04-14 16:12:09 +02:00
Liam Fitzgerald
a3fed45af1
publish-js: avoid unnecessary scrollbars on note view
...
the root container had height: 100% but also a margin-top set on it. This
caused unnecessary scrollbars to appear when the content did not
actually overflow the container.
2020-04-14 20:38:35 +10:00
Liam Fitzgerald
d63cc0d7de
publish-js: allow deletion and editing of comments
...
Adds interface affordances for the addition and removal of comments.
2020-04-14 20:20:59 +10:00
Liam Fitzgerald
fa92d1cb7f
publish: use @tas for comment ref in marks
...
Comment references in publish actions are @tas of a rendered @da. The
mark expected @da, causing a mismatch.
2020-04-14 20:15:57 +10:00
Liam Fitzgerald
9ddf06d2a1
chat-fe: correct FF scroll behaviour
...
Firefox treats the reflow in the scroll container weirdly so for the
scrollback case, we save the position to restore later, when the backlog
messages come in. For the 'locked at bottom' case we add a new state
variable and rescroll based on that.
2020-04-14 16:34:10 +10:00
Isaac Visintainer
d8cdbfdeb8
release: urbit-os-v1.0.13
2020-04-13 19:26:13 -07:00
ixv
2c56937f0d
Merge pull request #2701 from lukechampine/syntax-error-src
...
ford: print source line on syntax error
2020-04-13 19:03:05 -07:00
Liam Fitzgerald
a6c5e96902
chat-fe: don't redirect if creating group
2020-04-14 11:50:47 +10:00
Liam Fitzgerald
786f2518e7
chat-fe: resubscribe message iff chatSynced is populated
...
Previously, if a room was navigated to directly, the resubscribe message
would show before the chatSynced state was loaded. Initialises
chatSynced as null and checks it is not null before showing the
resubscribe message.
2020-04-14 11:41:38 +10:00
Matilde Park
a4d37c0313
Merge branch 'master' into mp/chat/firefox-take-2
2020-04-13 21:38:27 -04:00
Liam Fitzgerald
1d81107d72
Merge branch 'master' into lf/profile-overlay
2020-04-14 11:04:52 +10:00
Liam Fitzgerald
a2998bdc41
chat-fe: redirect to DMs on trivial new group case
...
Create or view a DM upon trying to create an invite-only group with one invitee.
2020-04-14 11:01:31 +10:00
ixv
a7f20c37c1
Merge pull request #2700 from liam-fitzgerald/lf/invite-search-short
...
invite-search: handle suggestions for short searches
2020-04-13 16:56:26 -07:00
ixv
2d30886b65
Merge pull request #2724 from urbit/ixv/install-mousetrap
...
publish: install mousetrap before we use it....
2020-04-13 16:55:40 -07:00
ixv
228bee42e4
Merge pull request #2707 from urbit/ixv/cache-posts
...
publish: eagerly store your own changes
2020-04-13 16:54:41 -07:00
ixv
3526cfa4e6
Merge pull request #2618 from urbit/chat-reverse-messages
...
chat: reversed order that messages are stored in for faster performance
2020-04-13 16:54:16 -07:00
Isaac Visintainer
78023b8eff
publish: ignore edit updates if they originated with us
2020-04-13 13:34:50 -07:00
Isaac Visintainer
7edcd65699
publish: add facilities for managing limbo state
2020-04-13 13:33:34 -07:00
Fang
7aebcad25b
link fe: refactor message display into component
2020-04-13 21:54:50 +02:00
Fang
0d73b391b4
link fe: more informative "empty list" display
...
Displays "Loading..." if the links haven't loaded yet. If there are no
links, tells the user they can save one.
2020-04-13 21:37:42 +02:00
Fang
4da0d636d3
link-view: in pagination logic, only +lent once
...
Also just use +swag instead of chaining +scag and +slag manually.
2020-04-13 21:26:44 +02:00
Fang
8f3d174c94
link: minimal initial view result
...
On initial load, instead of getting the first 25 links for every
collection, only get their totals and unread counts. This drastically
reduces the pageload time.
Updates the frontend to match:
- Handle initial results without link content.
- Dynamically load in collection's links, even for page 0.
2020-04-13 21:26:09 +02:00
Fang
bf42afbd56
link-view: add some hints to aid profiling
2020-04-13 21:15:51 +02:00
Jared Tobin
cc16e905af
Merge branch 'yosoyubik/apt-dup' ( #2417 )
...
* yosoyubik/apt-dup:
hoon: +apt:by check for duplicate keys
2020-04-13 17:43:41 +04:00
Jared Tobin
bf78e71479
Merge branch 'courajs/json-unit-tests' ( #1769 )
...
* courajs/json-unit-tests:
Change at:dejs-soft:format to reject too-long json arrays
Add unit tests for json de/serialization.
2020-04-13 16:38:42 +04:00
Isaac Visintainer
2608dea563
publish: style changes and comments
2020-04-13 00:04:33 -07:00
Isaac Visintainer
d3ab26e57c
publish: restore OS0 -> OS1 transition logic
2020-04-12 23:38:54 -07:00
Isaac Visintainer
277bc8d465
publish: make reducers able to handle duplicate updates now that we send updates both pre and post confirmation
2020-04-12 23:21:43 -07:00
Isaac Visintainer
a40d292bb7
publish: remove or add posts/comments from limbo depending on whether they succeeded or failed
2020-04-12 23:21:42 -07:00
Isaac Visintainer
d2fdae4d4b
publish: immediately store post and comment changes
2020-04-12 23:21:42 -07:00
Isaac Visintainer
f9e17e61a2
publish: update state with limbo field
2020-04-12 23:21:42 -07:00
Isaac Visintainer
20d3c4105d
publish: install mousetrap before we use it....
2020-04-12 23:05:32 -07:00
Liam Fitzgerald
2c870cdfc0
chat-fe: resuscitate scrollback
...
If the initial 20 messages doesn't cause the messages container to
overflow then the backlog will never be requested, making scrollback
impossible. This is due to making the container have position:relative
in order to display an overlay inside it. Fixed by unconditionally
requesting the first page of backlog on load.
2020-04-11 20:07:01 +10:00
Liam Fitzgerald
d2d9158ea3
chat-fe: hide profile overlay on click outside
...
Hides the profile overlay when the users clicks outside the overlay.
2020-04-11 19:34:11 +10:00
Liam Fitzgerald
966155088c
chat-fe: move new DMs to ship select popover
...
Refactored the patp autocomplete into a reusable component, and then
used that to add the DM popover interface. Also introduces some
performance improvements for the popover.
2020-04-11 17:47:11 +10:00
Liam Fitzgerald
803c7b4816
chat-fe: edit group identity if own profile overlay
...
Shows an "Edit Group Identity" button instead of "Send Message" if the
profile overlay being shown is the user's own.
2020-04-11 10:44:57 +10:00
Liam Fitzgerald
e5634a913d
invite-search: always add search query if valid patp
2020-04-11 10:17:49 +10:00
Logan Allen
fb3111e88a
channel.js: added way to handle event source errors more smoothly, and implemented in chat
2020-04-10 19:38:13 -04:00
Logan Allen
98f4df14a4
chat-js: made scrollback work for new message indexing
2020-04-10 22:22:14 +00:00
Logan Allen
8ffca926e7
chat-js: reverted built files
2020-04-10 17:34:23 -04:00
Logan Allen
6d1efde884
chat-js: fixed scrollback for reverse message chatrooms
2020-04-10 17:29:23 -04:00
Matilde Park
948dbe85e7
chat: scrollToBottom on mount for FF
2020-04-10 16:55:23 -04:00
Matilde Park
a212a5dc69
Merge branch 'master' into mp/chat/firefox-take-2
2020-04-10 16:44:15 -04:00
Matilde Park
1ddbc77157
chat: only scrolltobottom if first backlog grab
2020-04-10 16:42:05 -04:00
Matilde Park
3dc6a0bc9a
chat: add firefox-specific chat window
2020-04-10 16:34:27 -04:00
ixv
e253ec1860
Merge pull request #2562 from nijynot/chore/interface-lint
...
interface: add eslint to interface and lint `launch` and `chat`
2020-04-10 13:04:58 -07:00
Logan Allen
b85697cbec
chat-hook: respect backlog index, no longer truncate
2020-04-10 15:25:58 -04:00
Logan Allen
be1d5cee56
chat-store: flop envelopes in handle-messages so backlog comes in correct order
2020-04-10 15:25:58 -04:00
Logan Allen
8cdfb559f6
chat-view and hook: style pass and backlog truncation
2020-04-10 15:25:58 -04:00
Logan Allen
ecc8942eaf
chat: reversed order that messages are stored in for faster performance
2020-04-10 15:25:58 -04:00
Liam Fitzgerald
e7887b34c3
invite-search: handle suggestions for short searches
...
Triggers invitee suggestions after one character of input. To
compensate for the potential explosion of suggestions, we
tighten our group searching criteria and truncate the
ship suggestions on short searches. Also addresses a bug where names of
groups were not being downcased before search.
Fixes #2635
2020-04-10 19:57:50 +10:00
Liam Fitzgerald
c162f0f212
chat-fe: add DMs and related screens
...
Adds DMs, which are just unmanaged chats whose last path component
starts with dm-- followed by the patp of the other user.
2020-04-10 19:45:25 +10:00
Liam Fitzgerald
1bca495d8a
chat-fe: reflow profile overlay near edges of screen
...
Polls for the distance between the top of the container and reflows the
overlay accordingly.
2020-04-10 17:59:04 +10:00
Liam Fitzgerald
188a1e8dcf
chat-fe: hide/show profile overlay on sigil click
...
Hide and shows profile overlay on sigil click. Shows the overlay for 2
seconds after click. If the user moves their mouse into the overlay then
it will remain open as long as the mouse is inside the overlay.
2020-04-10 17:59:04 +10:00
Liam Fitzgerald
f3c21fae36
chat-fe: add profile overlay
...
Adds a profile overlay to display information about the user on hover.
Also adds the svgClass prop to the sigil component, to allow setting
classes directly on the sigil svg.
2020-04-10 17:58:46 +10:00
Isaac Visintainer
eef6e56dca
release: urbit-os-v1.0.12
2020-04-09 17:47:55 -07:00
ixv
12b6a5ccc5
Merge pull request #2600 from urbit/dk-help-generator
...
completed +help comments for places they were missing
2020-04-09 16:51:22 -07:00
ixv
b43f4d9d39
Merge pull request #2709 from urbit/mp/chat/namespace-group-chats
...
chat: add unique ID to grouped chat paths
2020-04-09 15:54:53 -07:00
ixv
f0d702002a
Merge pull request #2708 from urbit/m/link-opt-in
...
link: require explicit opt-in for new collections
2020-04-09 15:54:41 -07:00
ixv
c65b896a2c
Merge pull request #2705 from liam-fitzgerald/lf/publish-loading-fix
...
publish-fe: improve UX of loading spinner on new note
2020-04-09 15:54:04 -07:00
ixv
d376fd6998
Merge pull request #2704 from liam-fitzgerald/lf/chat-padding-sidebar
...
chat-fe: filter empty groups in sidebar
2020-04-09 15:53:55 -07:00
ixv
8e480b611d
Merge pull request #2703 from liam-fitzgerald/lf/chat-patp-copy
...
chat-fe: copy patp to clipboard on author name click
2020-04-09 15:53:46 -07:00
ixv
c5eb540c71
Merge pull request #2702 from liam-fitzgerald/lf/chat-join-spinner
...
chat-fe: show spinner on join
2020-04-09 15:53:35 -07:00
ixv
bc5358c0fd
Merge pull request #2695 from liam-fitzgerald/lf/sanitise-md-publish
...
publish: sanitise markdown snippets in preview
2020-04-09 15:52:52 -07:00
ixv
a41096153d
Merge pull request #2694 from liam-fitzgerald/lf/invite-search-arrow-keys
...
invite-search: allow keyboard nav + selection
2020-04-09 15:52:36 -07:00
ixv
77933e992a
Merge pull request #2693 from urbit/mp/re-alphabetise
...
various: alphabetise associations accesses the object
2020-04-09 15:52:18 -07:00
ixv
5fe16a7f47
Merge pull request #2687 from urbit/la-resub-on-err
...
chat-js: resubscribe on error, not just on quit
2020-04-09 15:52:03 -07:00
Isaac Visintainer
1fdf8a9789
Merge branch 'gall-hack-new-deal'
2020-04-09 15:39:49 -07:00
ixv
43484d613c
Merge pull request #2683 from urbit/mp/invite-search/associations
...
invite search: populate group index from contacts
2020-04-09 15:37:56 -07:00
ixv
8d32d49daf
Merge pull request #2668 from urbit/mp/link/dib-ing
...
link: line up link info on same line height
2020-04-09 15:37:38 -07:00
Logan Allen
a5d6403f39
gall: updated to soft properly
2020-04-09 14:53:12 -04:00
Matilde Park
9881fb2a2b
chat: add unique ID to grouped chat paths
2020-04-09 14:37:21 -04:00
Fang
05e651970e
link: require explicit opt-in for new collections
...
Instead of auto-watching a new collection when it gets added to group
associations, require that the user explicitly choose to view it.
Of course, creation counts as opting in, so watch the collections we
create by default.
2020-04-09 19:01:58 +02:00
nijynot
6536054b91
interface: add eslint and update contrib docs
2020-04-09 12:08:23 +02:00
Logan Allen
7edc183ded
gall: soft cast chat-action, and remove the chat-update hack
2020-04-09 02:09:51 -04:00
Liam Fitzgerald
0c062104a5
publish-fe: improve UX of loading spinner on new note
...
Improve the UX of the loading spinner that shows when you have a new
note, by displaying it until we receive the new note in the
subscription, instead of until the poke succeeds.
2020-04-09 16:06:10 +10:00
Liam Fitzgerald
6586aa98e3
chat-fe: filter empty groups in sidebar
...
Empty groups caused the padding on the first group to be too large.
Filter the groups before we map over them so that we can set padding
properly.
Fixes #2674
2020-04-09 15:08:06 +10:00
Liam Fitzgerald
e2f8be20de
chat-fe: make copy status text inter
2020-04-09 14:13:23 +10:00
Liam Fitzgerald
648eced4ff
chat-fe: copy patp to clipboard on author name click
2020-04-09 13:12:48 +10:00
Liam Fitzgerald
b4fb8d5163
chat-fe: show spinner on join
...
Shows the spinner whilst joining a channel, both manually and from a
url. Also fixes an issue where a newly joined channel may be navigated
away from automatically.
2020-04-09 12:48:55 +10:00
lukechampine
cb4cae01c8
ford: print source line on syntax error
2020-04-08 21:11:15 -04:00
Fang
c570def06a
Merge pull request #2680 from mhartl/master
...
Fix spelling of "existent"
2020-04-09 00:32:34 +02:00
Liam Fitzgerald
3801056d3c
invite-search: allow keyboard nav + selection
...
Allows the user to navigate potential invitees with the arrow keys and
with shift+tab and tab. Enter adds the currently selected invitee.
2020-04-09 08:03:21 +10:00
Liam Fitzgerald
ff70a2be89
publish: sanitise markdown snippets in preview
...
Runs the snippet through ReactMarkdown instead of rendering it as text.
We restrict the allowed nodes in the render to pure text, so the snippet is not
overly visually heavy.
2020-04-09 07:56:44 +10:00
Elliot Glaysher
81fb798bfb
king: handle IOError from recvFrom in ames.
...
This is an attempt to fix the ames driver so that it reestablishes
a socket after a socket error. This should theoretically fix the
"ames dcoesn't work after computer sleeps" issue, so that when the
os closses a socket, we detect this in waitPacket and attempt to
reestablish the socket.
Closes #2190
2020-04-08 13:33:33 -07:00
Elliot Glaysher
238f6db097
king: increment version for new pill
2020-04-08 13:33:16 -07:00
Matilde Park
839f9090bb
various: alphabetise associations accesses obj
...
Previously we were checking for a title for the association by accessing
a non-existent property of the key we were using to iterate through
the object. What we want to do is access the iterated object to find
that title, and so this commit does that.
2020-04-07 17:35:02 -04:00
Fang
e9233b1a50
link fe: fix "mark all as read" button
...
This wasn't bound, nor calling, correctly.
2020-04-07 20:45:27 +02:00
Fang
9f47cbd568
dbug: document "all subscriptions" option in gen
2020-04-07 11:21:17 +02:00
Logan Allen
7a41f2dcab
chat-js: resubscribe on error, not just on quit
2020-04-06 23:24:13 -04:00
Logan Allen
4d8e0cf26b
gall: added hack to reduce processing time for chat messages by 30%
2020-04-06 22:58:06 -04:00
Matilde Park
00ed295d48
invite search: populate group index from contacts
2020-04-06 19:45:40 -04:00
Aaron Sikes
eb0ce2daba
Change at:dejs-soft:format to reject too-long json arrays
...
`at` is for when you expect an array of a certain exact structure. If it
has extra elements, that indicates you were mistaken about the strucutre,
so it should fail to match.
2020-04-06 14:05:35 -04:00
Aaron Sikes
ecc8d0ee29
Add unit tests for json de/serialization.
...
This tests enjs:format, dejs:format, dejs-soft:format,
en-json:html, and de-json:html.
2020-04-06 13:35:21 -04:00
Michael Hartl
3e203634e3
Fix spelling of "existent"
2020-04-06 08:18:22 -07:00
édouard
6ed7520444
contributing.md: removed interface dev instructions from root-level doc, integrated into existing interface-specific doc
...
I've moved the slightly edited interface development instructions from the root controbuting.md doc, over to the one located in pkg/interface. I've made sure to ensure any precvious information in the interface contributing doc has been matched or expanded upon in the new writing, which is a incrementally more thorough, and assumes a lower level of build-tooling knowledge.
2020-04-03 15:37:42 -04:00
ixv
482e87f8fc
Merge pull request #2662 from urbit/la-app-hints
...
apps: added hints to the top of many networked apps
2020-04-03 10:22:23 -07:00