Commit Graph

22 Commits

Author SHA1 Message Date
Fang
f6bbd98200
link fe: make popout links match new route path style
These really should be made based on the current route path instead of
manually reconstructed, but that's slightly less trivial.
2020-02-06 21:22:16 +01:00
Fang
06a33929b4
link fe: consistently use "linkIndex"
As opposed to sometimes using just "link", when referring to literal
index numbers.
2020-02-06 20:38:53 +01:00
Fang
e6fc59f3df
link fe: ensure LinkDetails always uses sane timestamp 2020-02-06 20:37:52 +01:00
Fang
d9f0d44e0c
link fe: make check less confusing
The only thing we care about is whether or not we have (any & all) data
about the submission. Using URL here is confusing because it conflates
with the prop, and checking the prop in the first place always gives the
same result.
2020-02-06 20:15:22 +01:00
Fang
2f1f9b9c56
link fe: remove unused link-initial logic
Also includes up-to-date index.js.
2020-02-06 17:33:34 +01:00
Fang
ecf9dacbc0
link fe: factor out "page"+i indexing, use plain numbers 2020-02-06 17:31:13 +01:00
Fang
2b4667eb86
link fe: fix page loading behavior
Previously, receiving new items could "locally create" pages,
half-filled with whatever items were pushed down into them. Frontend
would see the existence of the page and assume all was well. However,
the page may have contained more items (on the backend) than just what
we pushed down.

This adds a per-page flag, "local", to indicate such pages. When display
logic sees it's set, it will send a request for the full page,
regardless of currently available data, loading in the canonical full
page as a result.
2020-02-06 17:23:32 +01:00
Fang
438d502c89
link fe: remove unused comment loading logic
This never triggers anymore, comments loading always happens in onMount.
2020-02-06 17:06:05 +01:00
Fang
375755f106
link fe: ensure state is initialized where used 2020-02-06 16:56:04 +01:00
Fang
9b9692e7f1
link fe: fully account for the "number as string" case
The Number() usage is sane, but should be scoped around the variable by
itself. Previously a string of "3" would lead to a Number("31") call,
which is not the intended behavior here.

Also stops passing a {} in if the actual number is unknown.
2020-02-06 16:55:32 +01:00
Fang
e74ec92c4c
link fe: more correct totals updating logic 2020-02-06 16:52:40 +01:00
Fang
50695fe78a
link fe: use correct time attribute 2020-02-06 15:32:14 +01:00
Fang
182d2c3a07
link fe: refactor link-view subscriptions api 2020-02-06 15:25:07 +01:00
Fang
4222ebbfb3
link fe: always render up-to-date comment counts 2020-02-06 15:04:47 +01:00
Fang
ab21f67ba6
link: support loading individual submissions
On the frontend, updates the route path to include the (base64-encoded)
url. Uses that and the load-single functionality to support loading
directly into a submission page, which fetches just the requested
submission.

Also ensures we don't open duplicate comment subscriptions.
2020-02-06 14:50:39 +01:00
Fang
3bbff696b5
link frontend: fix loading into submission page 2020-02-05 21:17:47 +01:00
Fang
e26d2537c7
link: remove trailing whitespace 2020-02-05 18:43:27 +01:00
Fang
4e4f005689
link: update frontend ui logic to match api changes
Updates the frontend display & data fetching logic to match the changes
made in e7eef19d7.
2020-02-05 18:43:20 +01:00
Fang
31b6333ef9
link: update frontend api & reducer functions for link-view
Replaces .json requests with channel.js subscriptions. Rewrites reducers
to match, now being more careful about paginated data, and storing
comments in their own structure, at [group][url] indices, rather than
the non-static [page][index] ones used previously.

Note that this requires some changes to the frontend UI code also.
See next commit.
2020-02-05 18:20:50 +01:00
Matilde Park
fb9c775649 links: amend reducer to add new comments locally 2020-02-03 17:52:39 -05:00
Matilde Park
22f1a52e08 link: amend "channels" copy on landing
It should be "collections," as per OS1 discussions.
2020-01-22 22:20:14 -05:00
Matilde Park
d3f57fbf9d interface: add links FE source code 2020-01-22 18:16:44 -05:00