mirror of
https://github.com/ilyakooo0/urbit.git
synced 2024-12-20 21:31:32 +03:00
ef1b125c3e
Fixes #4598. #4474 made the JSON time conversion no longer invertible, which caused problems for chat, which uses message timestamp in milliseconds as a key -- so chat would send a message with ms timestamp x, it would get encoded as @da x, but then when it went back through the conversion to milliseconds, it would often (not always) get encoded as x-1. I still do not fully understand why this is -- and why it doesn't seem to be a problem with seconds based on cursory testing -- but integer multiplication and division generally do not invert. And adding a half a millisecond to the input date before converting it resolves the issue and makes the functions invertible. I added a regression test, so hopefully the next courageous adventurer who winds up here after wondering why +unm looks funny will have a safeguard against some of the mistakes I made. |
||
|---|---|---|
| .. | ||
| arvo | ||
| hoon | ||
| vane | ||
| zuse | ||