elm-review/tests/NoDebugTest.elm

290 lines
9.8 KiB
Elm
Raw Normal View History

2017-06-18 15:00:48 +03:00
module NoDebugTest exposing (all)
2018-11-11 01:43:58 +03:00
import Lint.Rule.NoDebug exposing (rule)
import Lint.Test exposing (LintResult)
2018-11-22 21:19:19 +03:00
import Test exposing (Test, describe, test)
2017-06-18 14:43:37 +03:00
testRule : String -> LintResult
2018-11-06 20:46:46 +03:00
testRule string =
"module A exposing (..)\n\n"
++ string
|> Lint.Test.run rule
2019-06-16 15:53:07 +03:00
2019-06-30 12:48:19 +03:00
message : String
message =
"Remove the use of `Debug` before shipping to production"
2019-07-28 01:16:57 +03:00
details : List String
details =
2019-07-28 15:45:09 +03:00
[ "The `Debug` module is useful when developing, but is not meant to be shipped to production or published in a package. I suggest removing its use before committing and attempting to push to production."
2019-07-28 01:16:57 +03:00
]
tests : List Test
tests =
[ test "should not report normal function calls" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = foo n
b = bar.foo n
c = debug
e = debug.log n
d = debug.log n
"""
|> Lint.Test.expectNoErrors
, test "should report Debug.log use" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = Debug.log"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug.log calls" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = Debug.log z"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report multiple Debug.log calls" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = Debug.log z
b = Debug.log z
"""
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
|> Lint.Test.atExactly { start = { row = 4, column = 5 }, end = { row = 4, column = 14 } }
, Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
|> Lint.Test.atExactly { start = { row = 5, column = 5 }, end = { row = 5, column = 14 } }
]
, test "should report Debug.todo calls" <|
\() ->
testRule "a = Debug.todo 1"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
, under = "Debug.todo"
2019-06-30 12:48:19 +03:00
}
]
, test "should report any Debug method" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = Debug.foo 1"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.foo"
}
]
, test "should report Debug in a binary expression" <|
\() ->
2019-06-30 12:48:19 +03:00
testRule "a = ( Debug.log z ) + 2"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in a << binary expression" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = fn << Debug.log"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in a pipe expression" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = fn |> Debug.log z"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in an list expression" <|
\() ->
2019-06-30 12:48:19 +03:00
testRule "a = [ Debug.log z y ]"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in an record expression" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = { foo = Debug.log z y }"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
2017-06-18 15:06:36 +03:00
, test "should report Debug in an record update expression" <|
\() ->
testRule "a = { model | foo = Debug.log z y }"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in an lambda expression" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = (\\foo -> Debug.log z foo)"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in an if expression condition" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = if Debug.log a b then True else False"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
2018-11-06 20:46:46 +03:00
, test "should report Debug in an if expression then branch" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = if True then Debug.log a b else False"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
2018-11-06 20:46:46 +03:00
, test "should report Debug in an if expression else branch" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule "a = if True then True else Debug.log a b"
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in a case value" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = case Debug.log a b of
_ -> []
"""
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in a case body" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = case a of
_ -> Debug.log a b
"""
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in let declaration section" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = let b = Debug.log a b
in b
"""
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should report Debug in let body" <|
\() ->
2017-06-18 14:43:37 +03:00
testRule """
2018-11-06 20:46:46 +03:00
a = let b = c
in Debug.log a b
"""
|> Lint.Test.expectErrors
[ Lint.Test.error
2019-06-30 12:48:19 +03:00
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
2019-06-30 12:48:19 +03:00
, under = "Debug.log"
}
]
, test "should not report calls from a module containing Debug but that is not Debug" <|
\() ->
testRule """
a = Foo.Debug.log 1
b = Debug.Foo.log 1
"""
|> Lint.Test.expectNoErrors
, test "should report the import of the Debug module" <|
\() ->
testRule "import Debug"
|> Lint.Test.expectErrors
[ Lint.Test.error
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
, under = "Debug"
}
]
, test "should report the import of the Debug module (with exposing of some things)" <|
\() ->
testRule "import Debug exposing (log)"
|> Lint.Test.expectErrors
[ Lint.Test.error
{ message = message
2019-07-28 01:16:57 +03:00
, details = details
, under = "Debug"
}
]
, test "should not report imports of modules containing Debug but that is not Debug" <|
\() ->
testRule """
import Foo.Debug
import Debug.Foo
"""
|> Lint.Test.expectNoErrors
]
all : Test
all =
describe "NoDebug" tests