2018-11-22 21:19:19 +03:00
|
|
|
module Lint.Rule.NoUnusedVariables exposing (rule)
|
|
|
|
|
|
|
|
{-|
|
|
|
|
|
|
|
|
@docs rule
|
|
|
|
|
|
|
|
|
|
|
|
# Fail
|
|
|
|
|
|
|
|
a n =
|
|
|
|
n + 1
|
|
|
|
|
|
|
|
b =
|
|
|
|
a 2
|
|
|
|
|
|
|
|
|
|
|
|
# Success
|
|
|
|
|
|
|
|
a n =
|
|
|
|
n + 1
|
|
|
|
|
|
|
|
-}
|
|
|
|
|
|
|
|
import Dict exposing (Dict)
|
|
|
|
import Elm.Syntax.Declaration exposing (Declaration(..))
|
|
|
|
import Elm.Syntax.Exposing exposing (Exposing(..), TopLevelExpose(..))
|
|
|
|
import Elm.Syntax.Expression exposing (Expression(..), Function, LetDeclaration(..))
|
|
|
|
import Elm.Syntax.Import exposing (Import)
|
|
|
|
import Elm.Syntax.Module as Module exposing (Module(..))
|
|
|
|
import Elm.Syntax.Node exposing (Node, range, value)
|
|
|
|
import Elm.Syntax.Range exposing (Range)
|
|
|
|
import Elm.Syntax.TypeAnnotation exposing (TypeAnnotation(..))
|
|
|
|
import Lint exposing (Rule, lint)
|
|
|
|
import Lint.Error exposing (Error)
|
2019-06-15 15:47:10 +03:00
|
|
|
import Lint.Rule as Rule
|
2018-11-22 21:19:19 +03:00
|
|
|
import List.Nonempty as Nonempty exposing (Nonempty)
|
|
|
|
import Set exposing (Set)
|
|
|
|
|
|
|
|
|
2018-11-26 13:22:43 +03:00
|
|
|
{-| Reports variables that are declared but never used.
|
|
|
|
|
|
|
|
rules =
|
|
|
|
[ NoUnusedVariables.rule
|
|
|
|
]
|
|
|
|
|
|
|
|
-}
|
|
|
|
rule : Rule
|
|
|
|
rule input =
|
|
|
|
lint input implementation
|
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
type VariableType
|
2018-11-26 20:39:46 +03:00
|
|
|
= Variable
|
|
|
|
| ImportedModule
|
2018-11-26 21:16:04 +03:00
|
|
|
| ImportedVariable
|
|
|
|
| ImportedType
|
|
|
|
| ImportedOperator
|
2018-11-26 20:39:46 +03:00
|
|
|
| ModuleAlias
|
|
|
|
| Type
|
2018-11-26 21:09:18 +03:00
|
|
|
| Port
|
2018-11-26 20:39:46 +03:00
|
|
|
|
|
|
|
|
2018-11-22 21:19:19 +03:00
|
|
|
type alias Scope =
|
2018-11-26 21:16:04 +03:00
|
|
|
{ declared : Dict String ( VariableType, Range )
|
2018-11-22 21:19:19 +03:00
|
|
|
, used : Set String
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
type alias Context =
|
|
|
|
{ scopes : Nonempty Scope
|
|
|
|
, exposesEverything : Bool
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
emptyScope : Scope
|
|
|
|
emptyScope =
|
|
|
|
Scope Dict.empty Set.empty
|
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
error : VariableType -> Range -> String -> Error
|
2018-11-26 20:39:46 +03:00
|
|
|
error variableType range_ name =
|
|
|
|
Error
|
|
|
|
"NoUnusedVariables"
|
2018-11-26 21:09:18 +03:00
|
|
|
(variableTypeToString variableType ++ " `" ++ name ++ "` is not used" ++ variableTypeWarning variableType)
|
2018-11-26 20:39:46 +03:00
|
|
|
range_
|
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
variableTypeToString : VariableType -> String
|
2018-11-26 20:39:46 +03:00
|
|
|
variableTypeToString value =
|
|
|
|
case value of
|
|
|
|
Variable ->
|
|
|
|
"Variable"
|
|
|
|
|
|
|
|
ImportedModule ->
|
|
|
|
"Imported module"
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
ImportedVariable ->
|
|
|
|
"Imported variable"
|
|
|
|
|
|
|
|
ImportedType ->
|
|
|
|
"Imported type"
|
|
|
|
|
|
|
|
ImportedOperator ->
|
|
|
|
"Imported operator"
|
|
|
|
|
2018-11-26 20:39:46 +03:00
|
|
|
ModuleAlias ->
|
|
|
|
"Module alias"
|
|
|
|
|
|
|
|
Type ->
|
|
|
|
"Type"
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2018-11-26 21:09:18 +03:00
|
|
|
Port ->
|
|
|
|
"Port"
|
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
variableTypeWarning : VariableType -> String
|
2018-11-26 21:09:18 +03:00
|
|
|
variableTypeWarning value =
|
|
|
|
case value of
|
|
|
|
Variable ->
|
|
|
|
""
|
|
|
|
|
|
|
|
ImportedModule ->
|
|
|
|
""
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
ImportedVariable ->
|
|
|
|
""
|
|
|
|
|
|
|
|
ImportedType ->
|
|
|
|
""
|
|
|
|
|
|
|
|
ImportedOperator ->
|
|
|
|
""
|
|
|
|
|
2018-11-26 21:09:18 +03:00
|
|
|
ModuleAlias ->
|
|
|
|
""
|
|
|
|
|
|
|
|
Type ->
|
|
|
|
""
|
|
|
|
|
|
|
|
Port ->
|
|
|
|
" (Warning: Removing this port may break your application if it is used in the JS code)"
|
|
|
|
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2018-11-26 13:22:43 +03:00
|
|
|
initialContext : Context
|
|
|
|
initialContext =
|
|
|
|
{ scopes = Nonempty.fromElement emptyScope
|
|
|
|
, exposesEverything = False
|
|
|
|
}
|
2018-11-22 21:19:19 +03:00
|
|
|
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
implementation : Rule.Implementation Context
|
2018-11-22 21:19:19 +03:00
|
|
|
implementation =
|
2019-06-15 15:47:10 +03:00
|
|
|
Rule.create initialContext
|
2019-06-15 21:32:41 +03:00
|
|
|
|> Rule.withModuleDefinitionVisitor moduleDefinitionVisitor
|
|
|
|
|> Rule.withImportVisitor importVisitor
|
|
|
|
|> Rule.withExpressionVisitor expressionVisitor
|
|
|
|
|> Rule.withDeclarationVisitor declarationVisitor
|
|
|
|
|> Rule.withFinalEvaluation finalEvaluation
|
2018-11-22 21:19:19 +03:00
|
|
|
|
|
|
|
|
2019-06-15 21:32:41 +03:00
|
|
|
moduleDefinitionVisitor : Context -> Node Module -> ( List Error, Context )
|
|
|
|
moduleDefinitionVisitor ctx moduleNode =
|
2018-11-22 21:19:19 +03:00
|
|
|
case Module.exposingList (value moduleNode) of
|
|
|
|
All _ ->
|
|
|
|
( [], { ctx | exposesEverything = True } )
|
|
|
|
|
|
|
|
Explicit list ->
|
|
|
|
let
|
|
|
|
names =
|
|
|
|
List.filterMap
|
|
|
|
(\node ->
|
|
|
|
case value node of
|
|
|
|
FunctionExpose name ->
|
|
|
|
Just name
|
|
|
|
|
|
|
|
TypeOrAliasExpose name ->
|
|
|
|
Just name
|
|
|
|
|
|
|
|
TypeExpose { name } ->
|
|
|
|
Just name
|
|
|
|
|
|
|
|
InfixExpose name ->
|
|
|
|
-- Just name
|
|
|
|
Nothing
|
|
|
|
)
|
|
|
|
list
|
|
|
|
in
|
|
|
|
( [], markAllAsUsed names ctx )
|
|
|
|
|
|
|
|
|
2019-06-15 21:32:41 +03:00
|
|
|
importVisitor : Context -> Node Import -> ( List Error, Context )
|
|
|
|
importVisitor ctx node =
|
2018-11-22 21:19:19 +03:00
|
|
|
let
|
2018-11-26 13:22:43 +03:00
|
|
|
exposed =
|
|
|
|
node
|
|
|
|
|> value
|
2018-11-22 21:19:19 +03:00
|
|
|
|> .exposingList
|
|
|
|
in
|
2018-11-26 13:22:43 +03:00
|
|
|
case Maybe.map value exposed of
|
2018-11-26 20:12:36 +03:00
|
|
|
Nothing ->
|
|
|
|
let
|
2018-11-26 20:39:46 +03:00
|
|
|
( variableType, moduleName ) =
|
|
|
|
case value node |> .moduleAlias of
|
|
|
|
Just moduleAlias ->
|
|
|
|
( ModuleAlias, moduleAlias )
|
|
|
|
|
|
|
|
Nothing ->
|
|
|
|
( ImportedModule, value node |> .moduleName )
|
2018-11-26 20:12:36 +03:00
|
|
|
in
|
|
|
|
( []
|
|
|
|
, register
|
2018-11-26 20:39:46 +03:00
|
|
|
variableType
|
2018-11-26 20:12:36 +03:00
|
|
|
(range moduleName)
|
|
|
|
(value moduleName |> getModuleName)
|
|
|
|
ctx
|
|
|
|
)
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2018-11-26 20:12:36 +03:00
|
|
|
Just declaredImports ->
|
|
|
|
( []
|
|
|
|
, List.foldl
|
2018-11-26 21:16:04 +03:00
|
|
|
(\( variableType, range, name ) context -> register variableType range name context)
|
2018-11-26 20:12:36 +03:00
|
|
|
ctx
|
|
|
|
(collectFromExposing declaredImports)
|
|
|
|
)
|
2018-11-22 21:19:19 +03:00
|
|
|
|
|
|
|
|
2019-06-15 21:32:41 +03:00
|
|
|
expressionVisitor : Context -> Rule.Direction -> Node Expression -> ( List Error, Context )
|
|
|
|
expressionVisitor ctx direction node =
|
2018-11-26 13:22:43 +03:00
|
|
|
case ( direction, value node ) of
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, FunctionOrValue [] name ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
( [], markAsUsed name ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, FunctionOrValue moduleName name ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
( [], markAsUsed (getModuleName moduleName) ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, OperatorApplication name _ _ _ ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
( [], markAsUsed name ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, PrefixOperator name ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
( [], markAsUsed name ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, LetExpression { declarations } ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
let
|
|
|
|
newContext =
|
|
|
|
List.foldl
|
|
|
|
(\declaration context ->
|
|
|
|
case value declaration of
|
|
|
|
LetFunction function ->
|
|
|
|
registerFunction function context
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2018-11-26 13:22:43 +03:00
|
|
|
LetDestructuring pattern _ ->
|
|
|
|
context
|
|
|
|
)
|
|
|
|
{ ctx | scopes = Nonempty.cons emptyScope ctx.scopes }
|
|
|
|
declarations
|
|
|
|
in
|
|
|
|
( [], newContext )
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Exit, LetExpression _ ) ->
|
2018-11-26 13:22:43 +03:00
|
|
|
let
|
|
|
|
( errors, remainingUsed ) =
|
|
|
|
makeReport (Nonempty.head ctx.scopes)
|
|
|
|
|
|
|
|
ctxWithPoppedScope =
|
|
|
|
{ ctx | scopes = Nonempty.pop ctx.scopes }
|
|
|
|
in
|
|
|
|
( errors
|
|
|
|
, markAllAsUsed remainingUsed ctxWithPoppedScope
|
|
|
|
)
|
|
|
|
|
|
|
|
_ ->
|
|
|
|
( [], ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
|
|
|
|
2019-06-15 21:32:41 +03:00
|
|
|
declarationVisitor : Context -> Rule.Direction -> Node Declaration -> ( List Error, Context )
|
|
|
|
declarationVisitor ctx direction node =
|
2018-11-22 21:19:19 +03:00
|
|
|
case ( direction, value node ) of
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, FunctionDeclaration function ) ->
|
2018-11-22 21:19:19 +03:00
|
|
|
let
|
|
|
|
declaration =
|
|
|
|
value function.declaration
|
|
|
|
|
|
|
|
namesUsedInSignature =
|
|
|
|
function.signature
|
|
|
|
|> Maybe.map (value >> .typeAnnotation >> collectNamesFromTypeAnnotation)
|
|
|
|
|> Maybe.withDefault []
|
|
|
|
|
|
|
|
newContext =
|
|
|
|
ctx
|
2018-11-26 20:39:46 +03:00
|
|
|
|> register Variable (range declaration.name) (value declaration.name)
|
2018-11-22 21:19:19 +03:00
|
|
|
|> markAllAsUsed namesUsedInSignature
|
|
|
|
in
|
|
|
|
( [], newContext )
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, CustomTypeDeclaration { name } ) ->
|
2018-11-26 20:39:46 +03:00
|
|
|
( [], register Type (range name) (value name) ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, AliasDeclaration { name } ) ->
|
2018-11-26 20:39:46 +03:00
|
|
|
( [], register Type (range name) (value name) ctx )
|
2018-11-22 21:19:19 +03:00
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, PortDeclaration { name, typeAnnotation } ) ->
|
2018-11-26 21:09:18 +03:00
|
|
|
( []
|
|
|
|
, ctx
|
|
|
|
|> markAllAsUsed (collectNamesFromTypeAnnotation typeAnnotation)
|
|
|
|
|> register Port (range name) (value name)
|
|
|
|
)
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, InfixDeclaration _ ) ->
|
2018-11-26 21:09:18 +03:00
|
|
|
( [], ctx )
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Enter, Destructuring _ _ ) ->
|
2018-11-26 21:09:18 +03:00
|
|
|
( [], ctx )
|
|
|
|
|
2019-06-15 15:47:10 +03:00
|
|
|
( Rule.Exit, _ ) ->
|
2018-11-22 21:19:19 +03:00
|
|
|
( [], ctx )
|
|
|
|
|
|
|
|
|
2019-06-15 21:32:41 +03:00
|
|
|
finalEvaluation : Context -> ( List Error, Context )
|
|
|
|
finalEvaluation ctx =
|
2018-11-26 13:22:43 +03:00
|
|
|
let
|
|
|
|
errors =
|
|
|
|
if ctx.exposesEverything then
|
|
|
|
[]
|
|
|
|
|
|
|
|
else
|
|
|
|
ctx.scopes
|
|
|
|
|> Nonempty.head
|
2018-11-26 20:12:36 +03:00
|
|
|
|> makeReport
|
|
|
|
|> Tuple.first
|
2018-11-26 13:22:43 +03:00
|
|
|
in
|
|
|
|
( errors, ctx )
|
|
|
|
|
|
|
|
|
|
|
|
registerFunction : Function -> Context -> Context
|
|
|
|
registerFunction function ctx =
|
|
|
|
let
|
|
|
|
declaration =
|
|
|
|
value function.declaration
|
|
|
|
in
|
2018-11-26 20:39:46 +03:00
|
|
|
register Variable (range declaration.name) (value declaration.name) ctx
|
2018-11-26 13:22:43 +03:00
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
collectFromExposing : Exposing -> List ( VariableType, Range, String )
|
2018-11-26 13:22:43 +03:00
|
|
|
collectFromExposing exposing_ =
|
|
|
|
case exposing_ of
|
|
|
|
All _ ->
|
|
|
|
[]
|
|
|
|
|
|
|
|
Explicit list ->
|
|
|
|
List.filterMap
|
|
|
|
(\node ->
|
|
|
|
case value node of
|
|
|
|
FunctionExpose name ->
|
2018-11-26 21:16:04 +03:00
|
|
|
Just ( ImportedVariable, range node, name )
|
2018-11-26 13:22:43 +03:00
|
|
|
|
|
|
|
InfixExpose name ->
|
2018-11-26 21:16:04 +03:00
|
|
|
Just ( ImportedOperator, range node, name )
|
2018-11-26 13:22:43 +03:00
|
|
|
|
2018-11-26 20:12:36 +03:00
|
|
|
TypeOrAliasExpose name ->
|
2018-11-26 21:16:04 +03:00
|
|
|
Just ( ImportedType, range node, name )
|
2018-11-26 20:12:36 +03:00
|
|
|
|
|
|
|
TypeExpose { name, open } ->
|
|
|
|
case open of
|
|
|
|
Just openRange ->
|
|
|
|
Nothing
|
|
|
|
|
|
|
|
Nothing ->
|
2018-11-26 21:16:04 +03:00
|
|
|
Just ( ImportedType, range node, name )
|
2018-11-26 13:22:43 +03:00
|
|
|
)
|
|
|
|
list
|
|
|
|
|
|
|
|
|
2018-11-22 21:19:19 +03:00
|
|
|
collectNamesFromTypeAnnotation : Node TypeAnnotation -> List String
|
|
|
|
collectNamesFromTypeAnnotation node =
|
|
|
|
case value node of
|
|
|
|
FunctionTypeAnnotation a b ->
|
|
|
|
collectNamesFromTypeAnnotation a ++ collectNamesFromTypeAnnotation b
|
|
|
|
|
|
|
|
Typed nameNode params ->
|
|
|
|
let
|
|
|
|
name =
|
2018-11-26 21:09:18 +03:00
|
|
|
case value nameNode of
|
|
|
|
( [], str ) ->
|
|
|
|
str
|
|
|
|
|
|
|
|
( moduleName, _ ) ->
|
|
|
|
getModuleName moduleName
|
2018-11-22 21:19:19 +03:00
|
|
|
in
|
|
|
|
name :: List.concatMap collectNamesFromTypeAnnotation params
|
|
|
|
|
|
|
|
Record list ->
|
|
|
|
list
|
|
|
|
|> List.map (value >> Tuple.second)
|
|
|
|
|> List.concatMap collectNamesFromTypeAnnotation
|
|
|
|
|
|
|
|
GenericRecord name list ->
|
|
|
|
list
|
|
|
|
|> value
|
|
|
|
|> List.map (value >> Tuple.second)
|
|
|
|
|> List.concatMap collectNamesFromTypeAnnotation
|
|
|
|
|
2018-11-26 21:09:18 +03:00
|
|
|
Tupled list ->
|
|
|
|
List.concatMap collectNamesFromTypeAnnotation list
|
|
|
|
|
|
|
|
GenericType _ ->
|
|
|
|
[]
|
|
|
|
|
|
|
|
Unit ->
|
2018-11-22 21:19:19 +03:00
|
|
|
[]
|
|
|
|
|
|
|
|
|
2018-11-26 21:16:04 +03:00
|
|
|
register : VariableType -> Range -> String -> Context -> Context
|
2018-11-26 20:39:46 +03:00
|
|
|
register variableType range name ctx =
|
2018-11-22 21:19:19 +03:00
|
|
|
let
|
|
|
|
scopes =
|
|
|
|
mapNonemptyHead
|
|
|
|
(\scope ->
|
2018-11-26 20:39:46 +03:00
|
|
|
{ scope | declared = Dict.insert name ( variableType, range ) scope.declared }
|
2018-11-22 21:19:19 +03:00
|
|
|
)
|
|
|
|
ctx.scopes
|
|
|
|
in
|
|
|
|
{ ctx | scopes = scopes }
|
|
|
|
|
|
|
|
|
2018-11-26 13:22:43 +03:00
|
|
|
markAllAsUsed : List String -> Context -> Context
|
|
|
|
markAllAsUsed names ctx =
|
|
|
|
List.foldl markAsUsed ctx names
|
|
|
|
|
|
|
|
|
2018-11-22 21:19:19 +03:00
|
|
|
markAsUsed : String -> Context -> Context
|
|
|
|
markAsUsed name ctx =
|
|
|
|
let
|
|
|
|
scopes =
|
|
|
|
mapNonemptyHead
|
|
|
|
(\scope ->
|
|
|
|
{ scope | used = Set.insert name scope.used }
|
|
|
|
)
|
|
|
|
ctx.scopes
|
|
|
|
in
|
|
|
|
{ ctx | scopes = scopes }
|
|
|
|
|
|
|
|
|
2018-11-26 13:22:43 +03:00
|
|
|
getModuleName : List String -> String
|
|
|
|
getModuleName name =
|
|
|
|
String.join "." name
|
2018-11-22 21:19:19 +03:00
|
|
|
|
|
|
|
|
|
|
|
makeReport : Scope -> ( List Error, List String )
|
|
|
|
makeReport { declared, used } =
|
|
|
|
let
|
|
|
|
nonUsedVars =
|
|
|
|
Set.diff used (Set.fromList <| Dict.keys declared)
|
|
|
|
|> Set.toList
|
|
|
|
|
|
|
|
errors =
|
|
|
|
Dict.filter (\key _ -> not <| Set.member key used) declared
|
|
|
|
|> Dict.toList
|
2018-11-26 20:39:46 +03:00
|
|
|
|> List.map (\( key, ( variableType, range ) ) -> error variableType range key)
|
2018-11-22 21:19:19 +03:00
|
|
|
in
|
|
|
|
( errors, nonUsedVars )
|
|
|
|
|
|
|
|
|
|
|
|
mapNonemptyHead : (a -> a) -> Nonempty a -> Nonempty a
|
|
|
|
mapNonemptyHead fn nonempty =
|
|
|
|
let
|
|
|
|
newHead =
|
|
|
|
fn (Nonempty.head nonempty)
|
|
|
|
in
|
|
|
|
Nonempty.replaceHead newHead nonempty
|