jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-11 16:16:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use FilePattern

Browse Source
This commit is contained in:
Jeroen Engels 2024-04-07 23:26:53 +02:00
parent ade886ddd1
commit 05219b1cfa
3 changed files with 27 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
review/src/ReviewConfig.elm
View File

@ -34,6 +34,7 @@ import NoUnused.Parameters
import NoUnused.Patterns import NoUnused.Patterns
import NoUnused.Variables import NoUnused.Variables
import Review.Rule as Rule exposing (Rule) import Review.Rule as Rule exposing (Rule)
import Review.FilePattern as FilePattern
import NoUnused.CustomTypeConstructorArgs import NoUnused.CustomTypeConstructorArgs
import Css.NoUnknownClasses import Css.NoUnknownClasses
@ -73,7 +74,7 @@ config =
, NoSimpleLetBody.rule , NoSimpleLetBody.rule
, NoPrematureLetComputation.rule , NoPrematureLetComputation.rule
, NoForbiddenWords.rule [ "REPLACEME" ] , NoForbiddenWords.rule [ "REPLACEME" ]
, Css.NoUnknownClasses.cssFiles ["src/**/*.css"] , Css.NoUnknownClasses.cssFiles [ FilePattern.include "src/**/*.css"]
-- |> Css.NoUnknownClasses.withCssUsingFunctions cssUsingFunctions -- |> Css.NoUnknownClasses.withCssUsingFunctions cssUsingFunctions
|> Css.NoUnknownClasses.rule |> Css.NoUnknownClasses.rule
] ]

5
tests/Css/NoUnknownClasses.elm
View File

@ -145,6 +145,7 @@ import Elm.Syntax.Range exposing (Range)
import Levenshtein import Levenshtein
import Parser exposing ((|.), (|=), Parser) import Parser exposing ((|.), (|=), Parser)
import RangeDict exposing (RangeDict) import RangeDict exposing (RangeDict)
import Review.FilePattern exposing (FilePattern)
import Review.ModuleNameLookupTable as ModuleNameLookupTable exposing (ModuleNameLookupTable) import Review.ModuleNameLookupTable as ModuleNameLookupTable exposing (ModuleNameLookupTable)
import Review.Rule as Rule exposing (Rule) import Review.Rule as Rule exposing (Rule)
import Set exposing (Set) import Set exposing (Set)
@ -166,12 +167,12 @@ rule (Configuration configuration) =
type Configuration type Configuration
= Configuration = Configuration
{ knownClasses : Set String { knownClasses : Set String
, cssFiles : List String , cssFiles : List FilePattern
, cssFunctions : CssFunctions , cssFunctions : CssFunctions
} }
cssFiles : List String -> Configuration cssFiles : List FilePattern -> Configuration
cssFiles globs = cssFiles globs =
Configuration Configuration
{ knownClasses = Set.empty { knownClasses = Set.empty

43
tests/Css/NoUnknownClassesTest.elm
View File

@ -4,6 +4,7 @@ import Css.ClassFunction as ClassFunction exposing (CssArgument, fromLiteral)
import Css.NoUnknownClasses exposing (addKnownClasses, cssFiles, rule, withCssUsingFunctions) import Css.NoUnknownClasses exposing (addKnownClasses, cssFiles, rule, withCssUsingFunctions)
import Elm.Syntax.Expression exposing (Expression) import Elm.Syntax.Expression exposing (Expression)
import Elm.Syntax.Node exposing (Node) import Elm.Syntax.Node exposing (Node)
import Review.FilePattern as FilePattern exposing (FilePattern)
import Review.Project as Project exposing (Project) import Review.Project as Project exposing (Project)
import Review.Test import Review.Test
import Review.Test.Dependencies import Review.Test.Dependencies
@ -22,7 +23,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [] [ Html.text "ok" ] Html.span [] [ Html.text "ok" ]
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering an unknown CSS class through Html.Attributes.class" <| , test "should report an error when encountering an unknown CSS class through Html.Attributes.class" <|
\() -> \() ->
@ -33,7 +34,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class "unknown" ] [] Html.span [ Attr.class "unknown" ] []
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known", "bar", "unknown2" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known", "bar", "unknown2" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -53,7 +54,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class "known" ] [] Html.span [ Attr.class "known" ] []
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering an unknown CSS class through Html.Attributes.class in <| pipe" <| , test "should report an error when encountering an unknown CSS class through Html.Attributes.class in <| pipe" <|
\() -> \() ->
@ -64,7 +65,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class <| "unknown" ] [] Html.span [ Attr.class <| "unknown" ] []
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -81,7 +82,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ "unknown" |> Attr.class ] [] Html.span [ "unknown" |> Attr.class ] []
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -98,7 +99,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ "known red-faint under_score" |> Attr.class ] [] Html.span [ "known red-faint under_score" |> Attr.class ] []
""" """
|> Review.Test.runWithProjectData projectWithCssClasses (cssFiles [ "*.css" ] |> rule) |> Review.Test.runWithProjectData projectWithCssClasses (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering a non-literal argument for Html.Attributes.class" <| , test "should report an error when encountering a non-literal argument for Html.Attributes.class" <|
\() -> \() ->
@ -109,7 +110,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.class model.class Attr.class model.class
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -126,7 +127,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.classList model.classList Attr.classList model.classList
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -146,7 +147,7 @@ view model =
, ( variable, model.b ) , ( variable, model.b )
] ]
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -163,7 +164,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.attribute "class" model.class Attr.attribute "class" model.class
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -180,7 +181,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.attribute "class" "known" Attr.attribute "class" "known"
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should not report an error when Html.Attributes.attribute is used with something else than \"class\"" <| , test "should not report an error when Html.Attributes.attribute is used with something else than \"class\"" <|
\() -> \() ->
@ -191,7 +192,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.attribute "id" model.id Attr.attribute "id" model.id
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should not report an error when Html.Attributes.attribute is used with a non-literal attribute name" <| , test "should not report an error when Html.Attributes.attribute is used with a non-literal attribute name" <|
\() -> \() ->
@ -202,7 +203,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.attribute name model.name Attr.attribute name model.name
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should not report an error when encountering a literal CSS class with a custom CSS function" <| , test "should not report an error when encountering a literal CSS class with a custom CSS function" <|
\() -> \() ->
@ -213,7 +214,7 @@ view model =
Class.fromString "known" Class.fromString "known"
""" """
|> Review.Test.run |> Review.Test.run
(cssFiles [ "*.css" ] (cssFiles [ FilePattern.include "*.css" ]
|> addKnownClasses [ "known" ] |> addKnownClasses [ "known" ]
|> withCssUsingFunctions [ ( "Class.fromString", classFromAttrFunction ) ] |> withCssUsingFunctions [ ( "Class.fromString", classFromAttrFunction ) ]
|> rule |> rule
@ -228,7 +229,7 @@ view model =
Class.fromString model.a Class.fromString model.a
""" """
|> Review.Test.run |> Review.Test.run
(cssFiles [ "*.css" ] (cssFiles [ FilePattern.include "*.css" ]
|> addKnownClasses [ "known" ] |> addKnownClasses [ "known" ]
|> withCssUsingFunctions [ ( "Class.fromString", classFromAttrFunction ) ] |> withCssUsingFunctions [ ( "Class.fromString", classFromAttrFunction ) ]
|> rule |> rule
@ -248,7 +249,7 @@ import Html.Attributes
classListWithoutErrorsBeingReported = classListWithoutErrorsBeingReported =
Html.Attributes.classList Html.Attributes.classList
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Class using function is used without arguments" { message = "Class using function is used without arguments"
@ -264,7 +265,7 @@ import Html.Attributes
classFunctionWithoutErrorsBeingReported = classFunctionWithoutErrorsBeingReported =
Html.Attributes.attribute "class" Html.Attributes.attribute "class"
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Class using function is used without all of its CSS class arguments" { message = "Class using function is used without all of its CSS class arguments"
@ -280,7 +281,7 @@ import Class
view model = view model =
Class.fromString model.a Class.fromString model.a
""" """
|> Review.Test.runWithProjectData projectWithUnparsableCssClasses (cssFiles [ "*.css" ] |> rule) |> Review.Test.runWithProjectData projectWithUnparsableCssClasses (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrorsForModules |> Review.Test.expectErrorsForModules
[ ( "some-file.css" [ ( "some-file.css"
, [ Review.Test.error , [ Review.Test.error
@ -299,7 +300,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.class <| if model.condition then "a" else "b" Attr.class <| if model.condition then "a" else "b"
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -315,7 +316,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.class <| if model.condition then "known" else nonLiteral Attr.class <| if model.condition then "known" else nonLiteral
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> withCssUsingFunctions [ ( "Html.Attributes.class", ClassFunction.smartFirstArgumentIsClass ) ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> withCssUsingFunctions [ ( "Html.Attributes.class", ClassFunction.smartFirstArgumentIsClass ) ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -334,7 +335,7 @@ view model =
A -> "known" A -> "known"
B -> nonLiteral B -> nonLiteral
""" """
|> Review.Test.run (cssFiles [ "*.css" ] |> addKnownClasses [ "known" ] |> withCssUsingFunctions [ ( "Html.Attributes.class", ClassFunction.smartFirstArgumentIsClass ) ] |> rule) |> Review.Test.run (cssFiles [ FilePattern.include "*.css" ] |> addKnownClasses [ "known" ] |> withCssUsingFunctions [ ( "Html.Attributes.class", ClassFunction.smartFirstArgumentIsClass ) ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"