jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-25 10:41:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

Do not visit and discover expressions if there is no expression visitor

Browse Source
This commit is contained in:
Jeroen Engels 2020-01-20 08:45:01 +01:00
parent d2f2ffa2cd
commit 11d8c925b2
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Review/Rule.elm
View File

@ -1894,9 +1894,20 @@ visitDeclaration :
-> context
-> ( List Error, context )
visitDeclaration declarationVisitors expressionVisitors node context =
let
accumulateExpressionNodes : ( List Error, context ) -> ( List Error, context )
accumulateExpressionNodes =
if List.isEmpty expressionVisitors.onEnter then
identity
else
accumulateList
(visitExpression expressionVisitors)
(expressionsInDeclaration node)
in
( [], context )
|> visitNodeWithListOfVisitorsAndDirection OnEnter declarationVisitors.onEnter node
|> accumulateList (visitExpression expressionVisitors) (expressionsInDeclaration node)
|> accumulateExpressionNodes
|> visitNodeWithListOfVisitorsAndDirection OnExit declarationVisitors.onExit node