jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-26 03:04:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Do not fail with missing sources if there are modules added through the project

Browse Source
This commit is contained in:
Jeroen Engels 2020-04-08 16:31:04 +02:00
parent 591896492c
commit 17c9c0e30f
1 changed files with 31 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
src/Review/Test.elm
View File

@ -322,39 +322,39 @@ interested in project related details, then you should use [`runOnModules`](#run
-}
runOnModulesWithProjectData : Project -> Rule -> List String -> ReviewResult
runOnModulesWithProjectData project rule sources =
if List.isEmpty sources then
FailedRun ErrorMessage.missingSources
else
let
projectWithModules : Project
projectWithModules =
sources
|> List.indexedMap
(\index source ->
{ path = "TestContent_" ++ String.fromInt index ++ ".elm"
, source = source
}
)
|> List.foldl Project.addModule project
in
case Project.modulesThatFailedToParse projectWithModules of
{ source } :: _ ->
let
fileAndIndex : { source : String, index : Int }
fileAndIndex =
{ source = source
, index = indexOf source sources |> Maybe.withDefault -1
let
projectWithModules : Project
projectWithModules =
sources
|> List.indexedMap
(\index source ->
{ path = "TestContent_" ++ String.fromInt index ++ ".elm"
, source = source
}
in
FailedRun <| ErrorMessage.parsingFailure (List.length sources == 1) fileAndIndex
)
|> List.foldl Project.addModule project
in
case Project.modulesThatFailedToParse projectWithModules of
{ source } :: _ ->
let
fileAndIndex : { source : String, index : Int }
fileAndIndex =
{ source = source
, index = indexOf source sources |> Maybe.withDefault -1
}
in
FailedRun <| ErrorMessage.parsingFailure (List.length sources == 1) fileAndIndex
[] ->
let
modules : List ProjectModule
modules =
Project.modules projectWithModules
in
[] ->
let
modules : List ProjectModule
modules =
Project.modules projectWithModules
in
if List.isEmpty modules then
FailedRun ErrorMessage.missingSources
else
case findDuplicateModuleNames Set.empty modules of
Just moduleName ->
FailedRun <| ErrorMessage.duplicateModuleName moduleName