jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-08-16 19:40:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Apply simplifications

Browse Source
This commit is contained in:
Jeroen Engels 2023-06-26 22:06:21 +02:00
parent fceaaf33e2
commit 1db1a05c69
2 changed files with 25 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/NoInconsistentAliases/Visitor.elm
View File

@ -83,9 +83,11 @@ rememberBadAlias { lookupAlias, canMissAliases } (Node moduleNameRange moduleNam
moduleCallVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module ) moduleCallVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module )
moduleCallVisitor node context = moduleCallVisitor node context =
case Node.value node of let
( moduleName, function ) -> ( moduleName, function ) =
( [], Context.addModuleCall moduleName function (Node.range node) context ) Node.value node
in
( [], Context.addModuleCall moduleName function (Node.range node) context )
finalEvaluation : Options.AliasLookup -> Context.Module -> List (Error {}) finalEvaluation : Options.AliasLookup -> Context.Module -> List (Error {})

36
tests/NoModuleOnExposedNames.elm
View File

@ -124,28 +124,32 @@ rememberExposedNames { moduleName, moduleAlias, exposingList } context =
valueVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module ) valueVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module )
valueVisitor node context = valueVisitor node context =
case Node.value node of let
( moduleName, name ) -> ( moduleName, name ) =
if Context.isFunctionExposed context moduleName name then Node.value node
( [ moduleOnExposedValueError name (Node.range node) ] in
, context if Context.isFunctionExposed context moduleName name then
) ( [ moduleOnExposedValueError name (Node.range node) ]
, context
)
else else
( [], context ) ( [], context )
typeVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module ) typeVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module )
typeVisitor node context = typeVisitor node context =
case Node.value node of let
( moduleName, name ) -> ( moduleName, name ) =
if Context.isTypeExposed context moduleName name then Node.value node
( [ moduleOnExposedTypeError name (Node.range node) ] in
, context if Context.isTypeExposed context moduleName name then
) ( [ moduleOnExposedTypeError name (Node.range node) ]
, context
)
else else
( [], context ) ( [], context )
moduleOnExposedValueError : String -> Range -> Error {} moduleOnExposedValueError : String -> Range -> Error {}