Add Review.Test.expectGlobalErrors function

This commit is contained in:
Jeroen Engels 2021-03-01 22:25:29 +01:00
parent 68ddcec986
commit 22f68ab542
2 changed files with 8 additions and 2 deletions

View File

@ -1,6 +1,7 @@
module Review.Test exposing
( ReviewResult, run, runWithProjectData, runOnModules, runOnModulesWithProjectData
, ExpectedError, expectNoErrors, expectErrors, error, atExactly, whenFixed, expectErrorsForModules, expectErrorsForElmJson, expectErrorsForReadme
, expectGlobalErrors
)
{-| Module that helps you test your rules, using [`elm-test`](https://package.elm-lang.org/packages/elm-explorations/test/latest/).
@ -668,7 +669,7 @@ expectErrorsForModules expectedErrorsList reviewResult =
maybeUnknownModule =
Set.diff
(expectedErrorsList |> List.map Tuple.first |> Set.fromList)
(runResults |> List.map .moduleName |> Set.fromList)
(Set.fromList ("GLOBAL ERROR" :: List.map .moduleName runResults))
|> Set.toList
|> List.head
in
@ -731,6 +732,11 @@ expectErrorsForElmJson expectedErrors reviewResult =
expectErrorsForModules [ ( "elm.json", expectedErrors ) ] reviewResult
expectGlobalErrors : List ExpectedError -> ReviewResult -> Expectation
expectGlobalErrors expectedErrors reviewResult =
expectErrorsForModules [ ( "GLOBAL ERROR", expectedErrors ) ] reviewResult
{-| Assert that the rule reported some errors for the `README.md` file, by specifying which ones.
test "report an error when a module is unused" <|

View File

@ -165,7 +165,7 @@ import SomeModule.Regex
a = SomeModule.Regex.fromLiteralFunc "^abc$"
"""
|> Review.Test.runWithProjectData project (rule configuration)
|> Review.Test.expectErrorsForElmJson
|> Review.Test.expectGlobalErrors
[ Review.Test.error
{ message = "Could not find SomeModule.Regex"
, details =