jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-20 04:27:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Split expectErrorsForModules into 2 functions

Browse Source
This commit is contained in:
Jeroen Engels 2021-03-06 23:49:40 +01:00
parent 9717bf7774
commit 2aafccea23
1 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/Review/Test.elm
View File

@ -707,23 +707,28 @@ expectErrorsForModules expectedErrorsList reviewResult =
Expect.fail errorMessage Expect.fail errorMessage
SuccessfulRun _ {- TODO -} runResults -> SuccessfulRun _ {- TODO -} runResults ->
let expectErrorsForModulesHelp expectedErrorsList runResults
maybeUnknownModule : Maybe String
maybeUnknownModule =
Set.diff
(expectedErrorsList |> List.map Tuple.first |> Set.fromList)
(Set.fromList (List.map .moduleName runResults))
|> Set.toList
|> List.head
in
case maybeUnknownModule of
Just unknownModule ->
FailureMessage.unknownModulesInExpectedErrors unknownModule
|> Expect.fail
Nothing ->
expectErrorsForModuleFiles expectedErrorsList runResults expectErrorsForModulesHelp : List ( String, List ExpectedError ) -> List SuccessfulRunResult -> Expectation
|> (\expectations -> Expect.all expectations ()) expectErrorsForModulesHelp expectedErrorsList runResults =
let
maybeUnknownModule : Maybe String
maybeUnknownModule =
Set.diff
(expectedErrorsList |> List.map Tuple.first |> Set.fromList)
(Set.fromList (List.map .moduleName runResults))
|> Set.toList
|> List.head
in
case maybeUnknownModule of
Just unknownModule ->
FailureMessage.unknownModulesInExpectedErrors unknownModule
|> Expect.fail
Nothing ->
expectErrorsForModuleFiles expectedErrorsList runResults
|> (\expectations -> Expect.all expectations ())
expectErrorsForModuleFiles : List ( String, List ExpectedError ) -> List SuccessfulRunResult -> List (() -> Expectation) expectErrorsForModuleFiles : List ( String, List ExpectedError ) -> List SuccessfulRunResult -> List (() -> Expectation)