jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-23 09:42:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

Speed up collection modules names from patterns

Browse Source
This commit is contained in:
Jeroen Engels 2022-09-17 18:30:14 +02:00
parent 313e8e26da
commit 2c6ddeacb8
1 changed files with 40 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/Review/Rule.elm
View File

@ -6305,10 +6305,7 @@ scope_declarationEnterVisitor node context =
moduleNamesFromArguments : List ( Range, ModuleName ) moduleNamesFromArguments : List ( Range, ModuleName )
moduleNamesFromArguments = moduleNamesFromArguments =
function.declaration collectModuleNamesFromPattern newContext (Node.value function.declaration).arguments []
|> Node.value
|> .arguments
|> ListExtra.orderIndependentConcatMap (collectModuleNamesFromPattern newContext)
newModuleNames : List ( Range, ModuleName ) newModuleNames : List ( Range, ModuleName )
newModuleNames = newModuleNames =
@ -6442,39 +6439,34 @@ collectNamesFromPattern variableType patternsToVisit acc =
acc acc
collectModuleNamesFromPattern : ScopeModuleContext -> Node Pattern -> List ( Range, ModuleName ) collectModuleNamesFromPattern : ScopeModuleContext -> List (Node Pattern) -> List ( Range, ModuleName ) -> List ( Range, ModuleName )
collectModuleNamesFromPattern context pattern = collectModuleNamesFromPattern context patternsToVisit acc =
collectModuleNamesFromPatternHelp context [ pattern ] []
collectModuleNamesFromPatternHelp : ScopeModuleContext -> List (Node Pattern) -> List ( Range, ModuleName ) -> List ( Range, ModuleName )
collectModuleNamesFromPatternHelp context patternsToVisit acc =
case patternsToVisit of case patternsToVisit of
pattern :: restOfPatternsToVisit -> pattern :: restOfPatternsToVisit ->
case Node.value pattern of case Node.value pattern of
Pattern.NamedPattern { moduleName, name } subPatterns -> Pattern.NamedPattern { moduleName, name } subPatterns ->
collectModuleNamesFromPatternHelp collectModuleNamesFromPattern
context context
(ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit) (ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit)
(( Node.range pattern, moduleNameForValue context name moduleName ) :: acc) (( Node.range pattern, moduleNameForValue context name moduleName ) :: acc)
Pattern.UnConsPattern left right -> Pattern.UnConsPattern left right ->
collectModuleNamesFromPatternHelp context (left :: right :: restOfPatternsToVisit) acc collectModuleNamesFromPattern context (left :: right :: restOfPatternsToVisit) acc
Pattern.TuplePattern subPatterns -> Pattern.TuplePattern subPatterns ->
collectModuleNamesFromPatternHelp context (ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit) acc collectModuleNamesFromPattern context (ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit) acc
Pattern.ParenthesizedPattern subPattern -> Pattern.ParenthesizedPattern subPattern ->
collectModuleNamesFromPatternHelp context (subPattern :: restOfPatternsToVisit) acc collectModuleNamesFromPattern context (subPattern :: restOfPatternsToVisit) acc
Pattern.AsPattern subPattern _ -> Pattern.AsPattern subPattern _ ->
collectModuleNamesFromPatternHelp context (subPattern :: restOfPatternsToVisit) acc collectModuleNamesFromPattern context (subPattern :: restOfPatternsToVisit) acc
Pattern.ListPattern subPatterns -> Pattern.ListPattern subPatterns ->
collectModuleNamesFromPatternHelp context (ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit) acc collectModuleNamesFromPattern context (ListExtra.orderIndependentAppend subPatterns restOfPatternsToVisit) acc
_ -> _ ->
collectModuleNamesFromPatternHelp context restOfPatternsToVisit acc collectModuleNamesFromPattern context restOfPatternsToVisit acc
[] -> [] ->
acc acc
@ -6546,18 +6538,16 @@ scope_expressionEnterVisitor node context =
moduleNames : List ( Range, ModuleName ) moduleNames : List ( Range, ModuleName )
moduleNames = moduleNames =
declarations List.foldl
|> ListExtra.fastConcatMap (\declaration acc ->
(\declaration ->
case Node.value declaration of case Node.value declaration of
Expression.LetFunction function -> Expression.LetFunction function ->
let let
declarationModuleNames : List ( Range, ModuleName ) declarationModuleNames : List ( Range, ModuleName )
declarationModuleNames = declarationModuleNames =
function.declaration collectModuleNamesFromPattern newContext
|> Node.value (Node.value function.declaration).arguments
|> .arguments acc
|> ListExtra.fastConcatMap (collectModuleNamesFromPattern newContext)
in in
case function.signature of case function.signature of
Just signature -> Just signature ->
@ -6570,8 +6560,10 @@ scope_expressionEnterVisitor node context =
declarationModuleNames declarationModuleNames
Expression.LetDestructuring pattern _ -> Expression.LetDestructuring pattern _ ->
collectModuleNamesFromPattern newContext pattern collectModuleNamesFromPattern newContext [ pattern ] acc
) )
[]
declarations
in in
{ newContext | lookupTable = ModuleNameLookupTableInternal.addMultiple moduleNames newContext.lookupTable } { newContext | lookupTable = ModuleNameLookupTableInternal.addMultiple moduleNames newContext.lookupTable }
@ -6589,8 +6581,11 @@ scope_expressionEnterVisitor node context =
moduleNames : List ( Range, ModuleName ) moduleNames : List ( Range, ModuleName )
moduleNames = moduleNames =
ListExtra.fastConcatMap List.foldl
(\( pattern, _ ) -> collectModuleNamesFromPattern context pattern) (\( pattern, _ ) acc ->
collectModuleNamesFromPattern context [ pattern ] acc
)
[]
caseBlock.cases caseBlock.cases
in in
{ context { context
@ -6620,7 +6615,7 @@ scope_expressionEnterVisitor node context =
{ context { context
| lookupTable = | lookupTable =
ModuleNameLookupTableInternal.addMultiple ModuleNameLookupTableInternal.addMultiple
(ListExtra.fastConcatMap (collectModuleNamesFromPattern context) args) (collectModuleNamesFromPattern context args [])
context.lookupTable context.lookupTable
} }