jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-25 10:41:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix error being reported for their module instead of the external file

Browse Source
This commit is contained in:
Jeroen Engels 2020-02-11 23:16:20 +01:00
parent 3d1001d5d2
commit 3621447a82
1 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/Review/Rule.elm
View File

@ -550,7 +550,7 @@ computeErrors (ModuleRuleSchema schema) project initialContext =
|> accumulateWithListOfVisitors schema.declarationListVisitors module_.ast.declarations
|> accumulateList (visitDeclaration declarationVisitors expressionVisitors) module_.ast.declarations
|> makeFinalEvaluation schema.finalEvaluationFns
|> List.map (\(Error err) -> Error { err | ruleName = schema.name, filePath = module_.path })
|> List.map (setRuleName schema.name >> setFilePathIfUnset module_)
|> List.reverse
@ -771,7 +771,7 @@ traverseAllModulesInParallel (ProjectRuleSchema schema) startCache project =
module_
in
{ source = module_.source
, errors = List.map (\(Error err) -> Error { err | filePath = module_.path }) fileErrors
, errors = List.map (setFilePathIfUnset module_) fileErrors
, context =
schema.context.fromModuleToProject
fileKey
@ -812,7 +812,7 @@ traverseAllModulesInParallel (ProjectRuleSchema schema) startCache project =
|> List.map Tuple.second
|> List.foldl schema.context.foldProjectContexts initialContext
|> makeFinalEvaluationForProject schema.finalEvaluationFns
|> List.map (\(Error err) -> Error { err | ruleName = schema.name })
|> List.map (setRuleName schema.name)
]
in
( errors, Rule schema.name (runProjectRule (ProjectRuleSchema schema) newCache) )
@ -891,7 +891,7 @@ traverseImportedModulesFirst (ProjectRuleSchema schema) startCache project =
module_
in
{ source = module_.source
, errors = List.map (\(Error err) -> Error { err | filePath = module_.path }) fileErrors
, errors = List.map (setFilePathIfUnset module_) fileErrors
, context =
schema.context.fromModuleToProject
fileKey
@ -929,7 +929,7 @@ traverseImportedModulesFirst (ProjectRuleSchema schema) startCache project =
|> List.map Tuple.second
|> List.foldl schema.context.foldProjectContexts initialContext
|> makeFinalEvaluationForProject schema.finalEvaluationFns
|> List.map (\(Error err) -> Error { err | ruleName = schema.name })
|> List.map (setRuleName schema.name)
]
in
( errors, Rule schema.name (runProjectRule (ProjectRuleSchema schema) newCache) )
@ -939,6 +939,25 @@ traverseImportedModulesFirst (ProjectRuleSchema schema) startCache project =
( [], Rule schema.name (runProjectRule (ProjectRuleSchema schema) startCache) )
setRuleName : String -> Error -> Error
setRuleName ruleName (Error err) =
Error { err | ruleName = ruleName }
setFilePathIfUnset : ProjectModule -> Error -> Error
setFilePathIfUnset module_ (Error err) =
Error
{ err
| filePath =
case err.filePath of
"" ->
module_.path
_ ->
err.filePath
}
computeModuleAndCacheResult :
Dict ModuleName ProjectModule
-> Graph ModuleName ()