Add FindNoAnnotatedFunction rule

Lint.elm

@@ -29,28 +29,28 @@ doNothing ctx _ =
     ( [], ctx )
 
 
-visitExpression : Expression -> Visitor context
+expressionVisitor : Expression -> Visitor context
-visitExpression node rule context =
+expressionVisitor node rule context =
     rule.expressionFn context node
 
 
-visitType : Type -> Visitor context
+typeVisitor : Type -> Visitor context
-visitType node rule context =
+typeVisitor node rule context =
     rule.typeFn context node
 
 
-visitStatement : Statement -> Visitor context
+statementVisitor : Statement -> Visitor context
-visitStatement node rule context =
+statementVisitor node rule context =
     rule.statementFn context node
 
 
-transformExpression : Expression -> List (Visitor context)
+expressionToVisitors : Expression -> List (Visitor context)
-transformExpression node =
+expressionToVisitors node =
     let
         visitAndTransformChildren children =
             List.concat
-                [ [ visitExpression node ]
+                [ [ expressionVisitor node ]
-                , List.concatMap transformExpression children
+                , List.concatMap expressionToVisitors children
                 ]
     in
         case node of
@@ -61,25 +61,25 @@ transformExpression node =
                 visitAndTransformChildren [ expression ]
 
             Variable _ ->
-                [ visitExpression node ]
+                [ expressionVisitor node ]
 
             _ ->
                 []
 
 
-transformType : Type -> List (Visitor context)
+typeToVisitors : Type -> List (Visitor context)
-transformType node =
+typeToVisitors node =
     []
 
 
-transformStatement : Statement -> List (Visitor context)
+statementToVisitors : Statement -> List (Visitor context)
-transformStatement node =
+statementToVisitors node =
     let
         visitAndTransformChildren expresssions types =
             List.concat
-                [ [ visitStatement node ]
+                [ [ statementVisitor node ]
-                , List.concatMap transformExpression expresssions
+                , List.concatMap expressionToVisitors expresssions
-                , List.concatMap transformType types
+                , List.concatMap typeToVisitors types
                 ]
     in
         case node of
@@ -93,16 +93,11 @@ transformStatement node =
                 []
 
 
-transform : List Statement -> List (Visitor context)
-transform statements =
-    List.concatMap transformStatement statements
-
-
 lint : List Statement -> LintRule context -> List Error
 lint statements rule =
     let
-        validators =
+        visitors =
-            transform statements
+            List.concatMap statementToVisitors statements
 
         ( errors, _ ) =
             List.foldl
@@ -114,6 +109,6 @@ lint statements rule =
                         ( errors ++ errors_, ctx_ )
                 )
                 ( [], rule.context )
-                validators
+                visitors
     in
         errors

example/Main.elm

@@ -10,6 +10,7 @@ import Html.Events exposing (..)
 import Json.Decode as JD
 import Lint
 import NoDebug
+import FindNoAnnotatedFunction
 
 
 type Msg
@@ -100,7 +101,10 @@ lint ast =
                 |> Result.withDefault []
 
         errors =
-            Lint.lint statements NoDebug.rule
+            List.concat
+                [ Lint.lint statements FindNoAnnotatedFunction.rule
+                , Lint.lint statements NoDebug.rule
+                ]
     in
         div [] (List.map (\x -> p [] [ text x ]) errors)
 

rules/FindNoAnnotatedFunction.elm

@@ -0,0 +1,34 @@
+module FindNoAnnotatedFunction exposing (rule)
+
+import Lint exposing (LintRule, Error, doNothing)
+import Ast.Statement exposing (..)
+
+
+type alias Context =
+    { annotatedFunctions : List String
+    }
+
+
+rule : LintRule Context
+rule =
+    { statementFn = statementFn
+    , typeFn = doNothing
+    , expressionFn = doNothing
+    , context = Context []
+    }
+
+
+statementFn : Context -> Statement -> ( List Error, Context )
+statementFn ctx node =
+    case node of
+        FunctionTypeDeclaration name application ->
+            ( [], { ctx | annotatedFunctions = name :: ctx.annotatedFunctions } )
+
+        FunctionDeclaration name params body ->
+            if List.member name ctx.annotatedFunctions then
+                ( [], ctx )
+            else
+                ( [ "`" ++ name ++ "` does not have a type declaration" ], ctx )
+
+        _ ->
+            ( [], ctx )