jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-11 16:16:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

Inline findUnreleasedRange

Browse Source
This commit is contained in:
Jeroen Engels 2023-06-03 21:19:15 +02:00
parent ce66fafdfe
commit 500923da91
1 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/Docs/NoMissingChangelogEntry.elm
View File

@ -178,24 +178,24 @@ reportError fileKey elmJsonVersion content =
lines =
String.lines content
unreleasedRange : Maybe Range
unreleasedRange =
findUnreleasedRange lines
unreleased : Maybe ( Int, String )
unreleased =
findLineWithUnreleased 0 lines
in
Rule.errorForExtraFileWithFix
fileKey
{ message = "Missing entry in CHANGELOG.md for version " ++ elmJsonVersion
, details = [ "It seems you have or are ready to release a new version of your package, but forgot to include releases notes for it in your CHANGELOG.md file." ]
}
(case unreleasedRange of
Just range ->
range
(case unreleased of
Just ( lineNumber, line ) ->
{ start = { row = lineNumber, column = 1 }, end = { row = lineNumber, column = String.length line + 1 } }
Nothing ->
{ start = { row = 1, column = 1 }, end = { row = 1, column = String.length (List.head lines |> Maybe.withDefault "") + 1 } }
)
(case unreleasedRange of
Just range ->
(case unreleased of
Just ( lineNumber, _ ) ->
[]
Nothing ->
@ -203,16 +203,6 @@ reportError fileKey elmJsonVersion content =
)
findUnreleasedRange : List String -> Maybe Range
findUnreleasedRange lines =
case findLineWithUnreleased 0 lines of
Just ( lineNumber, line ) ->
Just { start = { row = lineNumber, column = 1 }, end = { row = lineNumber, column = String.length line + 1 } }
Nothing ->
Nothing
findLineWithUnreleased : Int -> List String -> Maybe ( Int, String )
findLineWithUnreleased index lines =
case lines of