Improve error when expecting errors for extra file but it's missing

This commit is contained in:
Jeroen Engels 2024-05-07 23:40:42 +02:00
parent 469a064223
commit 50c7173fd8
2 changed files with 19 additions and 21 deletions

View File

@ -548,25 +548,20 @@ readmeRunResult errors project =
extraFileRunResult : List ReviewError -> Project -> List SuccessfulRunResult
extraFileRunResult errors project =
let
extraFilePaths : Dict String String
extraFilePaths =
Project.extraFiles project
errorsPerFile_ : Dict String (List ReviewError)
errorsPerFile_ =
errorsPerFile errors
in
Dict.foldl
(\path errorsForFile acc ->
case Dict.get path extraFilePaths of
Just content ->
(\path content acc ->
{ moduleName = path
, inspector = codeInspectorForSource False content
, errors = errorsForFile
, errors = Dict.get path errorsPerFile_ |> Maybe.withDefault []
}
:: acc
Nothing ->
acc
)
[]
(errorsPerFile errors)
(Project.extraFiles project)
errorsPerFile : List ReviewError -> Dict String (List ReviewError)

View File

@ -80,8 +80,9 @@ import C
a = 1
"""
|> Review.Test.runWithProjectData project rule
|> Review.Test.expectErrors
[ Review.Test.error
|> Review.Test.expectErrorsForModules
[ ( "A"
, [ Review.Test.error
{ message = """
0 - initial context
1.1 - withElmJsonModuleVisitor
@ -118,6 +119,8 @@ a = 1
, under = "module"
}
]
)
]
, test "should call the same type of visitors in order of call on enter, and reverse order on exit (expression)" <|
\() ->
let