jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Explain why we require providing the fix result in test error messages

Browse Source
This commit is contained in:
Jeroen Engels 2019-08-22 11:57:14 +02:00
parent 3a05b37fd3
commit 5433526b2f
2 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Lint/Test/ErrorMessage.elm
View File

@ -246,9 +246,18 @@ I expected that the error with the following message
would not have any fixes, but it provided some.
Hint: You may have forgotten to call `Lint.Test.whenFixed`
It's probable that you either forgot to call `Rule.withFixes` on the
error that you created, or that the list of provided fixes was empty."""
Because the error provides fixes, I require providing the expected result
of the automatic fix. Otherwise, there is no way to know whether the fix
will result in a correct and in the intended result.
To fix this, you can call `Lint.Test.whenFixed` on your error:
Lint.Test.error
{ message = "<message>"
, details = "<details>"
, under = "<under>"
}
|> Lint.Test.whenFixed "<source code>\""""
fixedCodeMismatch : SourceCode -> SourceCode -> Error -> String

16
tests/ErrorMessageTest.elm
View File

@ -641,9 +641,19 @@ I expected that the error with the following message
would not have any fixes, but it provided some.
Hint: You may have forgotten to call `Lint.Test.whenFixed`
It's probable that you either forgot to call `Rule.withFixes` on the
error that you created, or that the list of provided fixes was empty."""
Because the error provides fixes, I require providing the expected result
of the automatic fix. Otherwise, there is no way to know whether the fix
will result in a correct and in the intended result.
To fix this, you can call `Lint.Test.whenFixed` on your error:
Lint.Test.error
{ message = "<message>"
, details = "<details>"
, under = "<under>"
}
|> Lint.Test.whenFixed "<source code>"
"""
fixedCodeMismatchTest : Test