From 55bc0d723f7378536acde8a5c9a3c5f8b3320be3 Mon Sep 17 00:00:00 2001
From: Jeroen Engels <jfm.engels@gmail.com>
Date: Tue, 8 Oct 2024 17:37:31 +0200
Subject: [PATCH] Fix source code extraction when dealing with Unicode
 characters

---
 CHANGELOG.md                          |  2 +
 src/Review/Rule.elm                   | 56 ++++++++++++++++++++-------
 tests/NoNegationInIfConditionTest.elm | 24 ++++++++++++
 3 files changed, 67 insertions(+), 15 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index d5fa9116..a51feb92 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## [Unreleased]
 
+- Fixed an issue where extracting code using `Review.Rule.withSourceCodeExtractor` would not get the correct source code when source contains Unicode characters.
+
 ## [2.14.0] - 2024-06-14
 
 Support new visitors that visit "extra files".
diff --git a/src/Review/Rule.elm b/src/Review/Rule.elm
index 364d5e4c..959023bf 100644
--- a/src/Review/Rule.elm
+++ b/src/Review/Rule.elm
@@ -344,6 +344,7 @@ import Review.Project.InvalidProjectError as InvalidProjectError
 import Review.Project.ProjectModule as ProjectModule exposing (OpaqueProjectModule)
 import Review.Project.Valid as ValidProject exposing (ValidProject)
 import Review.RequestedData as RequestedData exposing (RequestedData(..))
+import Unicode
 import Vendor.Graph as Graph exposing (Graph)
 import Vendor.IntDict as IntDict
 import Vendor.Zipper as Zipper exposing (Zipper)
@@ -5958,23 +5959,48 @@ visitCaseBranch caseBlockWithRange (( _, caseExpression ) as caseBranch) rules =
 
 
 extractSourceCode : List String -> Range -> String
-extractSourceCode lines range =
-    lines
-        |> List.drop (range.start.row - 1)
-        |> List.take (range.end.row - range.start.row + 1)
-        |> mapLast (String.slice 0 (range.end.column - 1))
-        |> String.join "\n"
-        |> String.dropLeft (range.start.column - 1)
-
-
-mapLast : (a -> a) -> List a -> List a
-mapLast mapper lines =
-    case List.reverse lines of
+extractSourceCode lines { start, end } =
+    case List.drop (start.row - 1) lines of
         [] ->
-            lines
+            ""
 
-        first :: rest ->
-            List.reverse (mapper first :: rest)
+        firstLine :: rest ->
+            if start.row == end.row then
+                Unicode.slice
+                    (start.column - 1)
+                    (end.column - 1)
+                    firstLine
+
+            else
+                let
+                    { linesTaken, lastLine } =
+                        takeNLines (end.row - start.row - 1) rest ""
+                in
+                Unicode.dropLeft (start.column - 1) firstLine
+                    ++ linesTaken
+                    ++ (case lastLine of
+                            Just lastLine_ ->
+                                "\n" ++ Unicode.left (end.column - 1) lastLine_
+
+                            Nothing ->
+                                ""
+                       )
+
+
+takeNLines : Int -> List String -> String -> { linesTaken : String, lastLine : Maybe String }
+takeNLines n lines linesTaken =
+    if n <= 0 then
+        { linesTaken = linesTaken, lastLine = List.head lines }
+
+    else
+        case lines of
+            [] ->
+                { linesTaken = linesTaken, lastLine = Nothing }
+
+            line :: rest ->
+                takeNLines (n - 1)
+                    rest
+                    (linesTaken ++ "\n" ++ line)
 
 
 type RuleProjectVisitor
diff --git a/tests/NoNegationInIfConditionTest.elm b/tests/NoNegationInIfConditionTest.elm
index 57902870..4adac38c 100644
--- a/tests/NoNegationInIfConditionTest.elm
+++ b/tests/NoNegationInIfConditionTest.elm
@@ -53,6 +53,30 @@ a =
         2
     else
         1
+"""
+                        ]
+        , test "should correctly extract sources containing 2-part UTF-16 characters" <|
+            \() ->
+                """module A exposing (..)
+a =
+    if not condition then
+        "first🔧"
+    else
+        "second🌐"
+"""
+                    |> Review.Test.run rule
+                    |> Review.Test.expectErrors
+                        [ Review.Test.error
+                            { message = "Don't use if expressions with negated conditions"
+                            , details = [ "We at fruits.com think that if expressions are more readable when the condition is not negated." ]
+                            , under = "not"
+                            }
+                            |> Review.Test.whenFixed """module A exposing (..)
+a =
+    if  condition then
+        "second🌐"
+    else
+        "first🔧"
 """
                         ]
         ]