jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-20 04:27:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Do not report position errors for global errors

Browse Source
This commit is contained in:
Jeroen Engels 2021-03-03 08:52:49 +01:00
parent 3d2b7234f9
commit 5b951a9207
1 changed files with 38 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
src/Review/Test.elm
View File

@ -1164,43 +1164,47 @@ checkErrorMatch codeInspector ((ExpectedError expectedError_) as expectedError)
checkMessageAppearsUnder : CodeInspector -> ReviewError -> ExpectedError -> (() -> Expectation)
checkMessageAppearsUnder codeInspector error_ (ExpectedError expectedError) =
case codeInspector.getCodeAtLocation (Rule.errorRange error_) of
Just codeAtLocation ->
case expectedError.under of
Under under ->
Expect.all
[ \() ->
case under of
"" ->
FailureMessage.underMayNotBeEmpty
{ message = expectedError.message
, codeAtLocation = codeAtLocation
}
|> Expect.fail
if Rule.errorTarget error_ == Error.UserGlobal then
\() -> Expect.pass
_ ->
Expect.pass
, \() ->
(codeAtLocation == under)
|> Expect.true (FailureMessage.underMismatch error_ { under = under, codeAtLocation = codeAtLocation })
, \() ->
codeInspector.checkIfLocationIsAmbiguous error_ under
]
else
case codeInspector.getCodeAtLocation (Rule.errorRange error_) of
Just codeAtLocation ->
case expectedError.under of
Under under ->
Expect.all
[ \() ->
case under of
"" ->
FailureMessage.underMayNotBeEmpty
{ message = expectedError.message
, codeAtLocation = codeAtLocation
}
|> Expect.fail
UnderExactly under range ->
Expect.all
[ \() ->
(codeAtLocation == under)
|> Expect.true (FailureMessage.underMismatch error_ { under = under, codeAtLocation = codeAtLocation })
, \() ->
(Rule.errorRange error_ == range)
|> Expect.true (FailureMessage.wrongLocation error_ range under)
]
_ ->
Expect.pass
, \() ->
(codeAtLocation == under)
|> Expect.true (FailureMessage.underMismatch error_ { under = under, codeAtLocation = codeAtLocation })
, \() ->
codeInspector.checkIfLocationIsAmbiguous error_ under
]
Nothing ->
\() ->
FailureMessage.locationNotFound error_
|> Expect.fail
UnderExactly under range ->
Expect.all
[ \() ->
(codeAtLocation == under)
|> Expect.true (FailureMessage.underMismatch error_ { under = under, codeAtLocation = codeAtLocation })
, \() ->
(Rule.errorRange error_ == range)
|> Expect.true (FailureMessage.wrongLocation error_ range under)
]
Nothing ->
\() ->
FailureMessage.locationNotFound error_
|> Expect.fail
checkDetailsAreCorrect : ReviewError -> ExpectedError -> (() -> Expectation)