jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2025-01-08 02:36:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

Take globs by default

Browse Source
This commit is contained in:
Jeroen Engels 2024-03-23 09:38:09 +01:00
parent 51e3bfb9e0
commit 6039aed3e8
2 changed files with 17 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/NoUnknownCssClasses.elm
View File

@ -1,6 +1,6 @@
module NoUnknownCssClasses exposing module NoUnknownCssClasses exposing
( rule ( rule
, CssArgument(..), defaults, fromLiteral, withCssFiles, withCssUsingFunctions, withHardcodedKnownClasses , CssArgument(..), cssFiles, fromLiteral, withCssUsingFunctions, withHardcodedKnownClasses
) )
{-| {-|
@ -77,11 +77,11 @@ type Configuration
} }
defaults : Configuration cssFiles : List String -> Configuration
defaults = cssFiles globs =
Configuration Configuration
{ knownClasses = Set.empty { knownClasses = Set.empty
, cssFiles = [] , cssFiles = globs
, cssFunctions = baseCssFunctions , cssFunctions = baseCssFunctions
} }
@ -110,11 +110,6 @@ withCssUsingFunctions newFunctions (Configuration configuration) =
Configuration { configuration | cssFunctions = Dict.union newFunctions configuration.cssFunctions } Configuration { configuration | cssFunctions = Dict.union newFunctions configuration.cssFunctions }
withCssFiles : List String -> Configuration -> Configuration
withCssFiles list (Configuration configuration) =
Configuration { configuration | cssFiles = list ++ configuration.cssFiles }
type alias ProjectContext = type alias ProjectContext =
{ knownClasses : Set String { knownClasses : Set String
} }

26
tests/NoUnknownCssClassesTest.elm
View File

@ -3,7 +3,7 @@ module NoUnknownCssClassesTest exposing (all)
import Dict import Dict
import Elm.Syntax.Expression exposing (Expression) import Elm.Syntax.Expression exposing (Expression)
import Elm.Syntax.Node exposing (Node) import Elm.Syntax.Node exposing (Node)
import NoUnknownCssClasses exposing (CssArgument, defaults, fromLiteral, rule, withCssFiles, withCssUsingFunctions, withHardcodedKnownClasses) import NoUnknownCssClasses exposing (CssArgument, cssFiles, fromLiteral, rule, withCssUsingFunctions, withHardcodedKnownClasses)
import Review.Project as Project exposing (Project) import Review.Project as Project exposing (Project)
import Review.Test import Review.Test
import Review.Test.Dependencies import Review.Test.Dependencies
@ -22,7 +22,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [] [ Html.text "ok" ] Html.span [] [ Html.text "ok" ]
""" """
|> Review.Test.run (rule defaults) |> Review.Test.run (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering an unknown CSS class through Html.Attributes.class" <| , test "should report an error when encountering an unknown CSS class through Html.Attributes.class" <|
\() -> \() ->
@ -33,7 +33,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class "unknown" ] [] Html.span [ Attr.class "unknown" ] []
""" """
|> Review.Test.run (defaults |> withHardcodedKnownClasses [ "known", "bar", "unknown2" ] |> rule) |> Review.Test.run (cssFiles [ "*.css" ] |> withHardcodedKnownClasses [ "known", "bar", "unknown2" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -53,7 +53,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class "known" ] [] Html.span [ Attr.class "known" ] []
""" """
|> Review.Test.run (defaults |> withHardcodedKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ "*.css" ] |> withHardcodedKnownClasses [ "known" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering an unknown CSS class through Html.Attributes.class in <| pipe" <| , test "should report an error when encountering an unknown CSS class through Html.Attributes.class in <| pipe" <|
\() -> \() ->
@ -64,7 +64,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ Attr.class <| "unknown" ] [] Html.span [ Attr.class <| "unknown" ] []
""" """
|> Review.Test.run (rule defaults) |> Review.Test.run (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -81,7 +81,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ "unknown" |> Attr.class ] [] Html.span [ "unknown" |> Attr.class ] []
""" """
|> Review.Test.run (rule defaults) |> Review.Test.run (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Unknown CSS class \"unknown\"" { message = "Unknown CSS class \"unknown\""
@ -98,7 +98,7 @@ import Html.Attributes as Attr
view model = view model =
Html.span [ "known red-faint under_score" |> Attr.class ] [] Html.span [ "known red-faint under_score" |> Attr.class ] []
""" """
|> Review.Test.runWithProjectData projectWithCssClasses (defaults |> withCssFiles [ "*.css" ] |> rule) |> Review.Test.runWithProjectData projectWithCssClasses (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should report an error when encountering a non-literal argument for Html.Attributes.class" <| , test "should report an error when encountering a non-literal argument for Html.Attributes.class" <|
\() -> \() ->
@ -109,7 +109,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.class model.class Attr.class model.class
""" """
|> Review.Test.run (rule defaults) |> Review.Test.run (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -126,7 +126,7 @@ import Html.Attributes as Attr
view model = view model =
Attr.classList model.classList Attr.classList model.classList
""" """
|> Review.Test.run (rule defaults) |> Review.Test.run (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -146,7 +146,7 @@ view model =
, ( variable, model.b ) , ( variable, model.b )
] ]
""" """
|> Review.Test.run (defaults |> withHardcodedKnownClasses [ "known" ] |> rule) |> Review.Test.run (cssFiles [ "*.css" ] |> withHardcodedKnownClasses [ "known" ] |> rule)
|> Review.Test.expectErrors |> Review.Test.expectErrors
[ Review.Test.error [ Review.Test.error
{ message = "Non-literal argument to CSS class function" { message = "Non-literal argument to CSS class function"
@ -163,7 +163,7 @@ view model =
Class.fromString "known" Class.fromString "known"
""" """
|> Review.Test.run |> Review.Test.run
(defaults (cssFiles [ "*.css" ]
|> withHardcodedKnownClasses [ "known" ] |> withHardcodedKnownClasses [ "known" ]
|> withCssUsingFunctions (Dict.fromList [ ( ( [ "Class" ], "fromString" ), classFromAttrFunction ) ]) |> withCssUsingFunctions (Dict.fromList [ ( ( [ "Class" ], "fromString" ), classFromAttrFunction ) ])
|> rule |> rule
@ -178,7 +178,7 @@ view model =
Class.fromString model.a Class.fromString model.a
""" """
|> Review.Test.run |> Review.Test.run
(defaults (cssFiles [ "*.css" ]
|> withHardcodedKnownClasses [ "known" ] |> withHardcodedKnownClasses [ "known" ]
|> withCssUsingFunctions (Dict.fromList [ ( ( [ "Class" ], "fromString" ), classFromAttrFunction ) ]) |> withCssUsingFunctions (Dict.fromList [ ( ( [ "Class" ], "fromString" ), classFromAttrFunction ) ])
|> rule |> rule
@ -198,7 +198,7 @@ import Class
view model = view model =
Class.fromString model.a Class.fromString model.a
""" """
|> Review.Test.runWithProjectData projectWithUnparsableCssClasses (defaults |> withCssFiles [ "*.css" ] |> rule) |> Review.Test.runWithProjectData projectWithUnparsableCssClasses (cssFiles [ "*.css" ] |> rule)
|> Review.Test.expectErrorsForModules |> Review.Test.expectErrorsForModules
[ ( "some-file.css" [ ( "some-file.css"
, [ Review.Test.error , [ Review.Test.error