jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Extract global error into top-level function

Browse Source
This commit is contained in:
Jeroen Engels 2020-08-20 22:33:45 +02:00
parent 0cfa3b89f4
commit 679dcde4ed
1 changed files with 26 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/Review/Rule.elm
View File

@ -378,28 +378,7 @@ review rules project =
[] ->
case Review.Project.modules project |> duplicateModuleNames Dict.empty of
Just duplicate ->
let
paths : String
paths =
duplicate.paths
|> List.sort
|> List.map (\s -> "\n - " ++ s)
|> String.join ""
in
( [ Review.Error.ReviewError
{ filePath = "GLOBAL ERROR"
, ruleName = "Incorrect project"
, message = "Found several modules named `" ++ String.join "." duplicate.moduleName ++ "`"
, details =
[ "I found several modules with the name `" ++ String.join "." duplicate.moduleName ++ "`. Depending on how I choose to resolve this, I might give you different reports. Since this is a compiler error anyway, I require this problem to be solved. Please fix this then try running `elm-review` again."
, "Here are the paths to some of the files that share a module name:" ++ paths
, "It is possible that you requested me to look at several projects, and that modules from each project share the same name. I don't recommend reviewing several projects at the same time, as I can only handle one `elm.json`. I instead suggest running `elm-review` twice, once for each project."
]
, range = { start = { row = 0, column = 0 }, end = { row = 0, column = 0 } }
, fixes = Nothing
, target = Review.Error.Global
}
]
( [ duplicateModulesGlobalError duplicate ]
, rules
)
@ -437,6 +416,31 @@ review rules project =
( List.map parsingError modulesThatFailedToParse, rules )
duplicateModulesGlobalError : { moduleName : ModuleName, paths : List String } -> ReviewError
duplicateModulesGlobalError duplicate =
let
paths : String
paths =
duplicate.paths
|> List.sort
|> List.map (\s -> "\n - " ++ s)
|> String.join ""
in
Review.Error.ReviewError
{ filePath = "GLOBAL ERROR"
, ruleName = "Incorrect project"
, message = "Found several modules named `" ++ String.join "." duplicate.moduleName ++ "`"
, details =
[ "I found several modules with the name `" ++ String.join "." duplicate.moduleName ++ "`. Depending on how I choose to resolve this, I might give you different reports. Since this is a compiler error anyway, I require this problem to be solved. Please fix this then try running `elm-review` again."
, "Here are the paths to some of the files that share a module name:" ++ paths
, "It is possible that you requested me to look at several projects, and that modules from each project share the same name. I don't recommend reviewing several projects at the same time, as I can only handle one `elm.json`. I instead suggest running `elm-review` twice, once for each project."
]
, range = { start = { row = 0, column = 0 }, end = { row = 0, column = 0 } }
, fixes = Nothing
, target = Review.Error.Global
}
runRules : List Rule -> Project -> List (Graph.NodeContext ModuleName ()) -> ( List (Error {}), List Rule )
runRules rules project nodeContexts =
List.foldl