jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Extract data out of the rule implementation

Browse Source
This commit is contained in:
Jeroen Engels 2020-08-20 23:00:47 +02:00
parent c4f1a268d6
commit 7eb9d07e0f
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/Review/Rule.elm
View File

@ -410,12 +410,18 @@ review rules project =
Ok nodeContexts ->
let
(Rule { ruleImplementation }) =
scopeRule
( scopeErrors, newScopeRule ) =
( scopeErrors, newScopeRule, cache ) =
-- TODO Later use newScopeRule for to avoid recomputing it all over everytime
ruleImplementation Exceptions.init project nodeContexts
runProjectVisitor
"DUMMY"
scopeRule
Nothing
Exceptions.init
project
nodeContexts
_ =
Debug.log "cache" cache
in
if not (List.isEmpty scopeErrors) then
( List.map errorToReviewError scopeErrors, rules )
@ -3963,8 +3969,8 @@ isInSourceDirectories (Metadata metadata) =
-- SCOPE RULE
scopeRule : Rule
scopeRule : RunnableProjectVisitor () moduleContext
scopeRule =
newModuleRuleSchema "DUMMY" ()
|> withSimpleExpressionVisitor (\_ -> [])
|> fromModuleRuleSchema
newProjectRuleSchema "DUMMY" ()
|> withElmJsonProjectVisitor (\_ () -> ( [], () ))
|> fromProjectRuleSchemaToRunnableProjectVisitor