jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-24 02:02:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use simpler version of declaration visitor if there is no expression visitor

Browse Source
This commit is contained in:
Jeroen Engels 2021-10-27 18:12:27 +02:00
parent ec104687a6
commit 81d4eeec76
1 changed files with 29 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
src/Review/Rule.elm
View File

@ -1317,19 +1317,28 @@ mergeModuleVisitors initialProjectContext maybeModuleContextCreator visitors =
fromModuleRuleSchemaToRunnableModuleVisitor : ModuleRuleSchema schemaState moduleContext -> RunnableModuleVisitor moduleContext
fromModuleRuleSchemaToRunnableModuleVisitor (ModuleRuleSchema schema) =
let
expressionVisitor : Maybe (Node Expression -> ( List (Error {}), moduleContext ) -> ( List (Error {}), moduleContext ))
expressionVisitor =
maybeExpressionVisitor : Maybe (Node Expression -> ( List (Error {}), moduleContext ) -> ( List (Error {}), moduleContext ))
maybeExpressionVisitor =
createExpressionVisitor schema
declarationAndExpressionVisitor : List (Node Declaration) -> ( List (Error {}), moduleContext ) -> ( List (Error {}), moduleContext )
declarationAndExpressionVisitor =
if shouldVisitDeclarationsAndExpressions schema then
accumulateList
(visitDeclaration
(List.reverse schema.declarationVisitorsOnEnter)
schema.declarationVisitorsOnExit
(Maybe.withDefault (\_ errorsAndContext -> errorsAndContext) expressionVisitor)
)
case maybeExpressionVisitor of
Just expressionVisitor ->
accumulateList
(visitDeclaration
(List.reverse schema.declarationVisitorsOnEnter)
schema.declarationVisitorsOnExit
expressionVisitor
)
Nothing ->
accumulateList
(visitOnlyDeclaration
(List.reverse schema.declarationVisitorsOnEnter)
schema.declarationVisitorsOnExit
)
else
\_ errorsAndContext -> errorsAndContext
@ -4451,6 +4460,18 @@ visitDeclaration declarationVisitorsOnEnter declarationVisitorsOnExit expression
|> visitWithListOfVisitors declarationVisitorsOnExit node
visitOnlyDeclaration :
List (Visitor Declaration moduleContext)
-> List (Visitor Declaration moduleContext)
-> Node Declaration
-> moduleContext
-> ( List (Error {}), moduleContext )
visitOnlyDeclaration declarationVisitorsOnEnter declarationVisitorsOnExit node moduleContext =
( [], moduleContext )
|> visitWithListOfVisitors declarationVisitorsOnEnter node
|> visitWithListOfVisitors declarationVisitorsOnExit node
visitExpression :
ExpressionRelatedVisitors moduleContext
-> Node Expression